DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit
@ 2014-09-30 11:14 Hiroshi Shimamoto
  2014-09-30 13:39 ` Xie, Huawei
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Hiroshi Shimamoto @ 2014-09-30 11:14 UTC (permalink / raw)
  To: dev; +Cc: Hayato Momma

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

To reduce instruction cache miss, add branch condition hints into
recv/xmit functions. This improves a bit performance.

We can see performance improvements with memnic-tester.
Using Xeon E5-2697 v2 @ 2.70GHz, 4 vCPU.
 size |  before  |  after
   64 | 5.54Mpps | 5.55Mpps
  128 | 5.46Mpps | 5.44Mpps
  256 | 5.21Mpps | 5.22Mpps
  512 | 4.50Mpps | 4.52Mpps
 1024 | 3.71Mpps | 3.73Mpps
 1280 | 3.21Mpps | 3.22Mpps
 1518 | 2.92Mpps | 2.93Mpps

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
 pmd/pmd_memnic.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index 7fc3093..875d3ea 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -289,26 +289,26 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
 	int idx, next;
 	struct rte_eth_stats *st = &adapter->stats[rte_lcore_id()];
 
-	if (!adapter->nic->hdr.valid)
+	if (unlikely(!adapter->nic->hdr.valid))
 		return 0;
 
 	pkts = bytes = errs = 0;
 	idx = adapter->up_idx;
 	for (nr = 0; nr < nb_pkts; nr++) {
 		p = &data->packets[idx];
-		if (p->status != MEMNIC_PKT_ST_FILLED)
+		if (unlikely(p->status != MEMNIC_PKT_ST_FILLED))
 			break;
 		/* prefetch the next area */
 		next = idx;
-		if (++next >= MEMNIC_NR_PACKET)
+		if (unlikely(++next >= MEMNIC_NR_PACKET))
 			next = 0;
 		rte_prefetch0(&data->packets[next]);
-		if (p->len > framesz) {
+		if (unlikely(p->len > framesz)) {
 			errs++;
 			goto drop;
 		}
 		mb = rte_pktmbuf_alloc(adapter->mp);
-		if (!mb)
+		if (unlikely(!mb))
 			break;
 
 		rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
@@ -350,7 +350,7 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,
 	uint64_t pkts, bytes, errs;
 	uint32_t framesz = adapter->framesz;
 
-	if (!adapter->nic->hdr.valid)
+	if (unlikely(!adapter->nic->hdr.valid))
 		return 0;
 
 	pkts = bytes = errs = 0;
@@ -360,7 +360,7 @@ static uint16_t memnic_xmit_pkts(void *tx_queue,
 		struct rte_mbuf *sg;
 		void *ptr;
 
-		if (pkt_len > framesz) {
+		if (unlikely(pkt_len > framesz)) {
 			errs++;
 			break;
 		}
@@ -379,7 +379,7 @@ retry:
 			goto retry;
 		}
 
-		if (idx != ACCESS_ONCE(adapter->down_idx)) {
+		if (unlikely(idx != ACCESS_ONCE(adapter->down_idx))) {
 			/*
 			 * host freed this and got false positive,
 			 * need to recover the status and retry.
@@ -388,7 +388,7 @@ retry:
 			goto retry;
 		}
 
-		if (++idx >= MEMNIC_NR_PACKET)
+		if (unlikely(++idx >= MEMNIC_NR_PACKET))
 			idx = 0;
 		adapter->down_idx = idx;
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2014-10-02  2:36 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-30 11:14 [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit Hiroshi Shimamoto
2014-09-30 13:39 ` Xie, Huawei
2014-10-01  0:01   ` Hiroshi Shimamoto
2014-10-01  6:12     ` Thomas Monjalon
2014-09-30 14:32 ` Neil Horman
2014-09-30 23:52   ` Hiroshi Shimamoto
2014-10-01  8:44     ` Bruce Richardson
2014-10-01  9:12       ` Hiroshi Shimamoto
2014-10-01 11:13         ` Neil Horman
2014-10-01 23:33           ` Hiroshi Shimamoto
2014-10-02  2:01             ` Neil Horman
2014-10-02  2:07               ` Hiroshi Shimamoto
2014-10-02  2:42                 ` Neil Horman
2014-10-01 11:09       ` Neil Horman
2014-09-30 14:38 ` Xie, Huawei
2014-09-30 14:51   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).