* [dpdk-dev] [PATCH] mk: fix LDFLAGS for shared lib
@ 2014-12-03 23:33 Hiroshi Shimamoto
2014-12-08 15:01 ` [dpdk-dev] " Neil Horman
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Shimamoto @ 2014-12-03 23:33 UTC (permalink / raw)
To: dev; +Cc: Hayato Momma
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
It should be LDFLAGS to build the library with correct linkage options.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
mk/rte.sharelib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
index c0a811a..df6c268 100644
--- a/mk/rte.sharelib.mk
+++ b/mk/rte.sharelib.mk
@@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
-O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
+O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] mk: fix LDFLAGS for shared lib
2014-12-03 23:33 [dpdk-dev] [PATCH] mk: fix LDFLAGS for shared lib Hiroshi Shimamoto
@ 2014-12-08 15:01 ` Neil Horman
2014-12-08 23:44 ` Hiroshi Shimamoto
0 siblings, 1 reply; 4+ messages in thread
From: Neil Horman @ 2014-12-08 15:01 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: dev, Hayato Momma
On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
> It should be LDFLAGS to build the library with correct linkage options.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
>
> ---
> mk/rte.sharelib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
> index c0a811a..df6c268 100644
> --- a/mk/rte.sharelib.mk
> +++ b/mk/rte.sharelib.mk
> @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
>
> OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
>
> -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
> O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
> O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
Does this continue to work on cross compiled arches (32 bit on 64 bit systems
and vice versa)? I have this recollection that something in CPU_LDFLAGS was
needed
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] mk: fix LDFLAGS for shared lib
2014-12-08 15:01 ` [dpdk-dev] " Neil Horman
@ 2014-12-08 23:44 ` Hiroshi Shimamoto
2014-12-11 0:46 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Shimamoto @ 2014-12-08 23:44 UTC (permalink / raw)
To: Neil Horman; +Cc: dev, Hayato Momma
> Subject: Re: [dpdk-dev] mk: fix LDFLAGS for shared lib
>
> On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote:
> > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >
> > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
> > It should be LDFLAGS to build the library with correct linkage options.
> >
> > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> > Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
> >
> > ---
> > mk/rte.sharelib.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
> > index c0a811a..df6c268 100644
> > --- a/mk/rte.sharelib.mk
> > +++ b/mk/rte.sharelib.mk
> > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
> >
> > OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
> >
> > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> > O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
> > O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
> > O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
>
> Does this continue to work on cross compiled arches (32 bit on 64 bit systems
> and vice versa)? I have this recollection that something in CPU_LDFLAGS was
> needed
yes, LDFLAGS must contain CPU_LDFLAGS.
mk/target/generic/rte.vars.mk:# merge all LDFLAGS
mk/target/generic/rte.vars.mk:LDFLAGS := $(CPU_LDFLAGS) $(EXECENV_LDFLAGS) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS)
mk/target/generic/rte.vars.mk:LDFLAGS += $(TARGET_LDFLAGS)
thanks,
Hiroshi
> Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] mk: fix LDFLAGS for shared lib
2014-12-08 23:44 ` Hiroshi Shimamoto
@ 2014-12-11 0:46 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2014-12-11 0:46 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: dev, Hayato Momma
2014-12-08 23:44, Hiroshi Shimamoto:
> > On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote:
> > > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> > >
> > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
> > > It should be LDFLAGS to build the library with correct linkage options.
> > >
> > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> > > Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
> > >
> > > ---
> > > mk/rte.sharelib.mk | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
> > > index c0a811a..df6c268 100644
> > > --- a/mk/rte.sharelib.mk
> > > +++ b/mk/rte.sharelib.mk
> > > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
> > >
> > > OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
> > >
> > > -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> > > +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> > > O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
> > > O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
> > > O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
> >
> > Does this continue to work on cross compiled arches (32 bit on 64 bit systems
> > and vice versa)? I have this recollection that something in CPU_LDFLAGS was
> > needed
>
> yes, LDFLAGS must contain CPU_LDFLAGS.
>
> mk/target/generic/rte.vars.mk:# merge all LDFLAGS
> mk/target/generic/rte.vars.mk:LDFLAGS := $(CPU_LDFLAGS) $(EXECENV_LDFLAGS) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS)
> mk/target/generic/rte.vars.mk:LDFLAGS += $(TARGET_LDFLAGS)
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-11 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-03 23:33 [dpdk-dev] [PATCH] mk: fix LDFLAGS for shared lib Hiroshi Shimamoto
2014-12-08 15:01 ` [dpdk-dev] " Neil Horman
2014-12-08 23:44 ` Hiroshi Shimamoto
2014-12-11 0:46 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).