From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tyo201.gate.nec.co.jp (TYO201.gate.nec.co.jp [210.143.35.51]) by dpdk.org (Postfix) with ESMTP id 683063B5 for ; Tue, 9 Dec 2014 00:44:44 +0100 (CET) Received: from mailgate3.nec.co.jp ([10.7.69.193]) by tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id sB8Nidl6005085; Tue, 9 Dec 2014 08:44:39 +0900 (JST) Received: from mailsv.nec.co.jp (imss61.nec.co.jp [10.7.69.156]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id sB8NidG02132; Tue, 9 Dec 2014 08:44:39 +0900 (JST) Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2]) by mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id sB8Nicu0026612; Tue, 9 Dec 2014 08:44:38 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.142] [10.38.151.142]) by mail03.kamome.nec.co.jp with ESMTP id BT-MMP-456923; Tue, 9 Dec 2014 08:44:26 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.73]) by BPXC14GP.gisp.nec.co.jp ([10.38.151.142]) with mapi id 14.03.0174.002; Tue, 9 Dec 2014 08:44:26 +0900 From: Hiroshi Shimamoto To: Neil Horman Thread-Topic: [dpdk-dev] mk: fix LDFLAGS for shared lib Thread-Index: AQHQEvgEXP44IiFLRku0X8znJARw/JyGWVdQ Date: Mon, 8 Dec 2014 23:44:24 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05DD32B1@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6@BPXM14GP.gisp.nec.co.jp> <20141208150154.GA3907@localhost.localdomain> In-Reply-To: <20141208150154.GA3907@localhost.localdomain> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Hayato Momma Subject: Re: [dpdk-dev] mk: fix LDFLAGS for shared lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2014 23:44:45 -0000 > Subject: Re: [dpdk-dev] mk: fix LDFLAGS for shared lib >=20 > On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > Only CPU_LDFLAGS is used in mk/rte.sharelib.mk. > > It should be LDFLAGS to build the library with correct linkage options. > > > > Signed-off-by: Hiroshi Shimamoto > > Reviewed-by: Hayato Momma > > > > --- > > mk/rte.sharelib.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk > > index c0a811a..df6c268 100644 > > --- a/mk/rte.sharelib.mk > > +++ b/mk/rte.sharelib.mk > > @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE > > > > OBJS =3D $(wildcard $(RTE_OUTPUT)/build/lib/*.o) > > > > -O_TO_S =3D $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$= (LIB_ONE) > > +O_TO_S =3D $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB= _ONE) > > O_TO_S_STR =3D $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight > > O_TO_S_DISP =3D $(if $(V),"$(O_TO_S_STR)"," LD $(@)") > > O_TO_S_CMD =3D "cmd_$@ =3D $(O_TO_S_STR)" >=20 > Does this continue to work on cross compiled arches (32 bit on 64 bit sys= tems > and vice versa)? I have this recollection that something in CPU_LDFLAGS = was > needed yes, LDFLAGS must contain CPU_LDFLAGS. mk/target/generic/rte.vars.mk:# merge all LDFLAGS mk/target/generic/rte.vars.mk:LDFLAGS :=3D $(CPU_LDFLAGS) $(EXECENV_LDFLAGS= ) $(TOOLCHAIN_LDFLAGS) $(MACHINE_LDFLAGS) mk/target/generic/rte.vars.mk:LDFLAGS +=3D $(TARGET_LDFLAGS) thanks, Hiroshi > Neil