From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id C9306A057C;
Fri, 27 Mar 2020 12:45:27 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A80CD1C132;
Fri, 27 Mar 2020 12:45:27 +0100 (CET)
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com
[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 8E9301C120
for <dev@dpdk.org>; Fri, 27 Mar 2020 12:45:26 +0100 (CET)
Received: by mail-wr1-f65.google.com with SMTP id j17so10974156wru.13
for <dev@dpdk.org>; Fri, 27 Mar 2020 04:45:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=accelercomm-com.20150623.gappssmtp.com; s=20150623;
h=subject:to:references:from:message-id:date:user-agent:mime-version
:in-reply-to:content-transfer-encoding:content-language;
bh=yW3XsC1UjaumBRig96dCieS5o9x2gW/GU4vUckDy12U=;
b=MRxOJJMCAF5W/fmM0rYtxBeh1Xw50tbQdUPBGpk+nMCdqhA+uip9xgkotDV6NzUbyA
FVcPmnJjkH1vcgrTcNRQuUj2B1n03gKPEcqz3AjGlCLQkKSmhSnb/40Qm5pvSTkCK34/
GdwvvDJWf8sPW7eTpfKHBOJFolq6hWLAEdziYkWINj724vWmrJpXZ5pCnJLrtFjTMBRr
ErxLrJIP8LLIqQgnlyPYs8PR5zsGKoOecUGS/SMcsc2xSWBK8f5Vk5lt4CqGhRTlMzca
LRcAp6hfDChmZNDMnr8mc2kpqlRS2/XHFRz6pHOgT2gzyv3VhwcHWN2Areu2Fu/01a3P
Z7CQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=yW3XsC1UjaumBRig96dCieS5o9x2gW/GU4vUckDy12U=;
b=FQpD5Rl+M2pqurDeOPSCa31qW8S//K4KiVdtGhOmr3ymK47SGGCPKk5Rn/4h5UvQ7w
3bB/3hqRt4uTe2JbDmu5XQ84PoNH/N86EUo6O2+NBDLDKhhkPUluxZdq45Yj2rbIW/Ww
x7MsJ2o53+VjrYSUqLlVy6TTo4+wWC7Ac20LiHDpIEOD/QLc+HGYh7q6kLOGIGaBGOkB
zdgQDJ5EUpz8idv2p+Or7igA2jDB+UQ1QPoSxmkQ3evXGQXH465gHG+YNWmQaeRSsEpw
grmvcIdcsFXdXtgLjgyV+Wk38M8UbpKnjaoa/NVtDg+njOmsyK1yoljE989dx1Z04V+S
p0Sw==
X-Gm-Message-State: ANhLgQ05GnLSAOGZ9B7Sz2InSZpqorgN7FNuLlHevWnxR9Qz+x31yoBW
nzXwuLdxT0PWf/cHtMlRtQ76xBHrzQ4=
X-Google-Smtp-Source: ADFU+vt7t3MSb4OmYDpJpItEvHeA3NmT/kL+kSDjJx7s0KobGf6oBQKyZ+aYN3DrZZHdPajfdG/4Bw==
X-Received: by 2002:adf:e8cc:: with SMTP id k12mr15070895wrn.144.1585309526115;
Fri, 27 Mar 2020 04:45:26 -0700 (PDT)
Received: from ?IPv6:2a00:23c4:cf2d:a200:6023:b810:2491:c6a9?
([2a00:23c4:cf2d:a200:6023:b810:2491:c6a9])
by smtp.gmail.com with ESMTPSA id m3sm7378956wmm.3.2020.03.27.04.45.25
for <dev@dpdk.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Fri, 27 Mar 2020 04:45:25 -0700 (PDT)
To: dev@dpdk.org
References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com>
<1585193268-74468-1-git-send-email-nicolas.chautru@intel.com>
<1585193268-74468-4-git-send-email-nicolas.chautru@intel.com>
From: Dave Burley <dave.burley@accelercomm.com>
Message-ID: <7a16a0b4-6e29-e832-e90f-3056bcee8568@accelercomm.com>
Date: Fri, 27 Mar 2020 11:45:25 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <1585193268-74468-4-git-send-email-nicolas.chautru@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v5 03/10] baseband/turbo_sw: fix the exposed
LLR decimals assumption
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Acked-by: Dave Burley <dave.burley@accelercomm.com>
On 26/03/2020 03:27, Nicolas Chautru wrote:
> From: Nic Chautru <nicolas.chautru@intel.com>
>
> The actual LLR representation was incorrectly assumed to be 2
> instead of 4. This would impact wireless performance but is not
> critical to be back ported on LTS branches.
>
> Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G")
>
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> index 6d5e080..5ca8ca1 100644
> --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> @@ -218,7 +218,7 @@ struct turbo_sw_queue {
> RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE |
> RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE,
> .llr_size = 8,
> - .llr_decimals = 2,
> + .llr_decimals = 4,
> .num_buffers_src =
> RTE_BBDEV_LDPC_MAX_CODE_BLOCKS,
> .num_buffers_hard_out =