From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 48C762965 for ; Thu, 29 Mar 2018 11:20:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 02:20:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="215745723" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.75]) ([10.252.18.75]) by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2018 02:20:26 -0700 To: Tomasz Duszynski , dpdk-dev References: <20180327174052.266285-1-ferruh.yigit@intel.com> <20180329061723.GA31647@sh> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR1xgUJB33UawAKCRD5M+tD3xNhH3TID/wNjq1doFXg49WaM7ZXez/1 qwj7U6FQ2eUhlEPX8dXc52cu+iQk8/mssXQtANEx+jndxfvlkikBNgI+mr3m/ho54uQWFZd7 Bv0DVVkLHNkLWK6tT6iISdCgXrQuOv8y5rucEGkJ8dDPsp8Mqr4sBjavRBpczphoa3miKusA HzUEo0SYuHUPmBlbmvKv4PkA5quWtXpkgV2HZ1bW9X0dQkAqEVioAPm5Q6pXJODfV8kaZUtJ z4swEtBnK9XAWm2HccF7KmFh0vv+Zh9lEMnEFt7UPXngY6+xCTo6xV1IVc8EZfDjOip8I4h2 ALMaLgrZwA9VVmHCVOrnO3UZqfGehrwz4O3sUrcmIzxjk3gfBmVRCBfuWGchSpWtZ99U6V1a OEuG+ymyjBDtyymW+KSvmCBl2gIxZHvZFvSRRdDObkkUIskSJ95f/6HBOESRZBOiV9GEAhC5 gI9OAKKF8HQaN/r5KJrkzscjQcjIdV1jXhTkfQ4wH3GJiVM5JxsKsEjjRw7yfSJo2GBEGqMe KMwMLWg4f1DgVtjOuGf10isu+29MvapW2IxKYaHcVc2vHfWbDi2AvBj/VAzKILWbTEgI1VL5 zKpo5p6X2O55oEyeflDiAzrUfvLqB4vmTyqXtW6PdLyZC7kXIzmNu6EBVx9oSgy3CADw5saN 0La9OoCAc7Tn+s7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKA== Message-ID: <7a1cea48-0ce0-550b-fddb-4eaa2ef55ea8@intel.com> Date: Thu, 29 Mar 2018 10:20:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180329061723.GA31647@sh> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 09:20:28 -0000 On 3/29/2018 7:17 AM, Tomasz Duszynski wrote: > On Tue, Mar 27, 2018 at 06:40:52PM +0100, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with generic device struct and updating >> places that are using pci device in a way to get this information from >> generic device. >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Pablo de Lara >> >> There is no deprecation notice sent for this update but in this release >> ethdev info already updated and ABI already broken, it can be good >> opportunity for this update. >> --- >> app/test-pmd/config.c | 11 ++++++++++- >> app/test-pmd/testpmd.h | 24 ++++++++++++++++++------ >> drivers/net/af_packet/rte_eth_af_packet.c | 1 + >> drivers/net/ark/ark_ethdev.c | 4 +++- >> drivers/net/avf/avf_ethdev.c | 2 +- >> drivers/net/avp/avp_ethdev.c | 2 +- >> drivers/net/bnx2x/bnx2x_ethdev.c | 2 +- >> drivers/net/bnxt/bnxt_ethdev.c | 2 +- >> drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- >> drivers/net/dpaa/dpaa_ethdev.c | 1 + >> drivers/net/dpaa2/dpaa2_ethdev.c | 1 + >> drivers/net/e1000/em_ethdev.c | 2 +- >> drivers/net/e1000/igb_ethdev.c | 4 ++-- >> drivers/net/ena/ena_ethdev.c | 2 +- >> drivers/net/enic/enic_ethdev.c | 2 +- >> drivers/net/fm10k/fm10k_ethdev.c | 2 +- >> drivers/net/i40e/i40e_ethdev.c | 2 +- >> drivers/net/i40e/i40e_ethdev_vf.c | 2 +- >> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- >> drivers/net/kni/rte_eth_kni.c | 2 +- >> drivers/net/liquidio/lio_ethdev.c | 2 +- >> drivers/net/mlx4/mlx4_ethdev.c | 2 +- >> drivers/net/mlx5/mlx5_ethdev.c | 2 +- >> drivers/net/mrvl/mrvl_ethdev.c | 2 ++ >> drivers/net/nfp/nfp_net.c | 2 +- >> drivers/net/null/rte_eth_null.c | 1 + >> drivers/net/octeontx/octeontx_ethdev.c | 2 +- >> drivers/net/pcap/rte_eth_pcap.c | 1 + >> drivers/net/qede/qede_ethdev.c | 2 +- >> drivers/net/ring/rte_eth_ring.c | 1 + >> drivers/net/sfc/sfc_ethdev.c | 2 +- >> drivers/net/szedata2/rte_eth_szedata2.c | 2 +- >> drivers/net/tap/rte_eth_tap.c | 2 +- >> drivers/net/thunderx/nicvf_ethdev.c | 2 +- >> drivers/net/virtio/virtio_ethdev.c | 2 +- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- >> examples/ethtool/lib/rte_ethtool.c | 15 +++++++++------ >> examples/ip_pipeline/init.c | 10 ++++++++-- >> examples/kni/main.c | 10 +++++++--- >> lib/librte_ether/rte_ethdev.h | 2 +- >> test/test/test_kni.c | 28 ++++++++++++++++++++++------ >> 41 files changed, 114 insertions(+), 54 deletions(-) >> > > [...] > >> diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c >> index c0483b912..d46c65255 100644 >> --- a/drivers/net/mrvl/mrvl_ethdev.c >> +++ b/drivers/net/mrvl/mrvl_ethdev.c >> @@ -1314,6 +1314,8 @@ static void >> mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unused, >> struct rte_eth_dev_info *info) >> { >> + info->device = dev->device; > > Since dev is used perhaps __rte_unused can be dropped. > Besides that, OK, I will send new version. (reduced cc list)