From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com
 [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 2D2C41B839
 for <dev@dpdk.org>; Tue, 24 Oct 2017 17:18:29 +0200 (CEST)
Received: by mail-wr0-f193.google.com with SMTP id w105so11750550wrc.0
 for <dev@dpdk.org>; Tue, 24 Oct 2017 08:18:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :in-reply-to:references;
 bh=SUADeibJ+VjLbkCqbq23cKXFMuFUeab/xHtGLvwsoRM=;
 b=BHRc7PsjUXMKpMTq840+ySBl5htBlSESgN/aO4tSrzmal3FZvfwAfJ+Fdgq9OW+rX9
 xyFIPEeLHPcqzhzTybnHZgxpp0LcW3Im1qxAR1AhPWarrPHH48TaUbqHr+TmvF2p3mDk
 Ymr3qETWUn1HrpW5xd4bfVc8BqFHkSdqaVeTfUyVdhmgvoBkNmRPxsi5nftUC4aLhhsN
 /MHmvqDIRCv6B7Lw2xvFRzY9HUDkzd4YYlxShEe1pcwH61owrr/yhEnX00U9ZpJeNsGY
 yyV3CqwUEcsffwal8fumwXXfOUr2Dyqxj6FSXjHuHft6MTKfnB+UV7IRGSAHpc6tR4EK
 U9ew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:in-reply-to:references;
 bh=SUADeibJ+VjLbkCqbq23cKXFMuFUeab/xHtGLvwsoRM=;
 b=XE/OV5p52Zu5Bm8rY9W9Q4+4HnIKoRrqsy7QeMO+usL9M8a6fdoH4tAtBcxqg9LGst
 T6O7JBysEqpktzHIoIOrny0FXAs4VNXaQXZzr/qaDgnCVTSStOswbu9IPjW6RC6HVNgX
 BtpZykBIwJ83UUDh8vJ80xVpb5MLcWq2n13Pf1qmSdPVwjUrS7MRIIiU1SFOl1AgEPPh
 js/+OAz6pgTtDeIenhzmG2VbSy26K6SzHH4o4Bdga0bOGWm+UANIC2gXF9safHmT3uKj
 aVouZI4JpqKNZWwV1DkUxiEYLC5aVYEdskLV8liCRONRSUqOB4avkDF7uPCaOJoxDWov
 DUsA==
X-Gm-Message-State: AMCzsaX8NkNW6JuWkwelgSW4p1zOEX8I0T/wHsVhtv5SYJ9n21CzN4VA
 JmUxqej9JDtUZD7z5OWNkVLmmvQP2A==
X-Google-Smtp-Source: ABhQp+RqHVTUjkDBDaIFM+1sFPcW7HM70XDtWsrJDzbXnz0KobBoeeWkgYz9C0JERopemukgn/teSg==
X-Received: by 10.223.129.198 with SMTP id 64mr13839962wra.59.1508858309335;
 Tue, 24 Oct 2017 08:18:29 -0700 (PDT)
Received: from laranjeiro-vm.dev.6wind.com.
 (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id v23sm637300wmh.8.2017.10.24.08.18.28
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 24 Oct 2017 08:18:28 -0700 (PDT)
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: dev@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
Date: Tue, 24 Oct 2017 17:18:12 +0200
Message-Id: <7a36ac63c394ca8a7b5621e192730f9b3cdaf5d3.1508857992.git.nelio.laranjeiro@6wind.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <cover.1508857992.git.nelio.laranjeiro@6wind.com>
References: <cover.1508857992.git.nelio.laranjeiro@6wind.com>
In-Reply-To: <cover.1508857992.git.nelio.laranjeiro@6wind.com>
References: <cover.1508768946.git.nelio.laranjeiro@6wind.com>
 <cover.1508857992.git.nelio.laranjeiro@6wind.com>
Subject: [dpdk-dev] [PATCH v3 1/7] net/mlx5: fix segfault on flow creation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 15:18:30 -0000

When ports are stopped, the hash Rx queue should not be created.

Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 440bda9a1..452fde588 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1743,6 +1743,8 @@ priv_flow_create_action_queue_rss(struct priv *priv,
 		flow->frxq[i].ibv_attr = parser->queue[i].ibv_attr;
 		parser->queue[i].ibv_attr = NULL;
 		hash_fields = hash_rxq_init[i].hash_fields;
+		if (!priv->dev->data->dev_started)
+			continue;
 		flow->frxq[i].hrxq =
 			mlx5_priv_hrxq_get(priv,
 					   parser->rss_conf.rss_key,
-- 
2.11.0