Re: [dpdk-dev] [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/31/2020 6:31 PM, Yong Wang wrote:
> 
> -----Original Message-----
> From: Eduard Serra Miralles <eserra@vmware.com>
> Date: Wednesday, March 25, 2020 at 12:19 PM
> To: "dev@dpdk.org" <dev@dpdk.org>
> Cc: Yong Wang <yongwang@vmware.com>
> Subject: [PATCH v6] net/vmxnet3: Added mtu_set() function to allow setting MTU.
> 
>     (Picked up from @Charles Myers patch
>     https://patchwork.dpdk.org/patch/57771/)

Thanks for resurrecting the patch.

>     
>     When the mtu_set() function is not implemented, rte_eth_dev_set_mtu()
>     fails with -ENOTSUP and mtu is not stored in the mtu field in the
>     rte_eth_dev_data.  This causes the mtu in Vmxnet3_MiscConf which is
>     shared with hypervisor to always be set to 1500.
>     
>     This may cause issues receiving jumbo frames on Enhanced Data Path
>     N-VDS.
>     
>     Signed-off-by: Eduard Serra <eserra@vmware.com>
>     Acked-by: Yong Wang <yongwang@vmware.com>
>     ---
> 
> Acked-by: Yong Wang <yongwang@vmware.com>
> 

Applied to dpdk-next-net/master, thanks.