From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C2F1A0093; Thu, 5 May 2022 16:22:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7C794014F; Thu, 5 May 2022 16:22:36 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.129.74]) by mails.dpdk.org (Postfix) with ESMTP id F2AD640042 for ; Thu, 5 May 2022 16:22:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651760554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cEV6tjtYroA6K71Odqv5v7a9SHA3tfxfyoAcN1nvgh8=; b=Mh6roBgdXkYasK1DQDmp7WDcB4dYza9w52ubq+vJ/0g7sIeBto0U0cXZ+TdyVfbh1PYKx5 /kmQrUVpzsllB39oE7zD6A95R5MA7w/WWb4aQtw60v0Urq/4Oz3kBEt5zbGiwls5s56/jq vgIsQp0EalVaaH7AAjpiU7UyGDN4LlE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-XguoGHDBPT-A5hM8wkamqA-1; Thu, 05 May 2022 10:22:33 -0400 X-MC-Unique: XguoGHDBPT-A5hM8wkamqA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2C42811E7A; Thu, 5 May 2022 14:22:32 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4567241617E; Thu, 5 May 2022 14:22:32 +0000 (UTC) Message-ID: <7a460685-57af-c6df-132c-82d97bfcaeac@redhat.com> Date: Thu, 5 May 2022 16:22:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 1/2] vhost: remove unneeded max enums To: David Marchand , dev@dpdk.org Cc: chenbo.xia@intel.com References: <20220425125431.26464-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220425125431.26464-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, On 4/25/22 14:54, David Marchand wrote: > Move message handler description and callbacks into a single array and > remove unneeded VHOST_USER_MAX and VHOST_SLAVE_MAX enums. > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_user/vhost_user.c | 1 - > examples/vhost_blk/blk_spec.h | 1 - > lib/vhost/vhost_user.c | 175 +++++++++----------- > lib/vhost/vhost_user.h | 2 - > 4 files changed, 76 insertions(+), 103 deletions(-) > The patch does a bit more than what the commit title mentions. What about: "vhost: refactor messages handlers declaration"? Other than that, the patch content looks good to me: Reviewed-by: Maxime Coquelin Thanks, Maxime