From: "Xie, WeiX" <weix.xie@intel.com>
To: "Yang, MurphyX" <murphyx.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Yang, MurphyX" <murphyx.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error
Date: Mon, 23 Nov 2020 08:30:46 +0000 [thread overview]
Message-ID: <7a4b5c1ab4e2435da06b44d21c194d11@intel.com> (raw)
In-Reply-To: <20201123070523.21661-1-murphyx.yang@intel.com>
Tested-by: Xie,WeiX < weix.xie@intel.com>
Regards,
Xie Wei
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Murphy Yang
> Sent: Monday, November 23, 2020 3:05 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yang,
> MurphyX <murphyx.yang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum
> error
>
> If enable hardware outer UDP TX offload checksum, it doesn't take effect
> when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
>
> In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT'
> equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can
> calculate the outer tunneling UDP checksum.
>
> Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel")
>
> Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> 5fbd68eafc..9769e216bf 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
> *cd_tunneling |= (tx_offload.l2_len >> 1) <<
> ICE_TXD_CTX_QW0_NATLEN_S;
>
> - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
> - (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
> + /**
> + * Calculate the tunneling UDP checksum.
> + * Shall be set only if L4TUNT = 01b and EIPT is not zero
> + */
> + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
> (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
> *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M; }
> --
> 2.17.1
next prev parent reply other threads:[~2020-11-23 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 7:05 Murphy Yang
2020-11-23 8:30 ` Xie, WeiX [this message]
2020-12-11 2:08 ` Zhang, Qi Z
2024-03-29 8:26 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4b5c1ab4e2435da06b44d21c194d11@intel.com \
--to=weix.xie@intel.com \
--cc=dev@dpdk.org \
--cc=murphyx.yang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).