From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id DBEE1AAB9 for ; Wed, 16 May 2018 17:19:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F3A67D850; Wed, 16 May 2018 15:19:50 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-234.ams2.redhat.com [10.36.117.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34F66215CDA7; Wed, 16 May 2018 15:19:48 +0000 (UTC) To: luca.boccassi@gmail.com, dev@dpdk.org Cc: yliu@fridaylinux.org, thomas@monjalon.net, Luca Boccassi References: <20180516143134.24838-1-luca.boccassi@gmail.com> From: Kevin Traynor Organization: Red Hat Message-ID: <7a747fd8-174c-9c10-b9ab-ed0d74555844@redhat.com> Date: Wed, 16 May 2018 16:19:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180516143134.24838-1-luca.boccassi@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 15:19:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 15:19:50 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 15:19:51 -0000 On 05/16/2018 03:31 PM, luca.boccassi@gmail.com wrote: > From: Luca Boccassi > > We have many stable branches being maintaned at the same time, and typo > sometimes it's not clear which branch a patch is being backported for. > Note in the guidelines that it should be specified via the cover letter, > annotation or using --subject-prefix. > Also note to send only to stable@dpdk.org, not dev@dpdk.org. > > Signed-off-by: Luca Boccassi > --- > doc/guides/contributing/patches.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst > index 2287835f9..1dc623a23 100644 > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > @@ -450,6 +450,14 @@ Experienced committers may send patches directly with ``git send-email`` without > The options ``--annotate`` and ``confirm = always`` are recommended for checking patches before sending. > > > +Backporting patches for Stable Releases > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Sometimes a maintainer or contributor wishes, or can be asked, to send a patch for a stable release rather than mainline. In this case the patch(es) should be sent to ``stable@dpdk.org``, not to ``dev@dpdk.org``. > + > +Given that there are multiple stable releases being maintained at the same time, please specify exactly which branch the patch is for in the cover letter, in the annotation or using ``git send-email --subject-prefix='16.11' ...`` > + s/branch/branch(es)/ How about [16.11] instead of '16.11' ? I would be in favour that the prefix(es) should always be added for this very specific case, as it will make it stand out more. either way, Acked-by: Kevin Traynor > + > The Review Process > ------------------ > >