From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 687C4A0A02; Wed, 24 Mar 2021 12:38:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A1EB4067B; Wed, 24 Mar 2021 12:38:25 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id C1E114014F; Wed, 24 Mar 2021 12:38:23 +0100 (CET) IronPort-SDR: lbCINkuGsdt3FLveTv4hiu+Qt0pBXtUABfgv73Ng1RG/1a+qv4wYlQA+nb65CGWohYbXRqBZYy tH4s3aGfjZ/A== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="170026621" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="170026621" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:38:22 -0700 IronPort-SDR: 3pa9Wr+Dv1tTpkr9xR3ow0Lgoc9sxOgXv5yg9BrjKP5xKB4EGKtleiJIR3zaNJnOWhhYZ1NYmJ 9eot/AFN5wrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="442177920" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 24 Mar 2021 04:38:22 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 04:38:21 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 19:38:20 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Wed, 24 Mar 2021 19:38:20 +0800 From: "Zhang, Qi Z" To: "Chen, LingliX" , "Zhang, AlvinX" , "Guo, Jia" , "Xing, Beilei" , "Zhou, JunX W" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask Thread-Index: AQHXDml7mT4K1xpMI0uef4CFEziyOKp6fLCAgBiqRlA= Date: Wed, 24 Mar 2021 11:38:19 +0000 Message-ID: <7a76332b44a14f23b3009ded7d7bd007@intel.com> References: <20210201024046.16244-1-alvinx.zhang@intel.com> <20210301070607.24480-1-alvinx.zhang@intel.com> <41677c8491704608ba25716b5ce21b0d@intel.com> In-Reply-To: <41677c8491704608ba25716b5ce21b0d@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Chen, LingliX > Sent: Tuesday, March 9, 2021 10:57 AM > To: Zhang, AlvinX ; Guo, Jia ; > Xing, Beilei ; Zhang, Qi Z ;= Zhou, > JunX W > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alvin Zhang > > Sent: Monday, March 1, 2021 3:06 PM > > To: Guo, Jia ; Xing, Beilei > > ; Zhang, Qi Z ; Zhou, > > JunX W > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask > > > > The absolute field offsets of IPv4 or IPv6 header are related to > > hardware configuration. The X710 and X722 have different hardware > > configurations, and users can even modify the hardware configuration. > > Therefore, The default values cannot be used when calculating mask offs= et. > > > > The following flows can be created on X722 NIC, but the packet will > > not enter the queue 3: > > flow create 0 ingress pattern eth / ipv4 proto is 255 / end > > actions queue index 3 / end > > pkt =3D Ether()/IP(ttl=3D63, proto=3D255)/Raw('X'*40) > > > > flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end > > actions queue index 3 / end > > pkt =3D Ether()/IP(tos=3D50)/UDP()/Raw('X'*40) > > > > flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end > > actions queue index 3 / end > > pkt =3D Ether()/IPv6(tc=3D12,hlim=3D34,fl=3D0x98765)/UDP()/Raw('X'*40= ) > > > > flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions > > queue index 3 / end > > pkt =3D Ether()/IPv6(tc=3D12,hlim=3D34,fl=3D0x98765)/Raw('X'*40) > > > > This patch read the field offsets from the NIC and return the mask > > register value. > > > > Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow > > director") > > Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang >=20 > all regression cases passed. > Tested-by: Chen Lingli Should be: =20 Lingli Chen Applied to dpdk-next-net-intel. Thanks Qi