From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 678DBA00C5; Thu, 15 Sep 2022 15:43:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D0F14021D; Thu, 15 Sep 2022 15:43:10 +0200 (CEST) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by mails.dpdk.org (Postfix) with ESMTP id 2CB6140156 for ; Thu, 15 Sep 2022 15:43:09 +0200 (CEST) Received: by mail-qt1-f182.google.com with SMTP id g12so13124721qts.1 for ; Thu, 15 Sep 2022 06:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=4ZM/UTTVsC1s6KzmjD/L+KHQr5c5oK/SJ6NLac9NaE0=; b=XmIbx80TT/H/q8CZUGKqLIojaCU0bTf2YThIcgqiD0+Jh4SB1HgIATJWOC1nRSR3xe DY1iT56uMvHy2NmyixfX0CKN/Kqr6aOtuPZohD/y7LPEFUOv8evNjI2tRsODVGAkBaDp /6elMwzvn8MGjjwPwNX40cN8poV2IJJtsrGVs8omSQOUCPOuEtey/14VSCzNjnLiN2/V CtNzS3q+iXDqzTxoe6zpe4rCYD0Go1BgSqgxWOq0vO925rIvp9hav0RXIGx5KK+RKO5/ Bn0T9KKFHPHI0uX6XRbK7ZY5+7Q+AkMOx2qxMRCZ2IYhvce07TpgNbqQ+pwNGqvJfIKU xRdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4ZM/UTTVsC1s6KzmjD/L+KHQr5c5oK/SJ6NLac9NaE0=; b=1Gy8/4PtBIOpE7MIqFzi62sYwCBggmQiaNBkIjsZmPv70P3qwzkHbY4oxlfxa+GjmO 9SvEuB2lpPDOvFNBsIhB4iZS/XWAxzWzu4efoNYLU1dWzi41juAPDB9PKLPl/MoEDfjJ Z9FJgVaShcUGfgtlN4PwkM6dJ0ziFhBu0HYtFeY6Mm6AaCdXgNGa59b19PSaOVDI1+97 uVAPOEWKPTE1OOLkKSe61TpH9LZK5WFiRnp3liYhn7z3/3d+FvEck8XSNlOMTabkAUh3 iHc+bV4nFTQg7VxghVhgY9TGVA0eG4wghRiWaGQhTIfzJB0rt9VVylPCGcLDm9YWIlsU 0HqA== X-Gm-Message-State: ACgBeo1TbILCQIwhRpjNbRYIBx+e24cpS+6tMQHtmzU8hnuqIMvghiXQ qNE5vUv7+NtpA1QyNWi9TZQ= X-Google-Smtp-Source: AA6agR6ERw1GXPICSGbliBp6/LiuTRx13iKEKXvbyrgafxWyUxpUBB86js9chjfDPwqpUOmr3ghG5A== X-Received: by 2002:ac8:580d:0:b0:35c:3fcc:2442 with SMTP id g13-20020ac8580d000000b0035c3fcc2442mr10958839qtg.501.1663249388604; Thu, 15 Sep 2022 06:43:08 -0700 (PDT) Received: from ?IPV6:2600:4040:225b:ea00:6063:8c9b:774a:6cf4? ([2600:4040:225b:ea00:6063:8c9b:774a:6cf4]) by smtp.googlemail.com with ESMTPSA id ck12-20020a05622a230c00b0031eddc83560sm3458738qtb.90.2022.09.15.06.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 06:43:08 -0700 (PDT) Message-ID: <7aa62c59-fa86-1d20-31eb-e55e5fa60ec3@gmail.com> Date: Thu, 15 Sep 2022 09:43:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V2] net/bonding: add link speeds configuration Content-Language: en-US To: Huisong Li , dev@dpdk.org Cc: ferruh.yigit@xilinx.com, andrew.rybchenko@oktetlabs.ru, huangdaode@huawei.com References: <20220805031912.11729-1-lihuisong@huawei.com> <20220915131424.7337-1-lihuisong@huawei.com> From: Chas Williams <3chas3@gmail.com> In-Reply-To: <20220915131424.7337-1-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/22 09:14, Huisong Li wrote: > This patch adds link speeds configuration. > > --- > -v2: resend due to CI compiling failure. > > Signed-off-by: Huisong Li > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 3191158ca7..0c1dbc3ff6 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1717,6 +1717,8 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > > slave_eth_dev->data->dev_conf.rxmode.mtu = > bonded_eth_dev->data->dev_conf.rxmode.mtu; > + slave_eth_dev->data->dev_conf.link_speeds = > + bonded_eth_dev->data->dev_conf.link_speeds; > > slave_eth_dev->data->dev_conf.txmode.offloads |= > bonded_eth_dev->data->dev_conf.txmode.offloads; Where did bonded_eth_dev->data->dev_conf.link_speeds come from? This is rather messy since you might need to worry about intersection of speed_capa from the set of members in the bond group.