From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F458A034C; Mon, 24 Oct 2022 12:48:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72B1340E5A; Mon, 24 Oct 2022 12:48:47 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2066.outbound.protection.outlook.com [40.107.237.66]) by mails.dpdk.org (Postfix) with ESMTP id 6C8AB4069C for ; Mon, 24 Oct 2022 12:48:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZKGvSUUM7xCs2uoHeoJ0/Dij7nINNMaSXZeBw2H4XHRxY8LdY7L1W/MtLKU1mgsTVgwuFmDIJh2U8ixakh2sfvWG8jxcypS8vEYYFkGcUaL+SWEcJmKTJfWafoT9pfam1GH0TbQRR6tEs3yx1ZBJ9oEcSjtjCFrjBiw3Fx+vJ7NKsSVURkC+rm/AHjGndgxNydUHp3dQr7AbHeLgdAXVecOcwgZaMQ3Xu50HI3FrPWLIA4xSRfVOo4hCAk/YkwyngTffQWNRFyXl5uSpSEVE3DuUbhQVKBYhFR7JDGqe2fdI13QTQb6Gg5PTFda9VZiOX9dSbEFEuetO+7xydQY5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YGQQJRXcPp9QcajmWKYDqBW0HC7LsNOPtQPmEud35e8=; b=S9s7X9x+go9MhvwlVioC4VQHS7zlnon14aJKK/am/qPjHqLya/aurow+o41VMe4CZzXkbFwkJjzy+q1PLXS0maxHt4qqmUk79CoQ98E2W+n2WRb9Dfn8sfsZ3xI8tiRCQz7d2tXq6Y4mfTElryZnqiD51cgFJJ9DjCeE2erhkZyOPKRiI+IYzvGRaZMdcrineKIW7zL7aEnxWZkl67LLktBUnjnCVaNCYsHAFFffi6kBglroG59vEqAUqmPnSxpHu602jYWhwFygvEZkKcvTWYFCPKNA6uMQzYoysjX5CCyL6Qoq9LiC1Cfn7OtY0WrwnKRNuLu+B9xw7Ymgs6tg+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YGQQJRXcPp9QcajmWKYDqBW0HC7LsNOPtQPmEud35e8=; b=kFjl7asLfnFIS7CzYJec9JwT8GlZ0/Ey02D2SF49flB1317VeFh85tVyQQ0m4TEkF3jLjyaQ//Huscu+IHjqrsS0N+LYVsCS5Eg3xzl3sa115a8oXr8ewRc38cfyF8lrre6cKq3U4WiyI3FXnMrplCE2DCJi58nqsAf/MWm59JU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DS0PR12MB7631.namprd12.prod.outlook.com (2603:10b6:8:11e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 24 Oct 2022 10:48:43 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Mon, 24 Oct 2022 10:48:43 +0000 Message-ID: <7aacf7de-ac93-c7a2-e4a0-76d6dc005415@amd.com> Date: Mon, 24 Oct 2022 11:48:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v7 6/8] net/gve: add support for dev info get and dev configure Content-Language: en-US To: "Guo, Junfeng" , "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" Cc: "dev@dpdk.org" , "Li, Xiaoyun" , "awogbemila@google.com" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "stephen@networkplumber.org" , "Xia, Chenbo" , "Zhang, Helin" References: <20221020103656.1068036-1-junfeng.guo@intel.com> <20221021091928.2674471-1-junfeng.guo@intel.com> <20221021091928.2674471-7-junfeng.guo@intel.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::20) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DS0PR12MB7631:EE_ X-MS-Office365-Filtering-Correlation-Id: 78586352-1262-4754-8969-08dab5ad518e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rexMfwH/Lc9CfBI9A72lafLl3U1w498N7HsS/ju4B7Jn8Zcu+Cinejx+40+55+Q1we+R1XB4li6kvMCnBWjTvEYAxkiKr3YIz+SWQw+119voBIqP+L+NK1YLfoj9XRLHjd8QExj+qOJGDMnRRvzjP2o2E527/0UFZnwU+havvVt/r9i/KTwjA3MRgHJXv5ZAqVTKnfdjNrim5bsJrC+11zZ+kilEbflS7imPyaN5yvVNauM/RolwrxmuAYeQJEAAhh2db5gDJ9OEKN9RxS3+ASXhqx38a6+mAMd4OXqFQLmy6z9UIsqOk3wObZfF+4mS5YC3yYUD2qgWY5UR26C1u85GS01i1dXcyG1RlxSS5J6+BZsZlzBUPwwnYfB8tXd3yIk2zeNl/qQ//YxPvA0bHgrW8n5LO+WflVPRD77crMT4bk8Vw6dCSlJl3KKsPmvT+H3ujGve5bbNRLNMzKFJsNIyelK5ONT5lFrG6x+JK8Hd5NY7d2Yf7SpYD3AnCfzaTDOG4XPXpsvI+SG1CS2IDbIrX3tHENmBBqFluLNHmh94oIvWm+iRrd2eMwGv98MVJ3T1ceURE+UKWCKNqXWIlNiX87NEl8Qp+7VTsmtIXfo66SDF8j8rwClsLRh0ODLzVyHo2CJSK+vj4GXwblllK/hcatOZpv7YOokrKtUTI2NvQ0thduFvQrHXxq6kI/l7ARw3ZmhxQzQAinv+GLgYwyop/18h+vLmPubm7Hv1BIODb9KgIzdKGjyn0649hUTZwXi7vrZkOeXROphtsyWxxIPO1PrTh0gRjj6ByXQhCpQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(451199015)(6486002)(31686004)(110136005)(8936002)(478600001)(7416002)(44832011)(26005)(5660300002)(4326008)(186003)(8676002)(6506007)(6512007)(2616005)(53546011)(2906002)(41300700001)(66476007)(66556008)(66946007)(36756003)(31696002)(83380400001)(38100700002)(86362001)(316002)(54906003)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXJvR0NlWi8vZEhvZ3RxYVZXOVJjd2UvRTdkNC94Rk1ZY0kzTUVLSUpqN3hI?= =?utf-8?B?NGVkbDNXS25mR1U5eFYwMWxJZDd2L2hEZkNHNzBYcmM2TER4eDYzRFlsK01L?= =?utf-8?B?M3lVMXB6NEpCSmc0dll0TExjeWM1Z2tzR1RNY203YXZOYUtNZjZYcVk1dndM?= =?utf-8?B?U3lmYWZKRi9UaEZ6NVJyR0Z2QVNNVUdQQkc2dUVhakRDZmIyUEFtV2xqNjRr?= =?utf-8?B?QjlZSzN4MlRGbDFSY3I3a2dGcTk5eFNnMWM3RWptTDJKVGF5Q2srQXpQcVlo?= =?utf-8?B?dGE5ZnhxRnVCQ01zUzl6bTlFT1Y3NkR5NTk1a3hpS0gwano2MGJQQjcrcXhB?= =?utf-8?B?VGFhMHFFNzQrWU5va0Q3a3lVbGppMG9aeVgyZVN1ancrZ0lROUJCcVk4RjRw?= =?utf-8?B?Z2E2VGVBTE9qZ3htTTEzcGFJZ0Q3UUdORC83b3NwdC92WkN1cDRFNnZjRVZE?= =?utf-8?B?UmxHZnFNYWR0RjNJa3FyeExVUFlGVEhMcGVGVXdTZG5sVUFFVExsR0J4MHht?= =?utf-8?B?UXluQ2t3R1ROL0VETWNaRUNhSkVFZmI2NGZSVU91emZXMVlTbUZYNk5LYmVH?= =?utf-8?B?c2FwMC82dTVJR0JDVmNBWTNHUUttZFBtcU84d1V3aVVkK0hxKy9zcklEbVYx?= =?utf-8?B?QXFIVVRhZk1TM2xZYlhJV0dwdCt2bVBTZkpOZmE2Qzl5UG5XVERjaTE3T1VG?= =?utf-8?B?QTEzRFBTSTkxSzR6TThsWi82TUcwZlBZWGtPWEQ2Nzk5TXVJWC93ckRPeVdo?= =?utf-8?B?YkFxK3pYSk1Db3VYeHZvcThMRW13Z2JLQkF5RmF6TSt6em1Kb0Jya1B3SktI?= =?utf-8?B?THM2V1pPTjJzSkRqaVlqaE8yRzdBOG9wTE1PeERVelNkNjdCWjFiU2xPaWRU?= =?utf-8?B?cHdLaUdRQjlreUl5U00rNFVGRlVTY0hOdnlZVDh4cmU4bHhmcjVxL1puek0r?= =?utf-8?B?V3V2ZFA0MFlFWVdMZi8raUJVbmVFTlpUVStHR09JMVd1cVJpTXFsR2tOeno0?= =?utf-8?B?bDNxbGM3TGtsK0pSdDYwUllMNlJCclJlS3hlUm1Uekd6dzk4aVBiUmxFZVRQ?= =?utf-8?B?OGRoMitvSkhPWDhhYW5wSk5LUG5sbnVoZHc4c3FyOVFTa1BHUmxYUWZ6UllM?= =?utf-8?B?SWFaWGJaTGJCSHlVSm9TZDZkVDhnUG1aVUFVZ2l6dG1WQSsxYUExSU5CUkJ2?= =?utf-8?B?bnJnTS9XSkhPWURTbHloWEUybHYyaEZjUFF3cUhGcW83WVhUWXB0ajdnMFlB?= =?utf-8?B?U25pODVqUTZHRFB3Q3F5ZEUxVFNGbFc2UmRENVR0SlRZTmkra24wMU01cWlK?= =?utf-8?B?eG5VSkE1aWRid28veUNLWWUwK1pZM1lUTGJPdjN5cjFZbWoxRDNMUWNrRnJF?= =?utf-8?B?QlQrdGJiM1N5ZXdkeXlxSk81MVY3N0lJUFBkUUM3cEpZVWpYR2FFSTNMeFkv?= =?utf-8?B?UmxtSW1SaXJUcExmUklCTENvbmJVeWZvWktqSlJsNllkWUlaaWNNbVA4VmdS?= =?utf-8?B?eXVqaEZNcSs0aHZua0xQWGMreE11enRMQWgzTlZSOXZRWlZwdmNCVUYycW1Q?= =?utf-8?B?SjlsNE1mb2VKb2J2OFhLUmRVQmVHYi9hMnpzK1B1QzVBd3pFZ3lPWDdTNU1w?= =?utf-8?B?akhoSlk5NUhPc202K1g2MENweUZRMC9FOW9weXlxWVBweWxGT05KMm95eVo4?= =?utf-8?B?aFRPbnprckU2NjBUdzlLWnlqMS9TYTVwdnFQM0l6ZXRoV0p3UHBVM1FEVEcx?= =?utf-8?B?d0dDZzdaTWxPY24zc0g3WUZXbHY3dkFUdjdwYTcveTNyYjlQR0RkWG5XM2U3?= =?utf-8?B?TWlIUGhYTFBwU1phSXlCWnBuc3pQNmx2SGlQNU1LWEdxL3RzUkpnMmVuZUFG?= =?utf-8?B?NVFFQ3ZQbnlPSnNsVHA0M2QzZEs4R2dnU0JEU1JJOUFCRFNUMlIvbFJZQ2Rw?= =?utf-8?B?RVhFUHJJaUdJS2t0ZVNRZXAwVytBMXE2SFNwdGp1UytTSVNLaG5pZC9NUGla?= =?utf-8?B?c3Q0TUhEUWNvcmNNV3BFZW05SlUweEZKVUNKdUFrbjY0SkdPMzltNSthem0v?= =?utf-8?B?Ny9iWUpNWmpPRDBwNVhjelYrcnhVVW1sR2k5RktZM1VJelEzOE42RWtHUVF3?= =?utf-8?Q?hUZxwVrGmceQDZai5iXfWUoSI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78586352-1262-4754-8969-08dab5ad518e X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:48:43.0970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SiNVzgx+5+MRPD4v26JloW4QCnOiLbro2TzvKRxr5nD/x2Nrcx6AyVPcA5/5cOli X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7631 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/24/2022 6:04 AM, Guo, Junfeng wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, October 21, 2022 17:51 >> To: Guo, Junfeng ; Zhang, Qi Z >> ; Wu, Jingjing ; >> ferruh.yigit@xilinx.com; Xing, Beilei >> Cc: dev@dpdk.org; Li, Xiaoyun ; >> awogbemila@google.com; Richardson, Bruce >> ; hemant.agrawal@nxp.com; >> stephen@networkplumber.org; Xia, Chenbo ; >> Zhang, Helin >> Subject: Re: [PATCH v7 6/8] net/gve: add support for dev info get and dev >> configure >> >> On 10/21/2022 10:19 AM, Junfeng Guo wrote: >> >>> >>> Add dev_ops dev_infos_get. >>> Complete dev_configure with RX offloads force enabling. >>> >>> Signed-off-by: Xiaoyun Li >>> Signed-off-by: Junfeng Guo >> >> <...> >> >>> --- a/doc/guides/nics/gve.rst >>> +++ b/doc/guides/nics/gve.rst >>> @@ -62,6 +62,7 @@ In this release, the GVE PMD provides the basic >> functionality of packet >>> reception and transmission. >>> Supported features of the GVE PMD are: >>> >>> +- Receiver Side Scaling (RSS) >> >> [copy/paste from previous version] >> >> I am not sure if driver can claim this, I can see a RSS hash is provided >> but is it possible to update which hash function to use or update key or >> RETA table to configure which queue packets goes? >> >> Right now what is RSS calculated on? >> >> Perpaps RSS support can be documented as limited? >> >> And not sure if this update belongs this patch, it should be to the one >> that has the datapath. > > Looks that the RSS is enabled by default, and there is no RSS init API. > So I just added back the force-enabled RSS offloading code with the > corresponding commit message. So the feature list remains unchaged. There is difference between RSS and RSS hash, what force enabled is "RSS hash" where device calculated hash value is shared with application in case application wants to reuse this value for some reasons. But for RSS support, there is a set of configuration required by DPDK seems missing, as mentioned above, config RSS hash function (based on which part of the packet is the hash calculated), or RETA table update so app can select which packets goes to which queue, etc... Is it at least possible to document what existing configuration is? Because of missing configuration support, I don't think it is correct to document RSS as supported, can you please update it to say something like limited support exist with default config.