From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7C0CA32A2 for ; Fri, 25 Oct 2019 11:19:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 906E61C2A1; Fri, 25 Oct 2019 11:19:35 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 099F61C2A1 for ; Fri, 25 Oct 2019 11:19:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571995171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gwJ6l5k5avoEAkoNbBnH+U1yprU7kHPvb+McYwwKpNM=; b=QUk/V2lj0CnnKaG26iM7vSglNJw4NRRDm6WQ0cYVgY1yK39YdJOCpfljMftSjpvUF8HpGK lU8jcWjii54fNizWbdYD06Bh/vZiwilJ2ChdQPwGHu/YWzyNHReGcyJyFd48sy4VUhw8Go tFNmz718d7adtcmqyXdX9NZvuwLL5Hs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-DnzMdaSlPc2dsdykpXJszw-1; Fri, 25 Oct 2019 05:19:28 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10C7980183D; Fri, 25 Oct 2019 09:19:27 +0000 (UTC) Received: from [10.36.118.52] (unknown [10.36.118.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8540760BE0; Fri, 25 Oct 2019 09:19:15 +0000 (UTC) To: Thomas Monjalon , david.marchand@redhat.com Cc: dev@dpdk.org, anaotoly.burakov@intel.com, stephen@networkplumber.org References: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-9-git-send-email-david.marchand@redhat.com> <4428801.DX9tkajkud@xps> From: Kevin Traynor Message-ID: <7ac75b52-8d44-f85f-757a-acb73035d887@redhat.com> Date: Fri, 25 Oct 2019 10:19:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <4428801.DX9tkajkud@xps> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: DnzMdaSlPc2dsdykpXJszw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 08/12] log: hide internal log structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24/10/2019 17:30, Thomas Monjalon wrote: > 23/10/2019 20:54, David Marchand: >> No need to expose rte_logs, hide it and remove it from the current ABI. >> >> Signed-off-by: David Marchand >> Acked-by: Stephen Hemminger > [...] >> --- a/lib/librte_eal/common/include/rte_log.h >> +++ b/lib/librte_eal/common/include/rte_log.h >> -struct rte_log_dynamic_type; >> - >> -/** The rte_log structure. */ >> -struct rte_logs { >> -=09uint32_t type; /**< Bitfield with enabled logs. */ >> -=09uint32_t level; /**< Log level. */ >> -=09FILE *file; /**< Output file set by rte_openlog_stream, or NULL.= */ >> -=09size_t dynamic_types_len; >> -=09struct rte_log_dynamic_type *dynamic_types; >> -}; >=20 > I like this kind of change, but the FILE stream is available only through > the new experimental function. It is against the famous Mr Traynor rule: > we cannot deprecate or remove an old stable symbol if the replacement is = experimental. >=20 >=20 For the change Acked-by: Kevin Traynor ++ for the rule (although s/we cannot/Thou shall not/ sounds more biblical) As for accessor function being experimental, it is so simple I don't see any issue with promoting it now. OTOH, if no one is planning to change the struct anytime soon, it's probably fine to keep it public and promote the fn. later.