From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0ED3432F3; Fri, 10 Nov 2023 18:23:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C298240695; Fri, 10 Nov 2023 18:23:19 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2042.outbound.protection.outlook.com [40.107.101.42]) by mails.dpdk.org (Postfix) with ESMTP id 8BDBE402EA for ; Fri, 10 Nov 2023 18:23:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RbhAUtPgIyaQZnVIpJ2q2dqhkuLcawK4D2xTBDBKQtApyYDhmW9xIs+zUeq1qxsrUBZE/dkqO+APxI3KkfrgKzznT/9mlDkbOYkbnrg/I2M1Zhi+Tjkc6zUVWtw82eHizmeQNA+0CKe2A9YCd5wmo6JRUlcE+6E3ZQAuuVfxd1VAXponJJOF8gNSLcM1GITaTel9deQun2U+KlIksyyYWQBVf8sdPR8+dOpWEysDd+mKmyhH6n6DaQs94Wn27rkGIuNg/DDZVsmHq8oFuPu7VXnrzGGQvLr8QXhD435g2jtLLQWHuVpO/JmvWd+rbsa54snxeUr8VLffv5bFT8f7ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CMWDRND+5lugCI34C15Elck1hreTzSgacVI1hPUHM4s=; b=f96bPluYiFqzFfNlcV2Uh+jYzgcQ/XV/Z4PMDdIiotGVFj54Xvq8xS6W/w+nZFHuowEBbbK3iBpHBMrrXPM6cpwW8B63eZBQRBFGK8SUxRaiYB9h5vlBpkhuJocTsvI6f3+oZBfdkxTG2wdPfTJh0Q8hI6Jb4TFq0HsIvUu10yMo2AcB7Kjm4xzYbjghvY/oJE5PRE54oQNd59VGz9H54zFWFqpxXXZ0N2jDnFjgwQ5uBFDTFwUZ7VOBlHuZAg3ePHSVCHvXfDrrFaRJ/abYwYIj1qZcJt4DYqVPoG6SE9I0RUe3FOAER2vLfaycGvVVHT/PgjXOQLfi3B4WtlX6aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CMWDRND+5lugCI34C15Elck1hreTzSgacVI1hPUHM4s=; b=L2zAeq+7Ychb9zyfOLbJBDdoJtSnYd+6RHUDf+CmRk1HHAT2Zj83amimglL5ldz21zk2UW/qALOjz3OXLlFhLrmu+0cobKPmfc+852ndgID/eAOeRK1P7srGLngmECCd/wQs98+BXkd+K5bzTzwEk1vg/dog8ZfoL5Oa1ASmeb0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB7749.namprd12.prod.outlook.com (2603:10b6:208:432::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Fri, 10 Nov 2023 17:23:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Fri, 10 Nov 2023 17:23:14 +0000 Message-ID: <7accc638-f55b-4da2-bdf8-5b55fca9e4e3@amd.com> Date: Fri, 10 Nov 2023 17:22:52 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: add extension keyword to statement expression macro Content-Language: en-US To: Tyler Retzlaff , dev@dpdk.org Cc: Andrew Rybchenko , Cristian Dumitrescu , Thomas Monjalon References: <1699560818-7453-1-git-send-email-roretzla@linux.microsoft.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <1699560818-7453-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB7749:EE_ X-MS-Office365-Filtering-Correlation-Id: 56caa34c-b10e-4eda-4297-08dbe211b887 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jFChgsWDcBTeGAwuN0kDAG7Sbohf59ZpPqga3BLZYXUGQYkmfuwbabof65ZT5eho3eT2uA2iwx9H9pmsky5w3OsXAX/o1lfKtBS4Iqh2JipeqWcd1rXdiuDHMrj21DEtaqM1+MI5Y1i1Wuhz10suXOoIA7VezfuQcn1Iowscf80wSHiLhjqYFHsHI1BiMOJSt7fkKFKUfnIrOoMnlu92pn5Cph1dQ4luAp/Ca36/V4Wfa8uzesgkoUQjzyt1/RjYJefiAwvEjxKszgAijkurLryhkBK5WTgZ6cbRxBGZkYjlQd/sjVrC9G8qM3AQL3UQAYPgUL4v0LNicGPnAk77dq1JHV3T9W56v2uLv89eCUQyxfcHikpZflApLQ0VfKIN7WdJXwrCZM4GmQtVizf7VGJgcgjAjzm8/a/8/WQYLVfyRdCiW3AHzc5hEmovOw/V1ji1/fmPUpP2pTi21G/6DhlqC3PoNn0iSB80b+IhHwB5V7l/0jin6a4P8wwMikSCxXzXXq4OoLaCJgSU8S6TTEY81/XPTFXqph7JhAyl+JAV160+7tW/bRMsV9kRmVr2nDPmQ5Dx2PdqrFu1wjp44dOEzfNVCDv3ykIriroXzwu5KxONKnU6/ISC9k3EE4rYXp6WnZpAb79akhX6hIrKzA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(346002)(136003)(366004)(396003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(6506007)(44832011)(53546011)(478600001)(6666004)(8676002)(6486002)(8936002)(4326008)(5660300002)(4744005)(26005)(6512007)(316002)(66476007)(66556008)(54906003)(66946007)(2616005)(31686004)(2906002)(41300700001)(31696002)(36756003)(86362001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkNxV1lDSjdYMElBY3RCY3liYmlrdVFTNzVXaWRuZTVqc3VNSGt6Rko0M1Bt?= =?utf-8?B?NUpWdk5aU1B3QzhKMTYrdnpoQTFJVnhTSjZRSGJSSjBOdzlZSmZsaVlvL3pa?= =?utf-8?B?VGMyYWp4WlY3LzJpd0JVZS96ZGdxcC85NVhRV0lPeTNwbUdydjVVQjhSN1Nr?= =?utf-8?B?d1VmRWp4eVl1cHZFaWhlRzl4OVNmV21HYjRJQXlObVRkVzNMd29Yb2FCQ205?= =?utf-8?B?V0Y4L1d2cm9KbE1wL3NnSzhVNXZRMmFvK2FmbXFHUllldEszMGV5YUkzSEoy?= =?utf-8?B?ZXdQcjdMU0tuamtyOUEvcHYzenpIZFFuM09uZzlkY2d0djZUbEZBYmVWTW5J?= =?utf-8?B?TTZlUDhobnJ0a1lHbnR6U3lGQk1IRDFwYlhuRm8zSk1sZ0xqc1JKNVNBam9y?= =?utf-8?B?b2xBUWt2a0J5dHBsVWlnSllPSmFDZWpiRlZBNXU1V2N2MkJWOXZLL25rRjdD?= =?utf-8?B?d2pkU3d2UC9heVlQSW0xalVqRC96ZWRnRkZPakVsQTRGZHRmZmVtTjFXb2VW?= =?utf-8?B?TW0vUkdOVFU5NGs2aE9vZW1kODhDNks4RWlTVnNzd1JDQURhV0ptYjJXRldF?= =?utf-8?B?aE5UWTJqQTZ0VDhhVXQvNnZwdDMrRE5mWTlwVXpBa2xxdytReEZxdkwyQThZ?= =?utf-8?B?RUQvNWU5Nkc5WmdRTW9ZQkNFckpCbERzQkp0UTBCV1VsQTZORTlneE9Ecll3?= =?utf-8?B?YVJDTFhEbFZzbTVkMkcxVks2alNRaDFiS0FNMnlaRjV5b2FxN3JpWWhoL0Zr?= =?utf-8?B?VDNyQVJLRVVyRGJKanVJRHBIeTk2VjBxZnNnSUt1VkwraTYxMFZMb1BXNmJ2?= =?utf-8?B?OWdpMnZkSEpTMW5wRG8yaFA1VWd4NVQwQnlFdHFPZE5XSjVKVE1sNWVFKzAy?= =?utf-8?B?a3pzV0FYaDRVNzhpbGxKWEptNEo2NTFNcEhXamlwWDlYaFJWRnFHS0N5THRU?= =?utf-8?B?WTRsOTJFb3dVazNGT1JLcmtiTlNnZDVsWldpODhSWGhVc1g1cGtUZnlCZVlh?= =?utf-8?B?ZFhHeUwrQXlxY3dZazE1MGU5YjdLT3N3YXhnR1prVWF0V1g5c0JZYnp4WWFh?= =?utf-8?B?TUpKREkxZ1FSeUs1TXlMQUgzRkVBRFArV3pENFZ3dW1iTnhJNGdqSzhycis0?= =?utf-8?B?YUg3Zit0YXJXdFcrMVEvaDhYZWwvRG9DZkFoYUNDZ1VvODFnbFYvMUZXL1VQ?= =?utf-8?B?bVloSTZxTnhLSHhqcnNlWjRUd0t4OVlkTkRsR2hBWG9nQktxUUhEU3JHSm9a?= =?utf-8?B?SUViZk1XQlRLdHNqMHpDRVlXdWsxcGdRS3FrQVNUVVhBaWllOTVEU0l3UGpx?= =?utf-8?B?eThBTGd2aWpHRE9YUmxsUE1oaFU1MnNuYWJWQk13emlFWXlHRlUycERPVlI0?= =?utf-8?B?akRVQVZrV3pFeHhpOVFMNk1lNXJ1Wm5SQUdkUU54M2J3TmRQUlE5WW5aVzhV?= =?utf-8?B?bGhtWWNKNmZsbE9ib0JyeWkwaWJlemZyQXN6dWRNZHNueUpRZGtFSnRnblBr?= =?utf-8?B?K0Njc2tXZGM5Q2drd25Dc1c0bld1MnJCYzhUM0VLRG11c2tyQU9NcWVNOUkr?= =?utf-8?B?UVlmd25FdlVCa3hYdjZXd0RjN3l3eHlERHFqRGlncEhJOUxIdWdIVHFzdk1O?= =?utf-8?B?RjZVV280TDdoS0Z4ZVp3N08xV1IyaHdsQlFVNUlmV2N1bDdiUmY5Z1QrZmlX?= =?utf-8?B?VE00Unl2WW9vSlRzM210UXVFTGEzWkZVS3R6YVRMWUdQRnoxc2JHWEdPQWJt?= =?utf-8?B?NmJvQW0vUUpzM1IxeG1odU1ZdlpEcjJyUVh0ZWlnaVNWaGF5SHRpRUJnbXAz?= =?utf-8?B?RG9UblFlV1pSVFk1cXJ5RitZRW1VZnNZaG5pZXZ2Vm5KL0JFVmJFL1lERzhh?= =?utf-8?B?Z2FmVU1PTlBlOFdsQkFUZ0kvVzJ2UzFXRDdyY29EZTFSNWZmaTRMeVhTdlNQ?= =?utf-8?B?SjY5dkRmcXcxQVhkcndKMFhhdGkyRHRIVk43UW5pR0VvZ1RQYnlDMGtUbGNK?= =?utf-8?B?MnRFblJITld1NEVGbVhZR0JJSFk3bXQwelhha0dXRWdFZ2lmTXZ1WXNYQTNq?= =?utf-8?B?YWJUbmdQRERaeFpQZDVaSzFiYzNNQ3BhY3pNTzBqZDVmSVN3aTc1NHRHbTUv?= =?utf-8?Q?6W3U=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56caa34c-b10e-4eda-4297-08dbe211b887 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2023 17:23:14.5840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k+G0dZbh5Hrgj9hp3H8wfbRewb3kj7Yon7IoU02BMFNRZ9GcuZkYd65d8IrUZCS0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7749 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > add missing __extension__ keyword to macros using gcc statement > expression extension. > > Signed-off-by: Tyler Retzlaff > Acked-by: Ferruh Yigit It seems there are a few more usage not marked in lib folder [1], and more including drivers. Is this compiler extension causing any problem for the Windows build or MSVC toolchain? [1] $ grep -r '({' lib/ | grep -v __extension__ lib/port/rte_port_source_sink.c:({ lib/port/rte_port_source_sink.c:({ lib/pipeline/rte_swx_pipeline_internal.h:({ lib/pipeline/rte_pipeline.c: ({ (p)->n_pkts_ah_drop = lib/pipeline/rte_pipeline.c: ({ (counter) += (p)->n_pkts_ah_drop; lib/pipeline/rte_pipeline.c: ({ (p)->pkts_drop_mask = lib/pipeline/rte_pipeline.c:({ lib/ethdev/rte_mtr.c:({ lib/ethdev/rte_mtr.c:({ lib/ethdev/rte_tm.c:({