From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95F3EA0351; Mon, 17 Aug 2020 14:43:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E2EEF1C0BC; Mon, 17 Aug 2020 14:43:51 +0200 (CEST) Received: from mail.chinasoftinc.com (unknown [114.113.233.8]) by dpdk.org (Postfix) with ESMTP id DB3531C020 for ; Mon, 17 Aug 2020 14:43:48 +0200 (CEST) Received: from [192.168.1.199] (139.159.243.11) by INCCAS001.ito.icss (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Mon, 17 Aug 2020 20:43:44 +0800 To: Ruifeng Wang CC: "Wei Hu (Xavier)" , Honnappa Nagarahalli , "dev@dpdk.org" , nd References: <1594987709-11768-1-git-send-email-xavier.huwei@huawei.com> From: "Wei Hu (Xavier)" Message-ID: <7aec6b88-f413-a6f5-5829-b84d28a324e7@chinasoftinc.com> Date: Mon, 17 Aug 2020 20:43:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [139.159.243.11] Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: support SVE flag on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ruifeng Wang On 2020/7/22 14:35, Ruifeng Wang wrote: > Hi Xavier, > >> -----Original Message----- >> From: Wei Hu (Xavier) >> Sent: Saturday, July 18, 2020 10:18 AM >> To: Honnappa Nagarahalli ; >> dev@dpdk.org >> Cc: nd ; Ruifeng Wang ; Wei Hu >> (Xavier) >> Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: support SVE flag on ARM64 >> >> Hi, Honnappa Nagarahalli >> >> >> On 2020/7/18 7:04, Honnappa Nagarahalli wrote: >>> Hi, >>> Thanks for the patch. Has this been tested on any platform (simulator, >> emulator etc)? Do you plan to add more code using SVE? >> We have tested it on FPGA board and will upstream some code using SVE >> later. > For completeness, cpuflags unit test also needs an update to check for the newly added SVE flag. > BTW, is there a plan to add SVE2 flag as well? I will add more flags to rte_cpu_feature_table in V2, sunch as SVE2, etc. Thanks, Xavier > Thanks. > Ruifeng >> Thanks, Xavier >>> Thank you, >>> Honnappa >>> >>>> -----Original Message----- >>>> From: dev On Behalf Of Wei Hu (Xavier) >>>> Sent: Friday, July 17, 2020 7:08 AM >>>> To: dev@dpdk.org >>>> Cc: xavier.huwei@huawei.com >>>> Subject: [dpdk-dev] [PATCH] lib/librte_eal: support SVE flag on ARM64 >>>> >>>> From: Chengwen Feng >>>> >>>> SVE is the next-generation SIMD extension of the ARMv8-A AArch64 >>>> instruction set. >>>> The related marco definition can be found in linux kernel: >>>> arch/arm64/include/uapi/asm/hwcap.h >>>> >>>> This patch supports getting cpu SVE feature on ARM64 platform. >>>> >>>> Signed-off-by: Chengwen Feng >>>> Signed-off-by: Wei Hu (Xavier) >>>> --- >>>> lib/librte_eal/arm/include/rte_cpuflags_64.h | 1 + >>>> lib/librte_eal/arm/rte_cpuflags.c | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/lib/librte_eal/arm/include/rte_cpuflags_64.h >>>> b/lib/librte_eal/arm/include/rte_cpuflags_64.h >>>> index 95cc014..069844d 100644 >>>> --- a/lib/librte_eal/arm/include/rte_cpuflags_64.h >>>> +++ b/lib/librte_eal/arm/include/rte_cpuflags_64.h >>>> @@ -22,6 +22,7 @@ enum rte_cpu_flag_t { >>>> RTE_CPUFLAG_SHA2, >>>> RTE_CPUFLAG_CRC32, >>>> RTE_CPUFLAG_ATOMICS, >>>> + RTE_CPUFLAG_SVE, >>>> RTE_CPUFLAG_AARCH64, >>>> /* The last item */ >>>> RTE_CPUFLAG_NUMFLAGS,/**< This should always be the last! */ >> diff >>>> --git a/lib/librte_eal/arm/rte_cpuflags.c >>>> b/lib/librte_eal/arm/rte_cpuflags.c >>>> index caf3dc8..b1e220b 100644 >>>> --- a/lib/librte_eal/arm/rte_cpuflags.c >>>> +++ b/lib/librte_eal/arm/rte_cpuflags.c >>>> @@ -95,6 +95,7 @@ const struct feature_entry rte_cpu_feature_table[] >> = { >>>> FEAT_DEF(SHA2, REG_HWCAP, 6) >>>> FEAT_DEF(CRC32, REG_HWCAP, 7) >>>> FEAT_DEF(ATOMICS, REG_HWCAP, 8) >>>> + FEAT_DEF(SVE, REG_HWCAP, 22) >>>> FEAT_DEF(AARCH64, REG_PLATFORM, 1) >>>> }; >>>> #endif /* RTE_ARCH */ >>>> -- >>>> 2.7.4