DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Lijun Ou <oulijun@huawei.com>, thomas@monjalon.net
Cc: dev@dpdk.org, linuxarm@openeuler.org,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features
Date: Thu, 28 Jan 2021 00:20:19 +0000
Message-ID: <7afa888c-7087-53a7-0328-96ca890b04cc@intel.com> (raw)
In-Reply-To: <1611150232-609-2-git-send-email-oulijun@huawei.com>

On 1/20/2021 1:43 PM, Lijun Ou wrote:
> From: "Min Hu (Connor)" <humin29@huawei.com>
> 
> Document FEC in NIC features, add information about FEC and add
> implementation related support.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>   doc/guides/nics/features.rst         | 14 ++++++++++++++
>   doc/guides/nics/features/default.ini |  1 +
>   2 files changed, 15 insertions(+)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index cf82e9d..ded5c16 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information.
>   * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
>   * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``.
>   
> +.. _nic_features_fec:
> +
> +FEC
> +---
> +
> +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode.
> +It adds error correction information to data packets at the transmit end, and uses the error correction
> +information to correct the bit errors generated during data packet transmission at the receive end. This
> +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required.
> +
> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``.
> +* **[provides]   rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
> +* **[related]    API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
> +

Feature doc looks good, thanks for adding this.

Can you add another patch in this series to update .ini files for hns3 & cxgbe 
to advertise FEC feature?

>   .. _nic_features_other:
>   
>   Other dev ops not represented by a Feature
> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
> index ee786d3..562a681 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -65,6 +65,7 @@ Module EEPROM dump   =
>   Registers dump       =
>   LED                  =
>   Multiprocess aware   =
> +FEC                  =
>   BSD nic_uio          =
>   Linux UIO            =
>   Linux VFIO           =
> 

"Linux UIO" etc renamed in this release, can you rebase on top of latest repo 
please?

  reply	other threads:[~2021-01-28  0:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 13:43 [dpdk-dev] [PATCH 0/3] update doc for hns3 Lijun Ou
2021-01-20 13:43 ` [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features Lijun Ou
2021-01-28  0:20   ` Ferruh Yigit [this message]
2021-01-28  0:21     ` Ferruh Yigit
2021-01-28  1:55     ` oulijun
2021-01-28  9:14       ` Thomas Monjalon
2021-01-20 13:43 ` [dpdk-dev] [PATCH 2/3] doc: update release notes for hns3 Lijun Ou
2021-01-28  0:25   ` Ferruh Yigit
2021-01-20 13:43 ` [dpdk-dev] [PATCH 3/3] doc: fix hns3 rst Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 0/5] update doc for hns3 Lijun Ou
2021-01-28 12:43   ` [dpdk-dev] [PATCH v2 1/5] doc: add FEC in NIC features Lijun Ou
2021-01-28 12:43   ` [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini Lijun Ou
2021-01-28 14:12     ` Thomas Monjalon
2021-01-29  1:13       ` oulijun
2021-01-29  8:46         ` Ferruh Yigit
2021-01-29  8:57           ` Thomas Monjalon
2021-01-29  9:10           ` oulijun
2021-01-28 12:43   ` [dpdk-dev] [PATCH v2 3/5] net/cxgbe: add FEC feature for cxgbe.ini Lijun Ou
2021-01-28 12:43   ` [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3 Lijun Ou
2021-01-28 14:46     ` Ferruh Yigit
2021-01-29  1:28       ` oulijun
2021-01-29  8:48         ` Ferruh Yigit
2021-01-28 12:43   ` [dpdk-dev] [PATCH v2 5/5] doc: fix hns3 rst Lijun Ou
2021-01-29  9:22   ` [dpdk-dev] [PATCH v3 0/3] update doc for hns3 Lijun Ou
2021-01-29  9:22     ` [dpdk-dev] [PATCH v3 1/3] doc: add FEC in NIC features Lijun Ou
2021-01-29  9:22     ` [dpdk-dev] [PATCH v3 2/3] doc: update release notes for hns3 Lijun Ou
2021-01-29  9:22     ` [dpdk-dev] [PATCH v3 3/3] doc: fix hns3 rst Lijun Ou
2021-01-29 11:57     ` [dpdk-dev] [PATCH v3 0/3] update doc for hns3 Ferruh Yigit
2021-02-03  9:43       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7afa888c-7087-53a7-0328-96ca890b04cc@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=linuxarm@openeuler.org \
    --cc=oulijun@huawei.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git