From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40FB7A09E4; Thu, 28 Jan 2021 01:20:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 071D0141080; Thu, 28 Jan 2021 01:20:28 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C1775141079 for <dev@dpdk.org>; Thu, 28 Jan 2021 01:20:26 +0100 (CET) IronPort-SDR: BTS2AfoaKcb4vMr9I4wevObUFM8untrIMnUo44WcbAtowF8MMp/hWAW+Js5l7dueq4xQIFs0Qm jAqFPreExF5w== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="180301001" X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="180301001" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 16:20:25 -0800 IronPort-SDR: BaLGvMN2yU4G/KUEuWqtGxgnxKvVMQcjcFCXXIhDCgoYu/2vDmaffZdRapPs45EcjGVZfiSrED x0+UBzgX/xNg== X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="388522284" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.198.76]) ([10.213.198.76]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 16:20:23 -0800 To: Lijun Ou <oulijun@huawei.com>, thomas@monjalon.net Cc: dev@dpdk.org, linuxarm@openeuler.org, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> References: <1611150232-609-1-git-send-email-oulijun@huawei.com> <1611150232-609-2-git-send-email-oulijun@huawei.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <7afa888c-7087-53a7-0328-96ca890b04cc@intel.com> Date: Thu, 28 Jan 2021 00:20:19 +0000 MIME-Version: 1.0 In-Reply-To: <1611150232-609-2-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 1/20/2021 1:43 PM, Lijun Ou wrote: > From: "Min Hu (Connor)" <humin29@huawei.com> > > Document FEC in NIC features, add information about FEC and add > implementation related support. > > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > Signed-off-by: Lijun Ou <oulijun@huawei.com> > --- > doc/guides/nics/features.rst | 14 ++++++++++++++ > doc/guides/nics/features/default.ini | 1 + > 2 files changed, 15 insertions(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index cf82e9d..ded5c16 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -926,6 +926,20 @@ Supports to get Rx/Tx packet burst mode information. > * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. > * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. > > +.. _nic_features_fec: > + > +FEC > +--- > + > +Supports Forward error correction. Forward error correction (FEC) is a bit error correction mode. > +It adds error correction information to data packets at the transmit end, and uses the error correction > +information to correct the bit errors generated during data packet transmission at the receive end. This > +improves signal quality but also brings a delay to signals. This function can be enabled or disabled as required. > + > +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``, ``fec_set``. > +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``, ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``. > +* **[related] API**: ``rte_eth_fec_get_capability()``, ``rte_eth_fec_get()``, ``rte_eth_fec_set()``. > + Feature doc looks good, thanks for adding this. Can you add another patch in this series to update .ini files for hns3 & cxgbe to advertise FEC feature? > .. _nic_features_other: > > Other dev ops not represented by a Feature > diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini > index ee786d3..562a681 100644 > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -65,6 +65,7 @@ Module EEPROM dump = > Registers dump = > LED = > Multiprocess aware = > +FEC = > BSD nic_uio = > Linux UIO = > Linux VFIO = > "Linux UIO" etc renamed in this release, can you rebase on top of latest repo please?