From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 019324CA1; Tue, 18 Sep 2018 15:51:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 06:51:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,389,1531810800"; d="scan'208";a="258256137" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga005.jf.intel.com with ESMTP; 18 Sep 2018 06:51:27 -0700 To: Bruce Richardson , Jingjing Wu , Wenzhuo Lu Cc: dev@dpdk.org, bluca@debian.org, Qi Zhang , stable@dpdk.org References: <20180913144405.72772-1-bruce.richardson@intel.com> <20180918131726.60303-1-bruce.richardson@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <7b1032a7-78e4-019e-ccba-3e1e5488bc56@intel.com> Date: Tue, 18 Sep 2018 14:51:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180918131726.60303-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/avf: fix unused variables and label X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 13:51:45 -0000 On 9/18/2018 2:17 PM, Bruce Richardson wrote: > Compiling with all warnings turned on causes errors about unused variables > and an unused label. Remove these to allow building without having to > disable those warnings. > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting") > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")> > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi <...> > @@ -1268,7 +1266,6 @@ static inline uint16_t > rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) > { > struct avf_rx_queue *rxq = (struct avf_rx_queue *)rx_queue; > - struct rte_eth_dev *dev; Fixes: 1060591eada5 ("net/avf: enable bulk allocate Rx") > uint16_t nb_rx = 0; > > if (!nb_pkts) > @@ -1584,10 +1581,6 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > if (nb_ctx) { > /* Setup TX context descriptor if required */ > - volatile struct avf_tx_context_desc *ctx_txd = > - (volatile struct avf_tx_context_desc *) > - &txr[tx_id]; ctx_txd seems used in below macro controlled by DEBUG_DUMP_DESC define AVF_DUMP_TX_DESC(txq, ctx_txd, tx_id);