From: Sinan Kaya <okaya@kernel.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH RESEND v2 02/11] net/tap: check if name is null
Date: Thu, 19 Jan 2023 00:21:26 -0500 [thread overview]
Message-ID: <7b2aa25f9b4513f61004affe0d4aa9d6c3e15386.camel@kernel.org> (raw)
In-Reply-To: <cfef880d-dd06-395c-f6bc-8c554c83008f@amd.com>
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
On Wed, 2023-01-18 at 10:57 +0000, Ferruh Yigit wrote:
> I assume this is highlighted by a tool but in practice
>
> 'rte_vdev_device_name()' should not return NULL, and there are many
>
> other location this check is missing.
That's correct. Warning was found by codeql static analysis tool. When
I search the codebase,
I do see a mixture of null checks and no checks for this function. We
can ignore this patch, if you
feel strongly against it.
[-- Attachment #2: Type: text/html, Size: 817 bytes --]
next prev parent reply other threads:[~2023-01-19 5:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 15:30 [PATCH RESEND v2 00/11] codeql fixes for various subsystems okaya
2022-11-22 15:30 ` [PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get okaya
2023-01-18 8:42 ` Thomas Monjalon
2023-01-19 5:22 ` Sinan Kaya
2023-01-19 14:20 ` Ferruh Yigit
2022-11-22 15:30 ` [PATCH RESEND v2 02/11] net/tap: check if name is null okaya
2023-01-18 10:57 ` Ferruh Yigit
2023-01-19 5:21 ` Sinan Kaya [this message]
2022-11-22 15:30 ` [PATCH RESEND v2 03/11] memzone: check result of rte_fbarray_get okaya
2022-11-22 15:30 ` [PATCH RESEND v2 04/11] memzone: check result of malloc_elem_from_data okaya
2022-11-22 15:30 ` [PATCH RESEND v2 05/11] malloc: malloc_elem_join_adjacent_free can return null okaya
2022-11-22 15:30 ` [PATCH RESEND v2 06/11] malloc: check result of rte_mem_virt2memseg_list okaya
2022-11-22 15:30 ` [PATCH RESEND v2 07/11] malloc: check result of rte_fbarray_get okaya
2022-11-22 15:30 ` [PATCH RESEND v2 08/11] malloc: check result of rte_mem_virt2memseg okaya
2022-11-22 15:30 ` [PATCH RESEND v2 09/11] malloc: check result of malloc_elem_free okaya
2022-11-22 15:30 ` [PATCH RESEND v2 10/11] malloc: check result of elem_start_pt okaya
2022-11-22 15:30 ` [PATCH RESEND v2 11/11] bus/vdev: check result of rte_vdev_device_name okaya
2022-12-13 16:43 ` [PATCH RESEND v2 00/11] codeql fixes for various subsystems Sinan Kaya
2022-12-13 16:59 ` Dmitry Kozlyuk
2022-12-13 17:02 ` Sinan Kaya
2022-12-16 15:26 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b2aa25f9b4513f61004affe0d4aa9d6c3e15386.camel@kernel.org \
--to=okaya@kernel.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).