From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C25FA0A0A; Fri, 26 Mar 2021 16:16:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E50FD140F0F; Fri, 26 Mar 2021 16:16:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9174740685 for ; Fri, 26 Mar 2021 16:16:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616771769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=61W+NX+4dftPahMco23W6MW+ukTf53WvD9G0HJHLlw4=; b=hMsd8IgiRWdtf54ktrBeTkoh3GChCtCYWD3KCSSSLwXGacaLneUeutM/ngW1Ky2rh51m/4 0ZYZI0tMxxG/QrFYthlNLftOkX9lW6c0lbVOeCLc6Zupv6ITiAgqNA9R2RZGIs2761zRFE SaVUJIOOF6FGm11K0M1g6c1a64oLCb4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-245-Bv3cl8sPMD-IInSnlTpBjw-1; Fri, 26 Mar 2021 11:16:07 -0400 X-MC-Unique: Bv3cl8sPMD-IInSnlTpBjw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4705A1966341; Fri, 26 Mar 2021 15:14:23 +0000 (UTC) Received: from [10.36.110.27] (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC99D19C71; Fri, 26 Mar 2021 15:14:20 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com, yinan.wang@intel.com, cheng1.jiang@intel.com, sunil.pai.g@intel.com References: <1615985773-406787-1-git-send-email-jiayu.hu@intel.com> <1615985773-406787-2-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: <7b336779-73cf-1c29-e9be-ecc581b2cd43@redhat.com> Date: Fri, 26 Mar 2021 16:14:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1615985773-406787-2-git-send-email-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] vhost: fix uninitialized vhost queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/17/21 1:56 PM, Jiayu Hu wrote: > This patch allocates vhost queue by rte_zmalloc() to avoid > undefined values. > > Fixes: 8acd7c213353 ("vhost: fix virtqueues metadata allocation") This is not the right commit. rte_malloc was used prior to it. > Signed-off-by: Jiayu Hu > --- > lib/librte_vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index 52ab93d..f6fd001 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -598,7 +598,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) > if (dev->virtqueue[i]) > continue; > > - vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0); > + vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0); > if (vq == NULL) { > VHOST_LOG_CONFIG(ERR, > "Failed to allocate memory for vring:%u.\n", i); >