From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>,
rahul.lakkireddy@chelsio.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] net/cxgbe: remove unused variable
Date: Wed, 25 Jan 2017 12:15:14 +0000 [thread overview]
Message-ID: <7b39bb9f-9e45-8179-fd5f-ec777b97186c@intel.com> (raw)
In-Reply-To: <20170124204859.8998-3-emmanuel.roullit@gmail.com>
On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
>
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> ---
> drivers/net/cxgbe/sge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
> index 42051ca01..37b609040 100644
> --- a/drivers/net/cxgbe/sge.c
> +++ b/drivers/net/cxgbe/sge.c
> @@ -890,7 +890,7 @@ static inline int should_tx_packet_coalesce(struct sge_eth_txq *txq,
> struct sge_txq *q = &txq->q;
> unsigned int flits, ndesc;
> unsigned char type = 0;
> - int credits, hw_cidx = ntohs(q->stat->cidx);
> + int credits;
This depends on patch 2/3, so this patch will wait it to be clarified.
>
> /* use coal WR type 1 when no frags are present */
> type = (mbuf->nb_segs == 1) ? 1 : 0;
>
next prev parent reply other threads:[~2017-01-25 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 20:48 [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom Emmanuel Roullit
2017-01-24 20:48 ` [dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage Emmanuel Roullit
2017-01-25 12:13 ` Ferruh Yigit
2017-01-26 4:41 ` Rahul Lakkireddy
2017-01-26 11:05 ` Ferruh Yigit
2017-02-14 6:10 ` Yuanhan Liu
2017-01-24 20:48 ` [dpdk-dev] [PATCH 3/3] net/cxgbe: remove unused variable Emmanuel Roullit
2017-01-25 12:15 ` Ferruh Yigit [this message]
2017-01-25 12:12 ` [dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom Ferruh Yigit
2017-01-26 11:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b39bb9f-9e45-8179-fd5f-ec777b97186c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=emmanuel.roullit@gmail.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).