From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E29BA034F; Fri, 8 Oct 2021 17:30:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4269440040; Fri, 8 Oct 2021 17:30:20 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 37D634003C for ; Fri, 8 Oct 2021 17:30:18 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10131"; a="249891278" X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="249891278" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 08:30:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="590581276" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 08 Oct 2021 08:30:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 08:30:16 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 8 Oct 2021 08:30:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 8 Oct 2021 08:30:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NCJnSL6Q28T69Ws6dVnUuL5WdWCm71cBwVvNDpj1Tv7I2rxYM2uOZDnC5eLz1PpQhBTFSNJVUogNHkGKHazoZ0Czxq0EjnOR+xoxoXXcFBkFztRMHV5C+0DzdVUsg3qr/rHh0DQnA153EIVrKLQDBKfYgXAn1/qnFszXEY9DFJfZM1SrpmEfcR4QX6FpEnaQW8bANGZM5BLWUW+ksOKBEhVqhz6/quhBB6yhbc6j4CTlU/Bhnfo4WcHQFhCo9G4DAQMFAaLKOeYWIq543i3bHfX7ZU/T3OZ3MQ+iLsD8LjZkLJAhxIZzrRrugAgjLl/FBszCw6DX/Ud+LiWfW5VrsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n6fii+dE2hk5kjVREm75Vn5R2WgaNYg6WoHCDR5t6X8=; b=AZwANT+UycE+m5wYJ5Lw6M5IADD+nUeyx9hXIbaJIOFOnrqwt7vNds2jb4ysdsMosocTVS+6eUw3tUzVCZDBaMFrZpr/YnkGgvJ2wAN0Ur/PiMDtSHaEqTqyZjp2yMMeS662+zOW8yHFGoaMF1qoyM02UAK85SaWO5B77I9jKhKnQyIdjnVgO9xzXdRa2coS0XJD2jOtMCrmz+RU0HvfdcW2Tc7LhjF+wCqG2P6xN8VjBVFRSz5v1QjQiLf1NNxOgSMj8Ec49sv3Ru8Lq+QNhWirN68In21UcXp08sHiSovPuyo6VdeTbYniH3Th8boAI/nGOPjZT4/9UXxMcPIpRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n6fii+dE2hk5kjVREm75Vn5R2WgaNYg6WoHCDR5t6X8=; b=Za1uH5eSIYrQ38srarvvHlxkQPNw7H2gZ/iNKTO443TcAiHxxRC5OBjUB6QWYFYczV1yZlNoiA9c5d+igznCPu2CH1xOzwO7xFq5k//+gq3lTCi98As6z/oNtQyw2B8GAIg5n0E2FimPzlKez7HssrQT35inWWORpLt7VTPmtgU= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct 2021 15:30:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 15:30:12 +0000 Message-ID: <7b432da0-d51d-f7da-2679-cfc67b20b47d@intel.com> Date: Fri, 8 Oct 2021 16:30:06 +0100 Content-Language: en-US To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Maciej Czekaj [C]" CC: "dev@dpdk.org" , Bruce Richardson References: <34ea1ee8-1ba2-4a70-8d9a-85b30fed4a6c@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:10:3b::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0030.eurprd04.prod.outlook.com (2603:10a6:10:3b::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.21 via Frontend Transport; Fri, 8 Oct 2021 15:30:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec0069e9-e604-422f-117b-08d98a708513 X-MS-TrafficTypeDiagnostic: PH0PR11MB4984: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aOlNEhqsd9uJk2XYu3cnb3gjcm+UM+lqxCsnkBb9wKrUMgoXcyCXZqwkeHIHMmAOU6f77n6j9ZXgmnf30OZg48K12+0CCz9SrUj/5yCqBSmFLOIvK3z822jRFHCCTPR7Avj/kb5buIWa6t/QwSPlEr7gPiRHfbN4zV1PStZ0DMGHdHNBhGBXp13eiHwGrGn43evh6nqZ7vM671bzPONiOt4FZIzhClfprk5hfhf5xxLbbJ6TSKwThE8M2jFcpB8+2upiZo0LAhS6nelUsTGzKRBTMdZ85XeK1IR1mKkMmW+8HJQXfbE2NCntwoKn8BKJxgJc6uMXk79jGtKUIZX4XQzoDNai1OUKHp7ZgUO3n+IPDcFYJi649in4aSgicxUe1eIy4VzzvseJGGeuEOKFtWtzQmRjWOhCEQvY2yBgBw6JEaj5OlE5GlrpQuA8GXtjXRIRs5WUO0CDxFksFbhqPzO/9AMDIxON357Z6dKH/lHzIY0Mbv3CHt0nN8MsO0I2Cj9DUeYtC5nKFoYdZWjgismmDWyRS+7bs3StoFKK7Fj7uqxQ1r3TF5izB6SksnfD4xRVNH2RT5T/iS7zRXNjv/rp0ZIhhvBC0Q5XCJJGCgA64wCh/mf1P96N+eW+0Ar+8H/G6mquezeTMWDBf+m0VaCLQ980M/6yKk2hZCWUxrzIwtb9/5AVEeQ+/8+jEOlidcPt/vT7RCDaPWMQDCTaAw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(36756003)(83380400001)(44832011)(26005)(38100700002)(2616005)(31686004)(4326008)(956004)(6666004)(31696002)(53546011)(8676002)(8936002)(107886003)(508600001)(54906003)(66556008)(5660300002)(110136005)(6486002)(66476007)(66946007)(2906002)(316002)(86362001)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHNzOEtrWkFYeW5FMFhZV25CMmJmWFk5Snp4U1VDeUR6NWFlTnNxT3hPSGh1?= =?utf-8?B?L3FtOWFpSmZiYnBHMFQ1K3pxclc2NjExNmVaL0p4eXc2eHdOV01xVHpjcUJz?= =?utf-8?B?M3I4aUQzK0pMZnUyWEk3d2w0MmtKMTgzbnRDL2srbHkvSUI4RUx2ZkRvM1U2?= =?utf-8?B?YUo5NGtpN3I2VExscm9mZ0dKd3Y0b1NEeFJyVnkrZHltZC9NM3N2TytIKzc4?= =?utf-8?B?ZWtEdWdENS81aUhqWjRDbGl5MVRpMDNpVk4zY0h0d3dVRFJjMjdXVGZKMWtO?= =?utf-8?B?ejFoeEhHL0xJZVJqckpReDd2bFd6ZXdKdEI0clFKdWpSUzRmeW9KSEdjOGNO?= =?utf-8?B?T0FXY2lFc1kyelJnc0JWVDUvNHZlQTZKRGdaaU1KTTZlL01NZ3M4WkJCR1V4?= =?utf-8?B?M1FtbG9PdVpZS3VQTWNvTDUyeCszcENmRlhncktjMHY4T0Zva0pOdm9JczBa?= =?utf-8?B?S0FLekFNNkYxK21kUFpDb2Z5RUc5dEo0K09neVFTSTdRZGFJZUIzQllxY2FH?= =?utf-8?B?WEtTTGl2dXhyYTdqS0VHZG85c2FjUDF3Sk8wbW5VNXpzTzhvdkpZbkszWEkz?= =?utf-8?B?a1pLN2NjWGRjTWhnVm95REYweDBNOUsrS3hYckM1WHgrMTVBOWN3QUEwZXo2?= =?utf-8?B?bTVoTjBha01WRVFBM01vbEQvODdOWmkzazNHYmw1UkYvMWdXb0sxazU4RG1S?= =?utf-8?B?NGlEZjJGYldsbGpoMjdzaXlncXR5cWE2Tkt4THRJQ09pR1d3ZnE1aUZOWFBv?= =?utf-8?B?M1ZVazcxTERCeTY5QUVXVFlkcUJtQmZBK2xPcmFpV2hoSzlxOGRDNXcvT2RM?= =?utf-8?B?NEJDVExuV2pjOTJ0cGJmcjJlcFk3ZWZ6Ym1aWE0waytWeWpZWFAxZUtxd09z?= =?utf-8?B?V2pUbnM2Ly93VWNrc09wTUNIekl0c0U0ZXZUY0ZCRzBPdGZXTUVBVEt0Q1cw?= =?utf-8?B?SkRKdENmU2pUbnluWUxoQlpRdVNRZW1nZVkyRE12YTF3RVoyYUlIbFpTTGJK?= =?utf-8?B?NzZHZ1BlOHpUVlBVclVyTmQ5NEZRc3VqNnVQZU0vUERoWlFsOWVVWjQySjgx?= =?utf-8?B?OTVqWjNLb2pZQmx1UUNnVlN0RTk4cFFieVFYS3Rpam9WaFJOSU9YWnhkZkw0?= =?utf-8?B?OWVzU3kwRVlSU3kreGZtMUhVSUxyb1NrZFVqMDVDN0EybklLQW5KSFNOSE1Z?= =?utf-8?B?ZmR1TklwQTRZVy9TZTg5cEpVUUpqVFhPclpWelJjNER1OFlFa3ZBMjB5Z1Np?= =?utf-8?B?UTZHVE44aXZjQW15UGdKMlQ4Rys0UWVmbkNCanBuQjc2VG1MR1JKZGZqaldt?= =?utf-8?B?MVRBRWFPLzlzbC8wU1dkL3VSN2tGWmNqdktMK1lOK0pwVFNSRk4zaW9VM1BZ?= =?utf-8?B?cDBUeXZ4V3pSV09XbTQ0VldFUTZ6aHJkNE9LY29VeTFFRHBCNVB4MzdubXgy?= =?utf-8?B?ZllTMDlIQS9obEJPK3VHZGRIek43MjhDekZxRDFCOFRYV3k4UTIyRXZWeUdj?= =?utf-8?B?TXlWdytHT3ZHRjRwNEQzUmcydWMrTHZFT0xET0lpMVBid1l1Nk1Mcmh1ZHBP?= =?utf-8?B?c2xhLy9xNnJDd0hUMXhBamRtV2Z1WWUxdWZvRkp5SUJ4encrL3dKdk1rczIx?= =?utf-8?B?TFVQNE5iVE5QZUllQ2pCd2taRnpOV0x2TEhQYllGN3hDSUFWR1Z6MlNlZ0ZT?= =?utf-8?B?bjJ6eW55M0dBSnpUVmFiQ3RmOEZUc0pvUFYyK21rOHJZTnZqYVg2TTh4U2lY?= =?utf-8?Q?ZGcrFlTw2TRy2l5dcEUdgVmLdWQiYixERzvmTHD?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec0069e9-e604-422f-117b-08d98a708513 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 15:30:12.6202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lzdm+GyP6Kuz78bVv4GDvZkdqrGk4Cnun37YK6AS8XihP0kW4IHKLzAUAsHMdXg61SZBAhMKJXyoG2iouJBP9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/2021 1:54 PM, Pavan Nikhilesh Bhagavatula wrote: >> On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote: >>>> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote: >>>>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote: >>>>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote: >>>>>>>>> From: Pavan Nikhilesh >>>>>>>>> >>>>>>>>> Due to Linux kernel AF(Admin function) driver dependency, >> only >>>>>>>> enable >>>>>>>>> build for 64-bit Linux. >>>>>>>>> >>>>>>>> >>>>>>>> Hi Pavan, >>>>>>>> >>>>>>>> Isn't it possible to provide a commit log in the kernel side etc, >> that >>>> let >>>>>>>> others to verify why only 64 bit is required, or if someone want >> to >>>>>>>> support >>>>>>>> 32bit that may help them to investigate the source of the >>>> restriction. >>>>>>> >>>>>>> Arch 32 support is not implemented on ThunderX, so 32bit will >> not >>>>>> run. >>>>>>> >>>>>> >>>>>> I see, is following correct: >>>>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK, >>>> and PF >>>>>> is >>>>>> supported by Linux kernel driver. And Linux kernel driver doesn't >>>>>> support arch32. >>>>> >>>>> AF != PF, AF is something that manages all the shared resources >>>> between PF/VF. >>>>> >>>> >>>> I see, I though AF is part of PF functionality. Are there two different >>>> kernel >>>> modules for PF and AF? >>>> >>>> So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF >> by >>>> Linux >>>> kernel driver. >>> >>> Yup that’s correct. >>> >>>> >>>>>> >>>>>> Is something changed in kernel driver side to drop the 32bit >> support? >>>>>> If it was not supported at all, what is the motivation to disable the >>>> DPDK >>>>>> drivers now? >>>>>> >>>>> >>>>> It was never supported to begin with, motivation is that build will >> fail if >>>> we try to >>>>> compile with 32b. >>>>> >>>> >>>> If there is no plan to support 32bit in the kernel side, that is >> reasonable >>>> to >>>> disable 32bit build, please provide above details in the commit log. >>>> >>>> And after above said, how much maintenance cost to support 32bit, >> if >>>> the build >>>> error is on the logging format "%lx" etc .. (as we mostly have 32bit >> build >>>> errors), it is better to fix them using 'PRIx64' which is more proper >> way >>>> anyway. If there is more logical issue with 32bit pointers, I agree with >>>> you to >>>> disable it. >>>> Can you please provided the build error in the commit log as record? >>>> >>> >>> Apologies, I meant that all the functions that don’t fall under 64b are >> stubbed out >>> so the driver wouldn’t work. >>> >> >> so is there build error or not? >> > > No build error. > Just trying to clarify, Linux kernel AF kernel driver only build for 64-bit Linux. And mentioned DPDK drivers have a dependency to this kernel module. But DPDK drivers are userspace application, can't 32-bit application run on 64-bit Linux? Can you please clarify what exactly is not supported? >>>>>>>> >>>>>>>>> Signed-off-by: Pavan Nikhilesh >>>>>>>>> Acked-by: Jerin Jacob >>>>>>>>> --- >>>>>>>>> v5 Changes >>>>>>>>> - s/fuction/function. >>>>>>>>> >>>>>>>>> v4 Changes: >>>>>>>>> - Update commit message regarding dependency on AF >> driver. >>>>>>>>> >>>>>>>>> drivers/net/thunderx/meson.build | 4 ++-- >>>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/drivers/net/thunderx/meson.build >>>>>>>> b/drivers/net/thunderx/meson.build >>>>>>>>> index 4bbcea7f93..da665bd76f 100644 >>>>>>>>> --- a/drivers/net/thunderx/meson.build >>>>>>>>> +++ b/drivers/net/thunderx/meson.build >>>>>>>>> @@ -1,9 +1,9 @@ >>>>>>>>> # SPDX-License-Identifier: BSD-3-Clause >>>>>>>>> # Copyright(c) 2017 Cavium, Inc >>>>>>>>> >>>>>>>>> -if is_windows >>>>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') >>>>>>>>> build = false >>>>>>>>> - reason = 'not supported on Windows' >>>>>>>>> + reason = 'only supported on 64-bit Linux' >>>>>>>>> subdir_done() >>>>>>>>> endif >>>>>>>>> >>>>>>>>> -- >>>>>>>>> 2.17.1 >>>>>>>>> >>>>>>> >>>>> >>> >