From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C0C1A0567; Tue, 9 Mar 2021 12:43:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B40C622A51D; Tue, 9 Mar 2021 12:43:56 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A9FF422A4FD for ; Tue, 9 Mar 2021 12:43:54 +0100 (CET) IronPort-SDR: A8VgQfudFVpOz58hV9nVij3mbM5sQqJYX2P1ItmMg837CQTRs6lWFNeJVW14/wG4SUb2EIsD64 YLICWS9wTOlg== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="273243449" X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="273243449" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 03:43:53 -0800 IronPort-SDR: TaT8n8tWBD0noXGp4BnkhXXKcJj5i0ErbeDlogzzS4/qplBRgR60UN6m51j5o1bV2xKA1EZ3QR YJEDH1MErwPQ== X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="409703187" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.196.3]) ([10.213.196.3]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 03:43:52 -0800 To: Ed Czeck , dev@dpdk.org Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210308222922.30667-1-ed.czeck@atomicrules.com> <20210308222922.30667-5-ed.czeck@atomicrules.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <7b4ca8c2-6fb0-1eb4-956a-752b8369bc78@intel.com> Date: Tue, 9 Mar 2021 11:43:48 +0000 MIME-Version: 1.0 In-Reply-To: <20210308222922.30667-5-ed.czeck@atomicrules.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ark: cleanup and document ark dynamic extansion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/8/2021 10:29 PM, Ed Czeck wrote: > - Rename extension functions with rte_pmd_ark prefix > - Move extension prototype to rte_pmd_ark.h > - Update documentation for extension Hi Ed, I think better to have the documentation with the previous patch, where it has the hooks. It has a benefit to have the documentation and the code in same commit, when you want to investigate some code it is easy the find the commit that has been introduced and documentation being in the same commit gives the full intentions to investigate, if documentation is in different commit it is easy the miss the documentation part. But I can see documentation is using renamed, and latest, APIs that may be the reason to have the documentation in this commit. Sorry it will require some playing with git but can you do the renaming first, and in second patch you can add the new hooks with documentation in same patch? This way the API names will be correct in the documentation again when you add it. Thanks, ferruh > > Signed-off-by: Ed Czeck > --- > v3: > - split function rename from previous commit <...>