From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CBD342A5E for ; Wed, 29 Mar 2017 19:00:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490806800; x=1522342800; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=NHiR5iKuIV1NmMrRnmQhhUfkbuIwVWbmg9pTb8ZHftA=; b=soRZR8mtt5jVsfTCyiJMEoV/2GJjI+tM98sNIWpxtDcYcz4x4bMvxBR5 lNcj16Wcl/MpS9L292Os35wUrop+aA==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 09:59:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,242,1486454400"; d="scan'208";a="1128555700" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 29 Mar 2017 09:59:58 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com> <4a22c344-fc76-e3de-f1c2-4f96e51c86b4@intel.com> From: Ferruh Yigit Message-ID: <7b63eeec-e0d6-6f6b-8800-10c03a6b6071@intel.com> Date: Wed, 29 Mar 2017 17:59:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 17:00:01 -0000 On 3/29/2017 5:37 PM, Andrew Rybchenko wrote: > On 03/29/2017 07:25 PM, Ferruh Yigit wrote: >> On 3/29/2017 4:08 PM, Andrew Rybchenko wrote: >>> Datapath TxQ handle is passed to release function, not control path. >>> >>> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath") >>> >>> Signed-off-by: Andrew Rybchenko >>> --- >>> Please, squash the patch into 5808dbaf751f. >> Hi Andrew, > > Hi Ferruh, > >> To clarify, for the commits in next-net tree that are not merged yet, we >> can benefit from sub-tree re-writable option and squash some fixes, >> -without over using it. > > Yes, it is perfectly clear. > >> But for this patch, as far as I can see, original code added with >> commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues") >> which is part of v17.02 release. > > If we take a look a lines, yes, these lines belong to > b1b7ad933b39 ("net/sfc: set up and release Tx queues") > however the breakage is introduced by > 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") > since it registers pointer to the so-called datapath Tx queue in the > device data > instead of previous used control path Tx queue pointer. Oh, I see now, I was checking updated lines. > >> So, please send a patch with correct fixes line and it won't be squashed. > > Correct fixes line for the patch with current dpdk-next-net is: > > Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") > > which is in dpdk-next-net tree only. Should I resend it? I saw you already sent another patch, that is good, thanks. > > Thanks, > Andrew.