From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: david.marchand@redhat.com, jerinj@marvell.com,
stephen@networkplumber.org,
Nicolas Chautru <nicolas.chautru@intel.com>,
Somalapuram Amaranath <asomalap@amd.com>,
John Griffin <john.griffin@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Deepak Kumar Jain <deepak.k.jain@intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
Date: Tue, 6 Oct 2020 11:16:11 +0100 [thread overview]
Message-ID: <7b7c60ef-8b11-ca20-bf09-5f43132cbe3b@intel.com> (raw)
In-Reply-To: <20201005094300.590912-1-thomas@monjalon.net>
On 10/5/2020 10:42 AM, Thomas Monjalon wrote:
> As decided in the Technical Board in November 2019,
> the kernel module igb_uio is moved to the dpdk-kmods repository
> in the /linux/igb_uio/ directory.
>
> Minutes of Technical Board meeting:
> https://mails.dpdk.org/archives/dev/2019-November/151763.html
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v4: Cc more maintainers
> v3: update more docs and provide a link to the new repo
> v2: update few docs (including release notes)
> ---
> MAINTAINERS | 1 -
> doc/guides/bbdevs/fpga_5gnr_fec.rst | 3 +-
> doc/guides/bbdevs/fpga_lte_fec.rst | 3 +-
> doc/guides/cryptodevs/ccp.rst | 3 +-
> doc/guides/cryptodevs/qat.rst | 3 +-
> doc/guides/howto/lm_bond_virtio_sriov.rst | 2 +-
> doc/guides/howto/lm_virtio_vhost_user.rst | 2 +-
> doc/guides/howto/openwrt.rst | 5 -
> doc/guides/linux_gsg/enable_func.rst | 3 +-
> doc/guides/linux_gsg/linux_drivers.rst | 23 +-
> doc/guides/nics/build_and_test.rst | 2 +-
> doc/guides/nics/ena.rst | 4 +-
> doc/guides/rel_notes/deprecation.rst | 7 -
> doc/guides/rel_notes/release_20_11.rst | 4 +-
> doc/guides/sample_app_ug/multi_process.rst | 2 -
> drivers/bus/pci/bsd/pci.c | 2 +-
> kernel/linux/igb_uio/Kbuild | 2 -
> kernel/linux/igb_uio/compat.h | 154 -----
> kernel/linux/igb_uio/igb_uio.c | 660 ---------------------
> kernel/linux/igb_uio/meson.build | 20 -
> kernel/linux/meson.build | 2 +-
> 21 files changed, 21 insertions(+), 886 deletions(-)
> delete mode 100644 kernel/linux/igb_uio/Kbuild
> delete mode 100644 kernel/linux/igb_uio/compat.h
> delete mode 100644 kernel/linux/igb_uio/igb_uio.c
> delete mode 100644 kernel/linux/igb_uio/meson.build
>
Patch doesn't apply cleanly, not sure why, CI seems having same problem:
http://mails.dpdk.org/archives/test-report/2020-October/156378.html
<...>
> index 7789c572bb..080b44955a 100644
> --- a/doc/guides/linux_gsg/linux_drivers.rst
> +++ b/doc/guides/linux_gsg/linux_drivers.rst
> @@ -27,33 +27,20 @@ can provide the uio capability. This module can be loaded using the command:
>
> ``uio_pci_generic`` module doesn't support the creation of virtual functions.
>
> -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio
> -module which can be found in the kernel/linux subdirectory referred to above. It can
> -be loaded as shown below:
> +As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module
> +which can be found in the repository `dpdk-kmods <http://git.dpdk.org/dpdk-kmods>`_.
> +It can be loaded as shown below:
>
> .. code-block:: console
>
> sudo modprobe uio
> - sudo insmod <build_dir>/kernel/linux/igb_uio/igb_uio.ko
> -
> -.. note::
> -
> - Building DPDK Linux kernel modules is disabled by default starting from DPDK 20.02.
> - To enable them again, the config option "enable_kmods" needs to be set
> - in the meson build configuration.
> - See :ref:`adjusting_build_options` for details on how to set/clear build options.
> - It is planned to move ``igb_uio`` module to a different git repository.
> -
> -.. note::
> -
> - For some devices which lack support for legacy interrupts, e.g. virtual function
> - (VF) devices, the ``igb_uio`` module may be needed in place of ``uio_pci_generic``.
> + sudo insmod igb_uio.ko
>
> .. note::
>
> If UEFI secure boot is enabled, the Linux kernel may disallow the use of
> UIO on the system. Therefore, devices for use by DPDK should be bound to the
> - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``.
> + ``vfio-pci`` kernel module rather than any UIO-based module.
> For more details see :ref:`linux_gsg_binding_kernel` below.
Should we change the order of the kernel drivers, currently first section is
"UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out
of the repo, should we list the "VfIO" first?
<...>
> index 4e61431c6c..243bd940a4 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -122,9 +122,11 @@ Removed Items
>
> * vhost: Dequeue zero-copy support has been removed.
>
> +* kernel: The module ``igb_uio`` has been moved to the git repository
> +``dpdk-kmods`` in a new directory ``linux/igb_uio``.
> +
Doc build giving warning on this:
WARNING: Bullet list ends without a blank line; unexpected unindent.
Except from above minor comments looks good to me,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2020-10-06 10:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 22:50 [dpdk-dev] [PATCH] kernel: " Thomas Monjalon
2020-09-08 0:14 ` Thomas Monjalon
2020-09-08 8:25 ` Bruce Richardson
2020-09-08 9:27 ` Thomas Monjalon
2020-09-08 9:34 ` Bruce Richardson
2020-09-08 9:46 ` Thomas Monjalon
2020-09-08 12:06 ` Ferruh Yigit
2020-09-11 12:22 ` Thomas Monjalon
2020-09-11 15:54 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-09-11 16:22 ` Ferruh Yigit
2020-09-12 8:55 ` Thomas Monjalon
2020-09-14 9:47 ` Ferruh Yigit
2020-09-24 5:41 ` Stephen Hemminger
2020-10-05 8:57 ` Thomas Monjalon
2020-10-05 9:11 ` Maxime Coquelin
2020-10-05 9:56 ` Bruce Richardson
2020-10-10 7:23 ` 谢华伟(此时此刻)
2020-10-05 9:38 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2020-10-05 9:42 ` [dpdk-dev] [PATCH v4] kernel/linux: " Thomas Monjalon
2020-10-05 10:14 ` Andrew Rybchenko
2020-10-05 11:14 ` Jerin Jacob
2020-10-06 10:16 ` Ferruh Yigit [this message]
2020-10-06 10:54 ` Thomas Monjalon
2020-10-06 11:09 ` Ferruh Yigit
2020-10-06 12:49 ` Thomas Monjalon
2020-10-06 12:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7c60ef-8b11-ca20-bf09-5f43132cbe3b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=asomalap@amd.com \
--cc=david.marchand@redhat.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=fiona.trahe@intel.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=jerinj@marvell.com \
--cc=john.griffin@intel.com \
--cc=mdr@ashroe.eu \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).