From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26F77A0C41; Fri, 16 Apr 2021 10:25:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EED82141BA7; Fri, 16 Apr 2021 10:25:23 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 902E0141BA6 for ; Fri, 16 Apr 2021 10:25:22 +0200 (CEST) IronPort-SDR: uMpz+F458nmcZ6D2+5tENDuLoBfXb0ZIDDfkFuZ/X+bNvndiE08bVAi0nSKlR11lxn4hABH40D ORg8bcmxQLyw== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="258966213" X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="258966213" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 01:25:21 -0700 IronPort-SDR: fCNxb3EAqOoEvjzdRnZ4Zn///dr6VPdoTO7BRhsKKiV1fqTdN3GF34GYCiWo0KUaILlyqAU7R9 Jtv/TuyCqfBA== X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="425512325" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.207.150]) ([10.213.207.150]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 01:25:20 -0700 To: Stephen Hemminger , dev@dpdk.org, Anatoly Burakov References: <20210315192722.35490-1-stephen@networkplumber.org> <20210316092805.0168dfb7@hermes.local> Cc: David Marchand , Thomas Monjalon From: Ferruh Yigit X-User: ferruhy Message-ID: <7b7ea4a4-b1a2-aaa7-f114-49d435fe3fc2@intel.com> Date: Fri, 16 Apr 2021 09:25:17 +0100 MIME-Version: 1.0 In-Reply-To: <20210316092805.0168dfb7@hermes.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/2] Mark shared pthread mutex X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 4:28 PM, Stephen Hemminger wrote: > On Mon, 15 Mar 2021 12:27:20 -0700 > Stephen Hemminger wrote: > >> This fixes two places where pthread_mutex was being unsafely >> used between primary secondary process. >> >> These patches are necessary but not sufficient to address Bug 662 >> >> Stephen Hemminger (2): >> ethdev: make flow API primary/secondary process safe >> net/failsafe: fix primary/secondary mutex >> >> drivers/net/failsafe/failsafe.c | 5 +++++ >> lib/librte_ethdev/rte_ethdev.c | 6 +++++- >> 2 files changed, 10 insertions(+), 1 deletion(-) >> > > The following drivers have the same kind of issue. > > Drivers with unsafe pthread_mutex: > > net/ > af_xdp > atlantic > axgbe > bnxt > ena > failsafe (see patch #2) > hinic > mlx5 > qede > vhost > virtio > > raw/ > ifpga > vdpa/ > ifc > mlx5 > > > Another alternative would be to create a DPDK wrapper (rte_mutex?) > which had the proper semantics. That might make the Windows port easier. > But it would make backport to stable harder. > > > If this does not get fixed in April, we should change documentation > to warn users. > > +Anatoly as our multi process maintainer. And most of the above nics already doesn't claim the multi process support (in .ini files), the ones that claims the support: mlx[45] bnxt hinic qede virtio