DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: thomas.monjalon@6wind.com, john.mcnamara@intel.com,
	zhiyong.yang@intel.com, dev@dpdk.org, fbaudin@redhat.com
Subject: Re: [dpdk-dev] [PATCH] doc: introduce PVP reference benchmark
Date: Tue, 29 Nov 2016 11:29:58 +0100	[thread overview]
Message-ID: <7b9bda04-3216-f54e-2b30-4772445c60eb@redhat.com> (raw)
In-Reply-To: <20161129101647.GP5048@yliu-dev.sh.intel.com>

Hi Yuanhan,

On 11/29/2016 11:16 AM, Yuanhan Liu wrote:
> On Thu, Nov 24, 2016 at 08:35:51AM +0100, Maxime Coquelin wrote:
>>
>>
>> On 11/24/2016 06:07 AM, Yuanhan Liu wrote:
>>> First of all, thanks for the doc! It's a great one.
>> Thanks.
>> I would be interested to know if you have other tuning I don't mention
>> in this doc.
>
> I was thinking we may need doc some performance impacts by some features,
> say we observed that indirect desc may be good for some cases, while may
> be bad for others. Also, the non mergeable Rx path outweighs the mergeable
> Rx path. If user cares about the perfomance and ascertains all packets
> fits into a typical MTU, he may likely want to disable the mergeable
> feature, which is enabled by default.
>
> Maybe we could start a new doc, or maybe we could add a new section here?

I agree that we should documents impact of Virtio features on traffic
profile.
My opinion is that it deserves a dedicated document.

For this PVP doc, I suggest we add a section stating that one could try
with different Virtio features, and in Kevin's result template
proposal, we add a line for Virtio features enabled/disabled.

Thanks,
Maxime
>
> 	--yliu
>

  reply	other threads:[~2016-11-29 10:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 21:00 Maxime Coquelin
2016-11-24  5:07 ` Yuanhan Liu
2016-11-24  7:35   ` Maxime Coquelin
2016-11-29 10:16     ` Yuanhan Liu
2016-11-29 10:29       ` Maxime Coquelin [this message]
2016-11-24 11:58 ` Kevin Traynor
2016-11-24 12:39   ` Maxime Coquelin
2016-11-24 17:38 ` Mcnamara, John
2016-11-25  9:29   ` Maxime Coquelin
2016-11-28 11:22 ` Thomas Monjalon
2016-11-28 14:02   ` Maxime Coquelin
2016-11-28 14:15     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b9bda04-3216-f54e-2b30-4772445c60eb@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fbaudin@redhat.com \
    --cc=john.mcnamara@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=yuanhan.liu@linux.intel.com \
    --cc=zhiyong.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).