From: Ranjit Menon <ranjit.menon@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org
Cc: Pallavi Kadam <pallavi.kadam@intel.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim
Date: Wed, 17 Mar 2021 12:19:54 -0700 [thread overview]
Message-ID: <7bb0fe1c-8a34-c5e3-1f90-00e5cfe99bc7@intel.com> (raw)
In-Reply-To: <20210313222217.18271-1-dmitry.kozliuk@gmail.com>
On 3/13/2021 2:22 PM, Dmitry Kozlyuk wrote:
> Networking header shim in Windows EAL conflicts with system headers and
> tries to provide POSIX compatibility out of scope for DPDK.
> Remove dependency on POSIX headers from libraries supported on Windows,
> then replace shim with librte_net with workarounds.
>
> A proposed deprecation notice is assumed:
> http://patchwork.dpdk.org/project/dpdk/list/?series=15595
>
> v3: Fix build on FreeBSD for real (CI).
> v2: Fix build on FreeBSD (CI).
>
> Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols")
>
> Dmitry Kozlyuk (4):
> cmdline: remove POSIX dependency
> ethdev: remove POSIX dependency
> net/mlx5: remove POSIX dependency
> net: replace Windows networking shim
>
> drivers/net/mlx5/mlx5.h | 2 +-
> drivers/net/mlx5/mlx5_flow.c | 4 +--
> drivers/net/mlx5/mlx5_flow.h | 4 +--
> drivers/net/mlx5/mlx5_mac.c | 1 -
> examples/cmdline/commands.c | 1 -
> examples/cmdline/parse_obj_list.c | 2 --
> lib/librte_cmdline/cmdline.c | 1 -
> lib/librte_cmdline/cmdline_parse.c | 2 --
> lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 ----
> lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 ----
> lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +-
> lib/librte_eal/windows/include/arpa/inet.h | 30 ----------------
> lib/librte_eal/windows/include/netinet/in.h | 38 --------------------
> lib/librte_eal/windows/include/netinet/ip.h | 10 ------
> lib/librte_eal/windows/include/sys/socket.h | 24 -------------
> lib/librte_ethdev/rte_ethdev.c | 13 +++----
> lib/librte_ethdev/rte_ethdev_core.h | 1 -
> lib/librte_net/rte_ether.h | 26 ++++++++++----
> lib/librte_net/rte_ip.h | 18 ++++++++++
> 19 files changed, 49 insertions(+), 142 deletions(-)
> delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h
> delete mode 100644 lib/librte_eal/windows/include/netinet/in.h
> delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h
> delete mode 100644 lib/librte_eal/windows/include/sys/socket.h
>
Acked-by: Ranjit Menon <ranjit.menon@intel.com>
prev parent reply other threads:[~2021-03-17 19:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 1:56 [dpdk-dev] [PATCH " Dmitry Kozlyuk
2021-03-13 1:56 ` [dpdk-dev] [PATCH 1/4] cmdline: remove POSIX dependency Dmitry Kozlyuk
2021-03-13 1:56 ` [dpdk-dev] [PATCH 2/4] ethdev: " Dmitry Kozlyuk
2021-03-13 1:56 ` [dpdk-dev] [PATCH 3/4] net/mlx5: " Dmitry Kozlyuk
2021-03-13 1:56 ` [dpdk-dev] [PATCH 4/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-13 2:56 ` [dpdk-dev] [PATCH v2 0/4] " Dmitry Kozlyuk
2021-03-13 2:56 ` [dpdk-dev] [PATCH v2 1/4] cmdline: remove POSIX dependency Dmitry Kozlyuk
2021-03-13 2:56 ` [dpdk-dev] [PATCH v2 2/4] ethdev: " Dmitry Kozlyuk
2021-03-13 2:56 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: " Dmitry Kozlyuk
2021-03-13 2:56 ` [dpdk-dev] [PATCH v2 4/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-13 22:22 ` [dpdk-dev] [PATCH v3 0/4] " Dmitry Kozlyuk
2021-03-13 22:22 ` [dpdk-dev] [PATCH v3 1/4] cmdline: remove POSIX dependency Dmitry Kozlyuk
2021-03-17 17:22 ` Tyler Retzlaff
2021-03-13 22:22 ` [dpdk-dev] [PATCH v3 2/4] ethdev: " Dmitry Kozlyuk
2021-03-17 17:22 ` Tyler Retzlaff
2021-03-13 22:22 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: " Dmitry Kozlyuk
2021-03-17 17:22 ` Tyler Retzlaff
2021-03-13 22:22 ` [dpdk-dev] [PATCH v3 4/4] net: replace Windows networking shim Dmitry Kozlyuk
2021-03-15 13:03 ` [dpdk-dev] [PATCH v3 0/4] " Ferruh Yigit
2021-03-15 13:23 ` Dmitry Kozlyuk
2021-03-17 19:19 ` Ranjit Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bb0fe1c-8a34-c5e3-1f90-00e5cfe99bc7@intel.com \
--to=ranjit.menon@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).