From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8AA3A0561; Wed, 17 Mar 2021 20:19:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E868140F2C; Wed, 17 Mar 2021 20:19:57 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 66578140F2C for ; Wed, 17 Mar 2021 20:19:55 +0100 (CET) IronPort-SDR: AuJGedI9gFzD2DnkFZA7bpqco9Man0ffQsdaPBMjzM+NdDJqJPXn91n+Un3Lg31nO9BTeObDJ9 UQPt7idcSrDw== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="168808794" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="168808794" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 12:19:54 -0700 IronPort-SDR: EjEcHOKszDRiH6Mw1GbYCUWM+rqJCsyAOt//NILLLAgEgFlY53Lvte9JKoqXNVgqUoxIZpSw81 oWiFE12cqYXw== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="412775035" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 12:19:54 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Pallavi Kadam , Dmitry Malloy , Narcisa Ana Maria Vasile , Tyler Retzlaff References: <20210313025645.6034-1-dmitry.kozliuk@gmail.com> <20210313222217.18271-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: <7bb0fe1c-8a34-c5e3-1f90-00e5cfe99bc7@intel.com> Date: Wed, 17 Mar 2021 12:19:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210313222217.18271-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/13/2021 2:22 PM, Dmitry Kozlyuk wrote: > Networking header shim in Windows EAL conflicts with system headers and > tries to provide POSIX compatibility out of scope for DPDK. > Remove dependency on POSIX headers from libraries supported on Windows, > then replace shim with librte_net with workarounds. > > A proposed deprecation notice is assumed: > http://patchwork.dpdk.org/project/dpdk/list/?series=15595 > > v3: Fix build on FreeBSD for real (CI). > v2: Fix build on FreeBSD (CI). > > Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols") > > Dmitry Kozlyuk (4): > cmdline: remove POSIX dependency > ethdev: remove POSIX dependency > net/mlx5: remove POSIX dependency > net: replace Windows networking shim > > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mlx5/mlx5_flow.c | 4 +-- > drivers/net/mlx5/mlx5_flow.h | 4 +-- > drivers/net/mlx5/mlx5_mac.c | 1 - > examples/cmdline/commands.c | 1 - > examples/cmdline/parse_obj_list.c | 2 -- > lib/librte_cmdline/cmdline.c | 1 - > lib/librte_cmdline/cmdline_parse.c | 2 -- > lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 ---- > lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 ---- > lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- > lib/librte_eal/windows/include/arpa/inet.h | 30 ---------------- > lib/librte_eal/windows/include/netinet/in.h | 38 -------------------- > lib/librte_eal/windows/include/netinet/ip.h | 10 ------ > lib/librte_eal/windows/include/sys/socket.h | 24 ------------- > lib/librte_ethdev/rte_ethdev.c | 13 +++---- > lib/librte_ethdev/rte_ethdev_core.h | 1 - > lib/librte_net/rte_ether.h | 26 ++++++++++---- > lib/librte_net/rte_ip.h | 18 ++++++++++ > 19 files changed, 49 insertions(+), 142 deletions(-) > delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h > delete mode 100644 lib/librte_eal/windows/include/netinet/in.h > delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h > delete mode 100644 lib/librte_eal/windows/include/sys/socket.h > Acked-by: Ranjit Menon