From: David Christensen <drc@linux.vnet.ibm.com>
To: dev@dpdk.org, David Wilder <wilder@us.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file
Date: Mon, 16 Mar 2020 12:07:49 -0700 [thread overview]
Message-ID: <7bb3246f-2331-0cd0-d589-19324787fb16@linux.vnet.ibm.com> (raw)
In-Reply-To: <f36c55ed-ea6b-cc72-b78c-36f4c0ea3c0b@linux.vnet.ibm.com>
On 3/16/20 10:49 AM, David Christensen wrote:
>
>> The rte_pci.h file includes more header files than are actually needed,
>> which means that all users of it also include those headers. This patch
>> removes the unneeded headers - adding them elsewhere where other
>> components
>> were requiring them but not including them directly.
>>
>> Fixes: c752998b5e2e ("pci: introduce library and driver")
>> Cc: gaetan.rivet@6wind.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Patch is generating build errors with meson on my POWER system, though I
> don't see how they're POWER specific:
There's a pending patch to enable Travis for POWER systems:
http://patches.dpdk.org/patch/65986/
Any reason it hasn't been accepted yet? Looks like it would have caught
this problem.
Dave
next prev parent reply other threads:[~2020-03-16 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 11:29 Bruce Richardson
2020-03-16 14:30 ` Thomas Monjalon
2020-03-16 17:49 ` David Christensen
2020-03-16 19:07 ` David Christensen [this message]
2020-03-19 8:10 ` David Marchand
2020-03-20 13:25 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bb3246f-2331-0cd0-d589-19324787fb16@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).