From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ori Kam <orika@nvidia.com>, Ruifeng Wang <ruifeng.wang@arm.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"NBU-Contact-N?lio Laranjeiro (EXTERNAL)"
<nelio.laranjeiro@6wind.com>,
"NBU-Contact-Adrien Mazarguil (EXTERNAL)"
<adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"nd@arm.com" <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] ethdev: fix 32-bit build with GCC-13
Date: Wed, 1 Nov 2023 16:57:04 +0000 [thread overview]
Message-ID: <7bb33e4b-af65-4e0e-9f34-0a6e8a24df64@amd.com> (raw)
In-Reply-To: <MW2PR12MB466642545DCF9A9E3F872058D6A7A@MW2PR12MB4666.namprd12.prod.outlook.com>
On 11/1/2023 8:12 AM, Ori Kam wrote:
> Hi
>
>> -----Original Message-----
>> From: Ruifeng Wang <ruifeng.wang@arm.com>
>> Sent: Wednesday, November 1, 2023 9:16 AM
>>
>> aarch32 build with gcc-13.0.1 generated following warning:
>>
>> In function 'memcpy',
>> inlined from 'rte_memcpy' at
>> ../lib/eal/arm/include/rte_memcpy_32.h:296:9,
>> inlined from 'rte_flow_conv_action_conf' at ../lib/ethdev/rte_flow.c:726:20,
>> inlined from 'rte_flow_conv_actions' at ../lib/ethdev/rte_flow.c:936:10:
>> warning: '__builtin_memcpy' specified bound 4294967264 exceeds maximum
>> object size 2147483647 [-Wstringop-overflow=]
>>
>> The issue is due to possible wrapping in unsigned arithmetic.
>> The 'size' can be 0. 'off' is 32. When 'tmp' is equal to (unsigned)-32,
>> the copy length is more than half the address space. Hence the warning.
>>
>> Casted variables to 64-bit to avoid wrapping.
>>
>> Fixes: 063911ee1df4 ("ethdev: add flow API object converter")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Luca Boccassi <bluca@debian.org>
>> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
>>>
> Acked-by: Ori Kam <orika@nvidia.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-11-01 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 7:15 Ruifeng Wang
2023-11-01 8:12 ` Ori Kam
2023-11-01 16:57 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bb33e4b-af65-4e0e-9f34-0a6e8a24df64@amd.com \
--to=ferruh.yigit@amd.com \
--cc=adrien.mazarguil@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=orika@nvidia.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).