From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 160DE41DC7; Fri, 3 Mar 2023 13:44:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCB3340687; Fri, 3 Mar 2023 13:44:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D3924400D6 for ; Fri, 3 Mar 2023 13:44:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677847482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AEY8I2vWrkcTMKoQQDSdgpd/N/mo6RclnYTiT+QAP8A=; b=hOAoYgbxJql7CJF5ZfRIB6H/SElPLuEziAQE/7rmnOhCkIj2QKTnF5VNGi1A7AY6KdN/af 0NJtN/ryO+WvRTNZ8Enj9LmljpcsbGpyU2d2DPJpjOrllPu9c7l+YeURKrnClBzDP+wCwH qNxxHsfAgOAYv4FHre+k3yg1LC0oHdA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-259-2e9DnvLHOtKvWdMESslmlA-1; Fri, 03 Mar 2023 07:44:36 -0500 X-MC-Unique: 2e9DnvLHOtKvWdMESslmlA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58DB2802D2F; Fri, 3 Mar 2023 12:44:36 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1F15C16900; Fri, 3 Mar 2023 12:44:34 +0000 (UTC) Message-ID: <7bdc1d66-fb5f-333c-9744-5eb97cc6eee4@redhat.com> Date: Fri, 3 Mar 2023 13:44:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 09/17] test/bbdev: add timeout for enq/deq loops To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230302202211.170017-1-hernan.vargas@intel.com> <20230302202211.170017-10-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230302202211.170017-10-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/23 21:22, Hernan Vargas wrote: > Added timeout to prevent infinite loop condition if the device > doesn't enqueue/dequeue. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 133 ++++++++++++++++++++++++++----- > 1 file changed, 113 insertions(+), 20 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 7bfc4cd5779e..7a4841a069ee 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -192,6 +192,15 @@ struct test_time_stats { > typedef int (test_case_function)(struct active_device *ad, > struct test_op_params *op_params); > > +/* Get device status before timeout exit */ > +static inline void > +timeout_exit(uint8_t dev_id) > +{ > + struct rte_bbdev_info info; > + rte_bbdev_info_get(dev_id, &info); > + printf("Device Status %s\n", rte_bbdev_device_status_str(info.drv.device_status)); > +} > + > static inline void > mbuf_reset(struct rte_mbuf *m) > { > @@ -3553,7 +3562,7 @@ throughput_pmd_lcore_dec(void *arg) > ops_enq[j]->opaque_data = (void *)(uintptr_t)j; > > for (i = 0; i < TEST_REPETITIONS; ++i) { > - > + uint32_t time_out = 0; > for (j = 0; j < num_ops; ++j) > mbuf_reset(ops_enq[j]->turbo_dec.hard_output.data); > if (so_enable) > @@ -3573,12 +3582,23 @@ throughput_pmd_lcore_dec(void *arg) > > deq += rte_bbdev_dequeue_dec_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Enqueue timeout!"); > + } > } > > /* dequeue the remaining */ > + time_out = 0; > while (deq < enq) { > deq += rte_bbdev_dequeue_dec_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } > > total_time += rte_rdtsc_precise() - start_time; > @@ -3669,6 +3689,7 @@ bler_pmd_lcore_ldpc_dec(void *arg) > ops_enq[j]->opaque_data = (void *)(uintptr_t)j; > > for (i = 0; i < 1; ++i) { /* Could add more iterations */ > + uint32_t time_out = 0; > for (j = 0; j < num_ops; ++j) { > if (!loopback) > mbuf_reset( > @@ -3692,12 +3713,23 @@ bler_pmd_lcore_ldpc_dec(void *arg) > > deq += rte_bbdev_dequeue_ldpc_dec_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Enqueue timeout!"); > + } > } > > /* dequeue the remaining */ > + time_out = 0; > while (deq < enq) { > deq += rte_bbdev_dequeue_ldpc_dec_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } > > total_time += rte_rdtsc_precise() - start_time; > @@ -3796,6 +3828,7 @@ throughput_pmd_lcore_ldpc_dec(void *arg) > ops_enq[j]->opaque_data = (void *)(uintptr_t)j; > > for (i = 0; i < TEST_REPETITIONS; ++i) { > + uint32_t time_out = 0; > for (j = 0; j < num_ops; ++j) { > if (!loopback) > mbuf_reset( > @@ -3820,12 +3853,23 @@ throughput_pmd_lcore_ldpc_dec(void *arg) > > deq += rte_bbdev_dequeue_ldpc_dec_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Enqueue timeout!"); > + } > } > > /* dequeue the remaining */ > + time_out = 0; > while (deq < enq) { > deq += rte_bbdev_dequeue_ldpc_dec_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } > > total_time += rte_rdtsc_precise() - start_time; > @@ -3907,7 +3951,7 @@ throughput_pmd_lcore_enc(void *arg) > ops_enq[j]->opaque_data = (void *)(uintptr_t)j; > > for (i = 0; i < TEST_REPETITIONS; ++i) { > - > + uint32_t time_out = 0; > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > for (j = 0; j < num_ops; ++j) > mbuf_reset(ops_enq[j]->turbo_enc.output.data); > @@ -3925,12 +3969,23 @@ throughput_pmd_lcore_enc(void *arg) > > deq += rte_bbdev_dequeue_enc_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Enqueue timeout!"); > + } > } > > /* dequeue the remaining */ > + time_out = 0; > while (deq < enq) { > deq += rte_bbdev_dequeue_enc_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } > > total_time += rte_rdtsc_precise() - start_time; > @@ -3997,7 +4052,7 @@ throughput_pmd_lcore_ldpc_enc(void *arg) > ops_enq[j]->opaque_data = (void *)(uintptr_t)j; > > for (i = 0; i < TEST_REPETITIONS; ++i) { > - > + uint32_t time_out = 0; > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > for (j = 0; j < num_ops; ++j) > mbuf_reset(ops_enq[j]->turbo_enc.output.data); > @@ -4015,12 +4070,23 @@ throughput_pmd_lcore_ldpc_enc(void *arg) > > deq += rte_bbdev_dequeue_ldpc_enc_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Enqueue timeout!"); > + } > } > > /* dequeue the remaining */ > + time_out = 0; > while (deq < enq) { > deq += rte_bbdev_dequeue_ldpc_enc_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } > > total_time += rte_rdtsc_precise() - start_time; > @@ -4086,7 +4152,7 @@ throughput_pmd_lcore_fft(void *arg) > ops_enq[j]->opaque_data = (void *)(uintptr_t)j; > > for (i = 0; i < TEST_REPETITIONS; ++i) { > - > + uint32_t time_out = 0; > for (j = 0; j < num_ops; ++j) > mbuf_reset(ops_enq[j]->fft.base_output.data); > > @@ -4103,12 +4169,23 @@ throughput_pmd_lcore_fft(void *arg) > > deq += rte_bbdev_dequeue_fft_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Enqueue timeout!"); > + } > } > > /* dequeue the remaining */ > + time_out = 0; > while (deq < enq) { > deq += rte_bbdev_dequeue_fft_ops(tp->dev_id, > queue_id, &ops_deq[deq], enq - deq); > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(tp->dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } > > total_time += rte_rdtsc_precise() - start_time; > @@ -4481,6 +4558,7 @@ latency_test_dec(struct rte_mempool *mempool, > > for (i = 0, dequeued = 0; dequeued < num_to_process; ++i) { > uint16_t enq = 0, deq = 0; > + uint32_t time_out = 0; > bool first_time = true; > last_time = 0; > > @@ -4523,6 +4601,11 @@ latency_test_dec(struct rte_mempool *mempool, > last_time = rte_rdtsc_precise() - start_time; > first_time = false; > } > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } while (unlikely(burst_sz != deq)); > > *max_time = RTE_MAX(*max_time, last_time); > @@ -4615,7 +4698,11 @@ latency_test_ldpc_dec(struct rte_mempool *mempool, > first_time = false; > } > time_out++; > - } while ((burst_sz != deq) && (time_out < TIME_OUT_POLL)); > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > + } while (unlikely(burst_sz != deq)); > > *max_time = RTE_MAX(*max_time, last_time); > *min_time = RTE_MIN(*min_time, last_time); > @@ -4624,14 +4711,8 @@ latency_test_ldpc_dec(struct rte_mempool *mempool, > if (extDdr) > retrieve_harq_ddr(dev_id, queue_id, ops_enq, burst_sz); > > - if (burst_sz != deq) { > - struct rte_bbdev_info info; > - ret = TEST_FAILED; > - rte_bbdev_info_get(dev_id, &info); > - TEST_ASSERT_SUCCESS(ret, "Dequeue timeout!"); > - } else if (test_vector.op_type != RTE_BBDEV_OP_NONE) { > - ret = validate_ldpc_dec_op(ops_deq, burst_sz, ref_op, > - vector_mask); > + if (test_vector.op_type != RTE_BBDEV_OP_NONE) { > + ret = validate_ldpc_dec_op(ops_deq, burst_sz, ref_op, vector_mask); > TEST_ASSERT_SUCCESS(ret, "Validation failed!"); > } > > @@ -4692,17 +4773,17 @@ latency_test_enc(struct rte_mempool *mempool, > first_time = false; > } > time_out++; > - } while ((burst_sz != deq) && (time_out < TIME_OUT_POLL)); > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > + } while (unlikely(burst_sz != deq)); > > *max_time = RTE_MAX(*max_time, last_time); > *min_time = RTE_MIN(*min_time, last_time); > *total_time += last_time; > - if (burst_sz != deq) { > - struct rte_bbdev_info info; > - ret = TEST_FAILED; > - rte_bbdev_info_get(dev_id, &info); > - TEST_ASSERT_SUCCESS(ret, "Dequeue timeout!"); > - } else if (test_vector.op_type != RTE_BBDEV_OP_NONE) { > + > + if (test_vector.op_type != RTE_BBDEV_OP_NONE) { > ret = validate_enc_op(ops_deq, burst_sz, ref_op); > TEST_ASSERT_SUCCESS(ret, "Validation failed!"); > } > @@ -4728,6 +4809,7 @@ latency_test_ldpc_enc(struct rte_mempool *mempool, > > for (i = 0, dequeued = 0; dequeued < num_to_process; ++i) { > uint16_t enq = 0, deq = 0; > + uint32_t time_out = 0; > bool first_time = true; > last_time = 0; > > @@ -4763,6 +4845,11 @@ latency_test_ldpc_enc(struct rte_mempool *mempool, > last_time += rte_rdtsc_precise() - start_time; > first_time = false; > } > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } while (unlikely(burst_sz != deq)); > > *max_time = RTE_MAX(*max_time, last_time); > @@ -4796,6 +4883,7 @@ latency_test_fft(struct rte_mempool *mempool, > > for (i = 0, dequeued = 0; dequeued < num_to_process; ++i) { > uint16_t enq = 0, deq = 0; > + uint32_t time_out = 0; > bool first_time = true; > last_time = 0; > > @@ -4831,6 +4919,11 @@ latency_test_fft(struct rte_mempool *mempool, > last_time += rte_rdtsc_precise() - start_time; > first_time = false; > } > + time_out++; > + if (time_out >= TIME_OUT_POLL) { > + timeout_exit(dev_id); > + TEST_ASSERT_SUCCESS(TEST_FAILED, "Dequeue timeout!"); > + } > } while (unlikely(burst_sz != deq)); > > *max_time = RTE_MAX(*max_time, last_time); Reviewed-by: Maxime Coquelin Thanks, Maxime