* [dpdk-dev] [PATCH] net/tap: fix multi process request
@ 2019-02-26 9:50 Raslan Darawsheh
2019-02-26 10:13 ` Rami Rosen
0 siblings, 1 reply; 3+ messages in thread
From: Raslan Darawsheh @ 2019-02-26 9:50 UTC (permalink / raw)
To: keith.wiles; +Cc: dev, Thomas Monjalon, stable
The structure was not initialized.
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
drivers/net/tap/rte_eth_tap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 586c8a9..6f5109f 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2086,6 +2086,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
int queue, fd_iterator;
/* Prepare the request */
+ memset(&request, 0, sizeof(request));
strlcpy(request.name, TAP_MP_KEY, sizeof(request.name));
strlcpy(request_param->port_name, port_name,
sizeof(request_param->port_name));
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/tap: fix multi process request
2019-02-26 9:50 [dpdk-dev] [PATCH] net/tap: fix multi process request Raslan Darawsheh
@ 2019-02-26 10:13 ` Rami Rosen
2019-02-26 10:57 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2019-02-26 10:13 UTC (permalink / raw)
To: Raslan Darawsheh; +Cc: keith.wiles, dev, Thomas Monjalon, stable
Reviewed-by: Rami Rosen <ramirose at gmail.com>
On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh <rasland@mellanox.com>
wrote:
> The structure was not initialized.
>
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
> secondary")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 586c8a9..6f5109f 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -2086,6 +2086,7 @@ tap_mp_attach_queues(const char *port_name, struct
> rte_eth_dev *dev)
> int queue, fd_iterator;
>
> /* Prepare the request */
> + memset(&request, 0, sizeof(request));
> strlcpy(request.name, TAP_MP_KEY, sizeof(request.name));
> strlcpy(request_param->port_name, port_name,
> sizeof(request_param->port_name));
> --
> 2.7.4
>
>
--
regards,
Rami Rosen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: fix multi process request
2019-02-26 10:13 ` Rami Rosen
@ 2019-02-26 10:57 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-02-26 10:57 UTC (permalink / raw)
To: Rami Rosen, Raslan Darawsheh; +Cc: keith.wiles, dev, Thomas Monjalon, stable
On 2/26/2019 10:13 AM, Rami Rosen wrote:
> Reviewed-by: Rami Rosen <ramirose at gmail.com>
>
>
> On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh <rasland@mellanox.com>
> wrote:
>
>> The structure was not initialized.
>>
>> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
>> secondary")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-26 10:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 9:50 [dpdk-dev] [PATCH] net/tap: fix multi process request Raslan Darawsheh
2019-02-26 10:13 ` Rami Rosen
2019-02-26 10:57 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).