From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A996A0C56; Wed, 8 Sep 2021 15:31:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DABC41140; Wed, 8 Sep 2021 15:31:15 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9B88440E25 for ; Wed, 8 Sep 2021 15:31:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="217319574" X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="217319574" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 06:31:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,278,1624345200"; d="scan'208";a="524830675" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 08 Sep 2021 06:31:12 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 06:31:11 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 06:31:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 8 Sep 2021 06:31:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 8 Sep 2021 06:31:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtVqvv/irn0qcCL9PL+A/9js5wEKEAW4opdehv0fzUjrpbMgw2KVfB4AkkZHGu3DHoKjCGiOpP7atn3yuowQlXqdqwdQ7/nKYTLldIwEpfyQGjltAft18HPbBRCYd0izRCvPEfKC0ZvA+Jp9BsUdmPIb7md5TpEtWlroyuHBOjBasMYxfrppzCwlG4UskHYsanqb5YkmppY5jApf5M+aNt8792/Wy3OZoX4PotvIZYdAQaAAnxD8pNz5ich/J2146sj3PZLsv3mmpWT9Riy9S0tgYuGGIchiPn0vH9xkiKtbXFNgnZnvgaRRDBqFhZ378KjqR79oK8H3AEFNoZja/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cLgZzDKI4hI76/5YlaMkVLLmSA1C/asivyncbAu5bGw=; b=NJFr+Bo5BpcqXY+vc58WFk1Yur0aztlmGM5XYqNsaaIPr1OBu5tGq6J56Y/GAmF+tahaPNSPdukjCnddDTvvlDtpCwBFumDPNnvXLOQ4MVtPvnyBDXGUItareNq2du2MPRJksMid5TM1y0hoPe2ublMSLd6eDYntizi40i6/Fne6Chl4LEYCegd2LYurv76x4KagOEZPhh0vQGpFLlK7TWIcYotpQ+erVos6PKBUkVfR+KImL41UIdmQhhOxA7pPykNlzXh1PyOT2AvQSq1j+MIjfFU3RXZggmiNmMbSjzTtIt1JMXBJVNXaz6ag+2AcW3CH1F2irwadaiBY3kP6MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLgZzDKI4hI76/5YlaMkVLLmSA1C/asivyncbAu5bGw=; b=QlGPJVLvATW63XQwMbBqvrQjGYj0qcaPN7gBxMuW8/Wyq6Fc10+mdOmfMT50gBVoXRfd6/IDQEZcTz1MP7b28AuMlY6cKAhPlbeHozm68CdZLsjgqjOoVGssLJBD638N7CW3DrO0uvYJaj8wxI9rSz8QCT6o1Oo4dZcUOkaTBR4= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 13:31:10 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 13:31:10 +0000 To: Chengfeng Ye , CC: References: <20210826185559.107237-1-cyeaa@connect.ust.hk> From: Ferruh Yigit X-User: ferruhy Message-ID: <7c3748ba-3324-7993-5cc7-5f6af3ec7caf@intel.com> Date: Wed, 8 Sep 2021 14:31:05 +0100 In-Reply-To: <20210826185559.107237-1-cyeaa@connect.ust.hk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR01CA0012.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR01CA0012.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 13:31:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7786e32d-4377-4d7a-0347-08d972cceba2 X-MS-TrafficTypeDiagnostic: PH0PR11MB5112: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ui8u2tf/b0A4LU1DJFLkU38EtmXYlXnuNzFjgplFGZSkMRnFSHr/9CuALhr0A3Zk13I/R3qr9FH07ENwiy4H1L5AuQc6745Kbt9yeyaagSEYyCxZY6INbOLTslza8E7VFYoXA1vQmOgYXYDHjNE1dtknWBxbU6JPkG0klcs/WxQB80DYagc6hluVOS0xWnJU8DwwqSHjq8gw6c/kl9PnxHzyzPZWf2mKlvuJf4wknEcyY4vvUqMeVSQtC6R6KqkWNsoMMkFnW/YDbsHo7Jxa8zvWssz3JdDptHiAdgIKCaF2MH2jFHPGZWfpVqMYfumZlynABmCI9y7PSn68BmamQ5SAE1Qs/LJDiYMsCvwc9PW9WP7GvPuP0qQQMoYSHoe36QNXeSXVFITChOkr/LvILwEWAsXrhv1NpQx9TO/JqA35Eeppp2qE2Jb4RyQi3wtGd2IqEUgNZ24LSZXhAEkzJECixPlwulfVMHFpoVso/XlOUAxQkz623Ge/vf7e8pOuYgX1jjn+CA/0frPQi9H0rDqh2HVEd4nLFJzNmiLrFpTBrFnZXuNUHlPPg1xzWHAIsCpzrTwB0u5vEzubHUI/E7CBWODZ4B9jyQW9u5bPtQCnfnU8HSot4CliAEzN+97S8oupTM3xJkvd2OIZhZf3usaxsa61NUqxAtbYSS9Je3zz/LhIW0HOySGs9U22NK2fRtSd49JFcky+WmS3+6/Z8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(136003)(366004)(396003)(53546011)(26005)(5660300002)(8676002)(2906002)(4744005)(36756003)(38100700002)(31696002)(66946007)(186003)(44832011)(6486002)(8936002)(86362001)(478600001)(66556008)(6666004)(956004)(4326008)(16576012)(316002)(2616005)(31686004)(66476007)(83380400001)(70780200001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkJzbkJEa01DajR4UEJFSXE0OEhCcHdhMHcreFZKVWJxc2xpOWJmcFlSTzBN?= =?utf-8?B?S2FIYmFuaFJJMW9LRlEySzIzbmcyWTI1Q0dkd3VlbmhjSmFNcXh6cXZWSlhi?= =?utf-8?B?QzBGK1RHbmdNb0ZjMmN0cWRHQlZGK3EwSzFuZTBoSVFxQnMxeUVpZzlFajdS?= =?utf-8?B?VmRTbmJCYjNVWTErdXhScWlybVBNaURWUDE4WE8yTnR0aUhzQnNqSW5nVzRq?= =?utf-8?B?cXhYbUZYZHp3YjBjSnVOZGlGaEdSNFlxRVlzeUhvV1E3NEhkTnZLaVA1NjJY?= =?utf-8?B?RzFldFNWNEg5V0lmVFBkUkw5dXRaRlNGQlVLWU9VbHVtZjN1MUpaeC9oU2wr?= =?utf-8?B?dXZ3Q1V4Rk1KM3BJMytrL25Ycmk1amNmb2VpZlZJNlJSU3dhdU9VWEtlY1FK?= =?utf-8?B?VFpxVVlJRmVxNDY4VmRXUjhHTUdNVlcxUEtOdFY2VkY4YndqMlpMa2ZvaVY3?= =?utf-8?B?b1EvaXBscWxzSGRBdXVDNkx1UUxnYlJhdWFHc1pBVjBxTThxNVNCbmRMZDF4?= =?utf-8?B?QldEWXNKWngvZ1FYRGd5bHdTaGxvNmVORTdSbDJpeDhaODIyQlJHZ0dYdC9p?= =?utf-8?B?UnF6VmdmRUhaREdVSmdnUW1tME51N2JHOTZXdXphbXJESHhhN0I0YmFKeGp1?= =?utf-8?B?THZjL0Niend1ZzFvWFoyVFpjd3BCN1liVllzYVpFbWxzem5Nb2ZHUFlVQUFl?= =?utf-8?B?dTh5TkUwQ0RVeWtzaUluUFdxY3RYazJRSVlkdTh5Z0J6d0t1Zy84bnlackg1?= =?utf-8?B?MDY2K2YwQUdpeFRuK2VrVFFrTWF5U3NEc3JkK1NycDJXMVE0ZUpKeCtnYzZ2?= =?utf-8?B?NEZhdUZ4ZW4vUkY1U1pLTTlzQ2xDZDJubnpGSHFDdW5abXBlYUdSWm9GLzNB?= =?utf-8?B?QkR3OEdRMUtRMXhHRThtRGw4Z1lET3p3Q3RrM1I4OFcxSHp5c1VlUUlvVEhD?= =?utf-8?B?cXhsMFpaTE1EV04vZURVU0VmdGJERVg4VFJOdmplMlR3ZEtaY0x3L3BJRWpE?= =?utf-8?B?Z1RKbWxQVkJSdk9MM0ZPUmFDUzNrb1ZxRVBFVWxSYk1SY2QxNE5ldXY2TGdF?= =?utf-8?B?bU9JZWdUeTlsSEhab3dQa2tKQzBjUU1zUlVmRnVTcDdOeEMrOHBmc0FYT08x?= =?utf-8?B?YXoxSXNyaVZRa1o5cFhsTzdXd2FPTVBDTktqakQ5Qm1iaDArMk5NVXJIeDBD?= =?utf-8?B?c2ZTNVVEK1JzNFYydGRTWnJqQ1pNenhXeS9LYkxQaXNLNkhlZloyUlpZQlU5?= =?utf-8?B?UXpiYjJnNWxZY3EvTzNhUWVjSjBLL3EvUDZMS0YvYkxGT0hxaWhtSTd0cE9G?= =?utf-8?B?azU1am9JQlk4emtQbDhueGNNZDEvZ1JJRFZsQktiQzE5eUIwTHprN0N4eDNY?= =?utf-8?B?QTVDK2ZzSU0wcGpYdVM2RlczMWJEVTBTT3ZPVzE4bVpsMG9ZNS9pcFM2VTB1?= =?utf-8?B?aXR0dE13TnFLM052N2hveDJRYlZaUHUwRldsZ3NKYyt3LzFxZ2x2SEcvMVRl?= =?utf-8?B?MkRHQkcxQ2Npb3RJZGErVGgxRFBsWWlXaDRBZStzdTBJNVgxY1ZwQjErY0xa?= =?utf-8?B?akovaUozT2lSd3NJTS9KQitxNHFKYkd5TGNtS3cwb0VoM3pObDNKTk1kZnR4?= =?utf-8?B?UVhiL3JjY0NyVGh4TnE0Rmo5dnF1NE1OQ05Yd2UwTVJOTHNFZythZU91OW1Q?= =?utf-8?B?eU1rdjFkcnh6WENoR1dZTy81Rmwzd0lJRWYwUDB1T1ZIQ1hqeXd1MmpsNjFM?= =?utf-8?Q?l+VNTwtNE3MyHZ2prQJAOtdluRlDMXR5B9/yImS?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7786e32d-4377-4d7a-0347-08d972cceba2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 13:31:10.8524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T1zsXRUk8g3k0d56qTABT64M0uycteX0sQ6KVbC1nk/QO9XT7lMpw5lxc/3KAYoGBu+OTE/PON93KFmx0mYumQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem in axgbe_i2c_xfer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/26/2021 7:55 PM, Chengfeng Ye wrote: > The lock pdata->i2c_mutex is not released if the function return in > these two patched branches, which may lead to deadlock problem if > this lock is acquired again. > > Cc: cyeaa@connect.ust.hk > Bugzilla ID: 777 > > Signed-off-by: Chengfeng Ye Reviewed-by: Ferruh Yigit Bugzilla ID: 777 Fixes: 4ac7516b8b39 ("net/axgbe: add phy init and related APIs") Cc: stable@dpdk.org Patch title updated as following while merging: net/axgbe: fix unreleased lock in I2C transfer Applied to dpdk-next-net/main, thanks.