From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7494943B01; Mon, 12 Feb 2024 15:14:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E43C9402D9; Mon, 12 Feb 2024 15:14:34 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2085.outbound.protection.outlook.com [40.107.212.85]) by mails.dpdk.org (Postfix) with ESMTP id 10FCE402D0 for ; Mon, 12 Feb 2024 15:14:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1YjHdmSHDY2CeF+VK5QTsMWTkAzecCybkbQpCsnrH+hYxz1X7HTdT/F4++rH0U56RQDndlIBCffhq9mu87fr6cWRD7+Nqm9Ie2JSjj2F4LKUPymB/aiDvLlm/HYHMes8pJXt2WIwEAF1OyAW67Y2LexMlHLGGBe9y5hrrO3xYayzP+On3i1Sr9hYs0L0Yzs6u3WVyomgVZvtTVNGpoilRxx16BWB2GV8A44HNdJpIg7bf179aPK00Yw5ipVYxkoLqGVPQVUReW/AkJ+cjR4N3+BxAUMWUoIKNy5YAko+k4SoN0gM119GCidrpnpcNRwW2cDr7/WmO/yl96n9bly0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHeFae1/Em2dFQyRG7tgvvDarzoLyBKxsNDWhbxEgqE=; b=miQ5EWE8K30BMdrMV96Y3VjBiPdwDQOiobV+cPoYMKHG9J8TnZtnT49QYHQj4vat8OA1M/JdD5s8X7s/1g9tUkQ/+66otx+/kbFxEoSX138GSjsizB8B1IbBGUfaidokhFISv2dkFTzfMS7HQE78iNesaowqKRN4fv4RV7pfzw2uDtsEfICIv4ZMulEX/D6jYQVPb7ujrwPtC3X6dE4r8SUqMbrMaV5hwH1d/K7cjXuhboeVSpdu3zIIQlKzAIyexaSCbg4pf5M0mNIYyJkEjU8qQ5U0oHr53PKSwKA0BA6E3tk/wBqKQpQ7TGv8C3bMkxVgrvN1wiB58/IQ6h1TxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHeFae1/Em2dFQyRG7tgvvDarzoLyBKxsNDWhbxEgqE=; b=2dYvQ+vUB1DqQI2XXayMFLz6YGjv39G+m1Ng9s+2lgD2WncjJ02zIYsZwaTJzdFn9EUca7pqQ2snfezCfexXvAK9XI0l3RIWdSYjf/J9S7BEhrbWMiXd3fqvSvZKcLo7txa9S7yYL8/UzZ6snYbvmGw49BxXMNCtl+WtslRjYZE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB5610.namprd12.prod.outlook.com (2603:10b6:a03:423::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Mon, 12 Feb 2024 14:14:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%4]) with mapi id 15.20.7292.022; Mon, 12 Feb 2024 14:14:29 +0000 Message-ID: <7c5bcfe0-dd24-4ca8-acf1-62c6246458ad@amd.com> Date: Mon, 12 Feb 2024 14:14:25 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] ethdev: add template table resize API Content-Language: en-US To: Gregory Etelson , dev@dpdk.org Cc: mkashani@nvidia.com, thomas@monjalon.net, Ori Kam , Aman Singh , Yuying Zhang , Andrew Rybchenko References: <20231217093205.321082-1-getelson@nvidia.com> <20240211093053.397469-1-getelson@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240211093053.397469-1-getelson@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0062.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB5610:EE_ X-MS-Office365-Filtering-Correlation-Id: 78ec1013-0e84-4e38-9652-08dc2bd4ed21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GAP2NrQZ5yAjrtQSfkC36ZdeTkohMai8KyMJT9aRgzONvBUfwnyqvlhypvFu+qizcz01s4MEFPRojf79rAkZZU+FE3VoWfMVaUv/YBwDl0i9UwJ70/CPkY23IL5Mf9MhBdcH9dmic9NFdPtIKcjkYikjAg3UTb5fVhKtaH0STb2vL/J/tQ6txNfqyoziYf43A/zeLHS9G41V1CNYt8y/FvimvFaZx7SstzZsb+7NRp+038rAvnl4kZt7wx1j5vKh6NMGYHrdM4g0lTMyLrF/A0kldg4s9M7IHvCRt67uBMvX7hbiPzPIvxWSJnPlKo3dhyNccY+ZsyRyNvQR4HQ68bmoI2oA6iIhvjT4TWOXlmlBuJPjxORAKLrH/0vK/a6hirdm3A/TdIiMZFST8em+68oYB5g1yWmKqw/OR4sIOcj+KvZgl4Ug8b9yHdPw41h09EegYN0912WoHMpvSwIosBFe7nSr9BOdYADO/xUKCwzIXG5Q4rbPC+MM+7QuvBNPEWWL1WnRjIMRok0H06UdJPfCLbCtXblRTXXFJ0wa0Rq228FhsFUcUM6VWOD5Sxej X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(136003)(366004)(396003)(346002)(230273577357003)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(6506007)(6666004)(478600001)(83380400001)(53546011)(26005)(6512007)(2616005)(2906002)(66556008)(316002)(66946007)(8676002)(54906003)(8936002)(4326008)(5660300002)(44832011)(66476007)(36756003)(38100700002)(31696002)(6486002)(86362001)(41300700001)(31686004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3JGUWRzTlRhY1FSL1hmUHZHUTlobmQ5UlcySzNKSGVZY0Y5YkVSSXZxenNW?= =?utf-8?B?SnZYdkRheGYraTlvVDh1dTN3b0UzVDZISjhqcGpQU3RHKzBxd1l4azFoRjBo?= =?utf-8?B?cFpvL0ZqM0VTclIwOU5nUkFQemdlMW5PQmZzbXlFMWdFQWpzM0dwMFdrRm1T?= =?utf-8?B?akVHTnN1cVpKaktEUnZZM3huWTNLckZLNWJTQ1pmeFZORjBOMkd4czcxckk4?= =?utf-8?B?V3pCYjdkTnJmZkVhRGNWR0ZQL2tIYUdEZ0tnWDhJZXl1ekhzdjd3UjQ5WS9Z?= =?utf-8?B?djJBa21oNk5zUmE4Q01HNnBYcEE0b0YwUUdzR3Jub25WeXFRSXkwcS9NOHVk?= =?utf-8?B?d0JScFBmT2dEWXozNXJJekllemo2aTVwN2VFYkVCblJKSDRTcDJJaTZQYlRF?= =?utf-8?B?cUJMSXZFVGgwZDJqc2xoeFVzQ1ovenc5ejdqVURKQXhzcG4yK3lZamMxR0pz?= =?utf-8?B?VXpuaWZ1b0lpalpqQ2hXeGxnQllRa0IwdnJsS2pWK1JpYUFRdWZLTGxaNlhG?= =?utf-8?B?dHpVR0RCUlZjUEh0Tk8yckRCWVBjM0xDUFR6RGR5aHF2YXZCWFMwUkxhNnpk?= =?utf-8?B?cEsreXVydTdqM2U4ditTL1hhTWJPU3RRSWg3Q1ZyR2p6UkN2TW8xYTg5K3pa?= =?utf-8?B?d21MZ0tJNTEyWFpldDdVRnJFNnJMSEdybXVnYXJHUGZOUlkyMys2UWt2U2M5?= =?utf-8?B?ckJldHlmeUxxek5URDcwUmpjY0hxZGZ1OEt2QkVUM2Z2NFY1NVpFdGlNbXF2?= =?utf-8?B?NVpTQmQxaVJQQmNtUlhFd1poaEJkaUFpSTBrNkI1Y2UzeE91U2N6MkxUc0Js?= =?utf-8?B?bit3dzUzS0xSSlAxMHVweXVEZCtpNUpKdTl0M0YrUDQ4S3l3WkNSWHJHa0o3?= =?utf-8?B?aGZkeTZiR1BjTWhBYmpKYnc3eDFma1ZJZ0xGYTh5SEFic241Qzkra1VGd1pT?= =?utf-8?B?VjI2Zjh1TnJuaWhQUU1pMU1VUFZoZjhBMG1nVTFyMm9heUpkbGlOdmJ3ejdW?= =?utf-8?B?SkgrTy9xVjhnNHFma3pWRlBQTFQ0aGdMSWxZTFgrYzhudFN6UUoxQzZpeSsw?= =?utf-8?B?Qzg5dGE4eHVkYkpoZ0ZjSmg3bWdtQ2dyUEU2NVFTZGlBK09wZENIQy9TZGd5?= =?utf-8?B?dHoveHBVWS9vd1hPTkxwWjEyb09hQ09YU2lOSDZqSlpkdUxEVkgzVlRubnRn?= =?utf-8?B?YXlvQkdZMU5NZHpWRzZOMExsWWtQWGN6ckVNSFpDY2svWFpLakFKT2xFdVN4?= =?utf-8?B?YldlSktxS3EvY3hMUW91VlRiVjd0WHNrT2tTMVR6Qyt5aWEyMmltdlRJZGlp?= =?utf-8?B?ekt2SWs4MXJRZFE5elFxWnR0T2tyL3gyNCszQWd1bzRGc3ZWaU01RUlDajU5?= =?utf-8?B?RmZKZk1OK2tHSUtyc1creVpoTkJKMEZ0bElRMVU4S1prd3FBcTVXVlJRaUR6?= =?utf-8?B?cUpBN1Z2RThIcExLU1lObzh3QjBKMzlGelpVWHJmdVBRRnRnbzdseDdTdEY2?= =?utf-8?B?ZjBEdXNkWG1XekovZWRwRytwMTRwZGI1bnFLVllVSm5KemIybEVSSkpPOEFJ?= =?utf-8?B?WnZhWllBeDV4VUVldHEyNzFINFBITkxYY0cybVpPTVQyNXJzbXdtN05XOWkw?= =?utf-8?B?SmJJdHM4UGUxbmNmaVFUSzhiNWFpVWlCTHhraUtlV2dZQ201NGVDRUp4NVFs?= =?utf-8?B?RFlKZ0twWTlRa1NHRVUyaDdVR0NXeHNIQ1F4TUVnQmpvSExvMzZRcGVIcjFO?= =?utf-8?B?ZGZVWEdwdVRaYmJ1cHF2RHh6MzhFNVlOTHBkTHpDcjVkaGFKRTlYN2dtQ3dU?= =?utf-8?B?MEJCb3lFamhwZnY1RUp6Rm9iOXM5ZVErZnUzNnVuOWNNUVlQaDIreEgvRms5?= =?utf-8?B?V2JYM2FJODRxUVZkU1FVOHVpOXFYSFNuaWpwNDQrYncrZkw0Q0VUbnNmaEVi?= =?utf-8?B?eGk3OHVuQWlTWEc4Vy9Ib0gxM1FLMTJaSlNGSVdaVUJqb3N2OEpqMzdKUHpy?= =?utf-8?B?K3dCSHg5aXdpQ29RbHp5VFdXK0tKakdDRi9mWlhRVFFCVG5LaEZTelpLTDd4?= =?utf-8?B?K2Y0TjFYVkRLTER3Z1NKYXlXMStHY0ZCT2RSN21xZCszYStjNFhkWFRCSUE4?= =?utf-8?Q?mXM56Z+4zfkpS7OHDP9d8NRmq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ec1013-0e84-4e38-9652-08dc2bd4ed21 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 14:14:29.3322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U0FvOT+sM+VHrT4/fqYNwgzAWsGKC6RKojJN5cyfghI+Hh9Zt5/T6Rm2HNbUBQJ/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5610 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/11/2024 9:30 AM, Gregory Etelson wrote: > Template table creation API sets table flows capacity. > If application needs more flows then the table was designed for, > the following procedures must be completed: > 1. Create a new template table with larger flows capacity. > 2. Re-create existing flows in the new table and delete flows from > the original table. > 3. Destroy original table. > > Application cannot always execute that procedure: > * Port may not have sufficient resources to allocate a new table > while maintaining original table. > * Application may not have existing flows "recipes" to re-create > flows in a new table. > > The patch defines a new API that allows application to resize > existing template table: > > * Resizable template table must be created with the > RTE_FLOW_TABLE_SPECIALIZE_RESIZABLE_TABLE bit set. > > * Application resizes existing table with the > `rte_flow_template_table_resize()` function call. > The table resize procedure updates the table maximal flow number > only. Other table attributes are not affected by the table resize. > ** The table resize procedure must not interrupt > existing table flows operations in hardware. > ** The table resize procedure must not alter flow handlers held by > application. > > * After `rte_flow_template_table_resize()` returned, application must > update all existing table flow rules by calling > `rte_flow_async_update_resized()`. > The table resize procedure does not change application flow handler. > However, flow object can reference internal PMD resources that are > obsolete after table resize. > `rte_flow_async_update_resized()` moves internal flow references > to the updated table resources. > The flow update must not interrupt hardware flow operations. > > * When all table flow were updated, application must call > `rte_flow_template_table_resize_complete()`. > The function releases PMD resources related to the original > table. > Application can start new table resize after > `rte_flow_template_table_resize_complete()` returned. > > Testpmd commands: > > * Create resizable template table > flow template_table create table_id resizable \ > [transfer|ingress|egres] group \ > rules_number \ > pattern_template [ pattern_template [ ... ]] \ > actions_template [ actions_template [ ... ]] > > * Resize table: > flow template_table resize table_resize_id \ > table_resize_rules_num > > * Queue a flow update: > flow queue update_resized rule > > * Complete table resize: > flow template_table resize_complete table > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam > Hi Gregory, Thanks for the documentation improvement, As the APIs are documented well and they are experimental, this enables to properly understand and improve them when another vendor implements them, I think this is good enough to prooceed with the APIs. I have two more clarification requests, can you please check them below? <...> > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Following table resize, update flow resources in port. > + * > + * @param port_id > + * Port identifier of Ethernet device. > + * @param queue > + * Flow queue for async operation. > + * @param attr > + * Async operation attributes. > + * @param rule > + * Flow rule to update. > + * @param user_data > + * The user data that will be returned on async completion event. > + * @param error > + * Perform verbose error reporting if not NULL. > + * PMDs initialize this structure in case of error only. > + * > + * @return > + * - (0) if success. > + * - (-ENODEV) if *port_id* invalid. > + * - (-ENOTSUP) if underlying device does not support this functionality. > + * - (-EINVAL) if *rule* cannot be updated. > + */ > +__rte_experimental > +int > +rte_flow_async_update_resized(uint16_t port_id, uint32_t queue, > + const struct rte_flow_op_attr *attr, > + struct rte_flow *rule, void *user_data, > + struct rte_flow_error *error); > + > If one ore more flow failed to update, for any reason, should user retry the update (in that case we need a retry error maybe) and can user still call 'rte_flow_template_table_resize_complete()' (for possible next table resize operation)? Can you please clarify this in your document. When user calls update() with a flow from new table, API should ignore it and return success, you mentioned this is what mlx implementation is doing, what do you think to make this as default API behavior and document it in above API documentation? > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Following table resize, notify port that all table flows were updated. > + * > + * @param port_id > + * Port identifier of Ethernet device. > + * @param table > + * Template table that undergoing resize operation. > + * @param error > + * Perform verbose error reporting if not NULL. > + * PMDs initialize this structure in case of error only. > + * > + * @return > + * - (0) if success. > + * - (-ENODEV) if *port_id* invalid. > + * - (-ENOTSUP) if underlying device does not support this functionality. > + * - (-EINVAL) PMD cannot complete table resize. > + */ > +__rte_experimental > +int > +rte_flow_template_table_resize_complete(uint16_t port_id, > + struct rte_flow_template_table *table, > + struct rte_flow_error *error); > If 'rte_flow_template_table_resize_complete()' fails, can application call another resize()? Is this managed in the application level or driver level (by returning error to next resize if complete() is not successful)? Is it something to clarify in your document?