From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DC834596C; Thu, 12 Sep 2024 11:18:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D10E427A9; Thu, 12 Sep 2024 11:18:49 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id E67F7427A1 for ; Thu, 12 Sep 2024 11:18:47 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4X4Bh53xVKz1xx8l; Thu, 12 Sep 2024 17:18:45 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 949D81A0190; Thu, 12 Sep 2024 17:18:46 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 12 Sep 2024 17:18:46 +0800 Message-ID: <7c5d74b1-2d69-4595-b966-4044b6f7c698@huawei.com> Date: Thu, 12 Sep 2024 17:18:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface To: WanRenyong , Stephen Hemminger CC: , , References: <20240911020740.3950704-6-wanry@yunsilicon.com> <20240910205058.25bf5f8c@hermes.local> <8cf9b5e8-cab4-45e6-b959-1d87f8a8ea99@yunsilicon.com> <20240911225021.16839cb2@hermes.local> <1ff7f17e-181b-49da-8f84-bf430f449dec@yunsilicon.com> Content-Language: en-US From: fengchengwen In-Reply-To: <1ff7f17e-181b-49da-8f84-bf430f449dec@yunsilicon.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/12 16:19, WanRenyong wrote: > On 2024/9/12 13:50, Stephen Hemminger wrote: >> On Thu, 12 Sep 2024 12:14:08 +0800 >> "WanRenyong" wrote: >> >>>> >>>>> +}; >>>>> + >>>> Does this device driver depend on some upstr >>> Yes, it depends on linux kernel driver of the device. >>> >>> Hello, Stephen, >>> >>> Thanks for your review,  please see above. >> What is the driver? I don't see in the current kernel.org tree. >> >> >> My concern is that if the driver is not upstream, it is probably not >> going to pass the review of kernel developers. This means security and >> API changes would be required. >> >> Ioctl's are considered the worst API to the kernel and unlikely >> to be accepted. > > Hello, Stephen, > > Thank you for reply.Our kernel driver is being prepared to open source. > > Our PMD is going to coexist with kernel driver to support flow > bifurcation feature. It seemed uacce bus could handle this, so that you could use several queues on DPDK, and steer flows to these queues by bifurcation feature. > > Ioctl API is used for interaction between PMD and kernel driver. As you > said, ioctl is > > the worst API, should I consider using read and write instead? It seemed the ioctl couldn't handle VF located in VM, and interact with PF driver which run in host kernel. > > If not, could you please give me some advice? If your NIC support firmware, could consider use firmware as mid-man between DPDK and kernel. > >