From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D489A0093; Tue, 19 May 2020 13:31:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D4341D5D1; Tue, 19 May 2020 13:31:12 +0200 (CEST) Received: from qrelay5.mxroute.com (qrelay5.mxroute.com [172.82.139.5]) by dpdk.org (Postfix) with ESMTP id 5BD461D171 for ; Tue, 19 May 2020 13:31:10 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay5.mxroute.com (ZoneMTA) with ESMTPA id 1722cb398a3000add6.001 for ; Tue, 19 May 2020 11:31:07 +0000 X-Zone-Loop: aa24d1d09b99b40b0db6ee016c2e35e441ef9a65ed1b X-Originating-IP: [168.235.111.26] Received: from galaxy.mxroute.com (unknown [23.92.70.113]) by filter003.mxroute.com (Postfix) with ESMTPS id B0D3961075; Tue, 19 May 2020 11:31:01 +0000 (UTC) Received: from [192.198.151.44] by galaxy.mxroute.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1jb00i-0003qw-HS; Tue, 19 May 2020 07:02:12 -0400 To: Hemant Agrawal , "dev@dpdk.org" , "david.marchand@redhat.com" References: <20200514132533.13752-1-hemant.agrawal@nxp.com> <20200515094752.28490-1-hemant.agrawal@nxp.com> <20200515094752.28490-5-hemant.agrawal@nxp.com> <5e359f5c-eb4f-7fde-77d2-636c0643e6ef@ashroe.eu> From: Ray Kinsella Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <7cbbd46e-5c60-4adf-5821-3dc94fe17871@ashroe.eu> Date: Tue, 19 May 2020 12:30:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v8 04/13] mempool/dpaa2: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/05/2020 12:16, Hemant Agrawal wrote: > >> On 15/05/2020 10:47, Hemant Agrawal wrote: >>> This patch moves the internal symbols to INTERNAL sections so that any >>> change in them is not reported as ABI breakage. >>> >>> Signed-off-by: Hemant Agrawal >>> --- >>> devtools/libabigail.abignore | 8 ++++++++ >>> drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 6 ++++-- >>> drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 1 + >>> drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 9 +++++++-- >>> 4 files changed, 20 insertions(+), 4 deletions(-) >>> >>> diff --git a/devtools/libabigail.abignore >>> b/devtools/libabigail.abignore index ab34302d0c..42f9469221 100644 >>> --- a/devtools/libabigail.abignore >>> +++ b/devtools/libabigail.abignore >>> @@ -55,3 +55,11 @@ >>> file_name_regexp = ^librte_bus_fslmc\. >>> [suppress_file] >>> file_name_regexp = ^librte_bus_dpaa\. >>> +[suppress_function] >>> + name = rte_dpaa2_mbuf_alloc_bulk >>> +[suppress_variable] >>> + name_regexp = ^rte_dpaa_memsegs >>> +[suppress_variable] >>> + name_regexp = ^rte_dpaa_bpid_info >>> +[suppress_variable] >>> + name_regexp = ^rte_dpaa2_bpid_info >> >> Is there a specific reason you are using name_regexp here. >> There is only a single variable involved in each case - would "name" not work >> equally as well? > > [Hemant] I remember getting some errors in case of variables. But now name is also working ok. > So, yes, name will also work in this case. > If I need to do a next version of this series, I will improve it. Is that ok for you? yes - that is perfect, I will give one more look over then. > > >> >>> diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >>> b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >>> index 9eebaf7ffd..89d7cf4957 100644 >>> --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >>> +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map >>> @@ -1,8 +1,10 @@ >>> DPDK_20.0 { >>> + local: *; >>> +}; >>> + >>> +INTERNAL { >>> global: >>> >>> rte_dpaa_bpid_info; >>> rte_dpaa_memsegs; >>> - >>> - local: *; >>> }; >>> diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h >>> b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h >>> index fa0f2280d5..53fa1552d1 100644 >>> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h >>> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h >>> @@ -61,6 +61,7 @@ struct dpaa2_bp_info { >>> >>> extern struct dpaa2_bp_info *rte_dpaa2_bpid_info; >>> >>> +__rte_internal >>> int rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool, >>> void **obj_table, unsigned int count); >>> >>> diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map >>> b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map >>> index cd4bc88273..686b024624 100644 >>> --- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map >>> +++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map >>> @@ -1,10 +1,15 @@ >>> DPDK_20.0 { >>> global: >>> >>> - rte_dpaa2_bpid_info; >>> - rte_dpaa2_mbuf_alloc_bulk; >>> rte_dpaa2_mbuf_from_buf_addr; >>> rte_dpaa2_mbuf_pool_bpid; >>> >>> local: *; >>> }; >>> + >>> +INTERNAL { >>> + global: >>> + >>> + rte_dpaa2_bpid_info; >>> + rte_dpaa2_mbuf_alloc_bulk; >>> +}; >>>