From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 545E343884; Wed, 10 Jan 2024 16:48:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 279684025E; Wed, 10 Jan 2024 16:48:26 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 8FB5E4021E for ; Wed, 10 Jan 2024 16:48:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iSBeLR1JQLBvUU/ZzWLOvZnMdnHTAEdit9Sgf2Efam6xpXbwSyXgCGYV0/npjZ/GvBEaVDU2B/7VH9KYZWnRDOvTX65eA9fII1GuGm891VmIfJjGtan96XA6IeFjH4jx4VudvoHXVOp50Ng5HRe+XE5r7fObcDbKHu7WYVlHliIZbhnLbZMfI3itWZQWddjHb5/6iRQIlbbwv5bxcAa0g3vGbkV78/cXZjSxPSHGcetzPYkWL5pf3OyoPEzS8alUKuYoeOfoKcAr+KK5YcmUyK61/oP8T72AeLEeCrp25UibBCeL8lOZXIa48uJFp0snLYkjo92R53YD2YkMkxN3Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=87IvlmpawAkwSIA8pv9V29pUxfnJp27YBKMAoPpZfks=; b=H85507K4EDEX6Ts01FMik2aodLbQgaw2BSZ0gJSZFS0bL7le/UeKsOnVUeSbKuNQB4A+CzuJi2yLOAWg5+rr+aU8SWRfgweXbnjqDkYJ/hGjZOvoi7YFNBCM6ZlarPtIBe4UuKMvUj0j5GlUXuv4BA/mGdCzP+CgziYo1RGhR1qY4XnOizbvCOSr1m9wOk3i9BmNuoTMkNWYzV98Hm39KYULaVBBDk4PsMXpHwm2d/2bijczaXIb/hcjsAC7ePb0llQgMiHx6wR+tog1//GVUdhjz9Ji3+I00En8z00INNPabRSMFlLJhbXSU9xDPto+UF4GXLxDT5iVS+m2q88GuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=87IvlmpawAkwSIA8pv9V29pUxfnJp27YBKMAoPpZfks=; b=1Uxjna7NQ/GgdYe0OVSELSKP6Kscg3oH8HkQuGt20Y+cRycGLN8Oy3/YzUWnPloJzGRh0iJd3TYrJFJdiF+tcUBSXiO56eLjOGBS8gf+/wiNnKV/70lsU5aFsGyPdQz3U0k4+OeKmWfpvDTkjBCykWU0uh3/7zTmTc8v2UrbO6Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5039.namprd12.prod.outlook.com (2603:10b6:5:38a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.18; Wed, 10 Jan 2024 15:48:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7181.018; Wed, 10 Jan 2024 15:48:22 +0000 Message-ID: <7ce104a6-de87-47e0-9ef3-b4c28434e8af@amd.com> Date: Wed, 10 Jan 2024 15:48:16 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: add dump regs for telemetry Content-Language: en-US To: Thomas Monjalon , fengchengwen , Jie Hai , dev@dpdk.org, Andrew Rybchenko , Bruce Richardson Cc: lihuisong@huawei.com, liudongdong3@huawei.com References: <20231214015650.3738578-1-haijie1@huawei.com> <1dfc96a4-9471-4f2a-a835-72da95e6273e@amd.com> <2632983.tIAgqjz4sF@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <2632983.tIAgqjz4sF@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0216.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5039:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d274425-f87d-4f44-130b-08dc11f39338 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e0Pk9b5Aw6gQ8if1dJ1hGTOwml2Pk8aeyB304rC98BDd2hHS50ztU5v1yVpjgm3mb0yyRfVE+DUwM0/35tkD+f2DR5/D7uYR/45RL2zM9hdQ3PxVIrjet4Vr/zXfiOIKUMIo3xzY9H0wsGk8C+1fV+ucl+qByMCEWrszOswy8g7yGDOUuJp+0yQBm39ggXAKxDrkhn/ZZ+R4aHaAY8P7Q6th+khqgRtFM/YuflgegqzRsRaqFU1afO5nNLlW8q/zY/MLbYq05im0eve1eC0EXLPhFoWQXiCw0smGrAR6zSIO7ojgqyEIJ69bqVMTRkFQ3yA/PiZ09AULINv0d9k5tsV1wZdK9bDXWM+R/ohgPob8siOH83slRoEbzCrnL9rVyvWptraj2mOxTTivEUQTqbd4Tu+qlOTjGKmLQytPi7Gj0sbh4jRaFakaARLNZtIVMIEmEUGdr+/Tv6FdBA7deqMUNtbfcjETPwpCwt0BH9fw8oYw1c5/gNozlNrViof3pxGjwINoCUNC/UfwMs3gTpVNoDMJNB2NWxTeVVfJARKefDTjbkGM+/pIo90Jv8Mhvyw48NyZ6TrYfJvlwMa7t3PVBiC9i55nHaWD0QQUx7UgxW9ay8fsfGkErsSJ0VprDrOB9+ESeGw8ajF2O2jWHA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(39860400002)(346002)(366004)(376002)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(31686004)(478600001)(6512007)(53546011)(6666004)(6506007)(2616005)(26005)(38100700002)(31696002)(86362001)(36756003)(4326008)(41300700001)(44832011)(83380400001)(5660300002)(2906002)(8936002)(8676002)(110136005)(66946007)(66556008)(316002)(66476007)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1YwS0k3eUMrdTNRTThva2xRdWpCV3Z4VUlNd3JoWEVHaHAvOW8weURNdUll?= =?utf-8?B?VE5ZZmpMcEd3VzRiR2tlblV1R2hxeFlMdmYxVzFCMkxRQjBVYVd3VDV1VUFq?= =?utf-8?B?Nmh1M1hqMWhvNXh2cGpDR0xrU0E1TEY1dGkwcm8zeXh0bmNYN3IvU3FhMTg1?= =?utf-8?B?cDI4R0dtNldzNXBHdzY3dlFaelUxdWhGVnZVL1A3Nk15SFh2cGRMYkFBbXRN?= =?utf-8?B?SmFlczR5SnNqdVphUENLWUZwNWtza0R3ZVdsSEsyNEkzRHdaUnhVczRzZmFl?= =?utf-8?B?RWtpWXE3K0RWRU13RC94emFvU3BiMEI3eEdjd2dja21hdnZtSDNnRzVKU2tk?= =?utf-8?B?NHlDZWRaSU9oQWNTLzd6T0RSUXV5a016STJuMkR6Qy9CZTJIa0V6Tkk2SzJa?= =?utf-8?B?UWUrTWlJUVZtSWc4Rk8vWDIxSG1EWVh3UER4VkxNUnRtNXg4b3RiQ1lOQTJZ?= =?utf-8?B?d0x1WkhLeThPMERvN21JUDRSdEZKcUlHa05lNlNQOEtsUHBIbmEyWU9tT0ZE?= =?utf-8?B?dm1MNGl5NTFGV2t6Q2xKc2YycGhvRy9FQUZSdU9JSVRVWFd6OEpWWWV3MWc2?= =?utf-8?B?LzZPMXRWVTZaS0RORGQ0ZnRhdlQ5a0dac09wc1lhd3FYRjB3ZnBLeCtvTWx1?= =?utf-8?B?eUpHQjRSMk9wRzBIS205eW5NeUI2UGZ6N2VreTJWcUpTWENGVVp4ZERiRkdm?= =?utf-8?B?cWFrQk8reEcrSGRENnZIQnFNNkRIQnlzb2QzRGpZTWlmMnU5bzM4TW9EYzE0?= =?utf-8?B?YkxJUWlsMVo5ck5NRnhCN3MxYk9xak9nU3hEVjFIK2Z6VXRna3lCOW84SlJu?= =?utf-8?B?S0x5alVGeHJjcmdPSFI0WTNPMHptQmJvcGNSdFNLc3VRZXpZdFhKb1JXUHMy?= =?utf-8?B?cmlJWWVJUE0vOFVtcWVsckR1RHpLRmtONE5YNjdGbDZSekcxK3dSOENEL0NM?= =?utf-8?B?cFlRQk00N1I0OWZvMGFKTjBWS1Byb1JlbmxkOHNaR2pkNUV2T2VzcXlFTm1o?= =?utf-8?B?WFBmVzl0S1dEdkx0Q1NOdkZ1dVhCZWZ3aUVmdWNLVUx6emZQb3phNkxmWDVr?= =?utf-8?B?eHdMc1VQOFNQazRlaTJQbXhuWjBnY0VlbklLbVN6aStYRm8rempOaHhnL3cz?= =?utf-8?B?MkE3Qk40b2JiQU1TUnRiK1ZVYXNiZ0VlYkphSWVGczFOc1RxUXhUL3hBekVM?= =?utf-8?B?QjYvSC9UR2htd2JtNDEvM3RpY3dTMUlhWHVRcnAyTGI3QTBTUTdnMjNrQkpS?= =?utf-8?B?akZFNHM4SjVPaFU4R2dDWDJUa2JqaDVDYVh1b0pZZlBrN1JOb283N3p3b08r?= =?utf-8?B?cCtxRlFmY3M0YXJ5V0o5d3k1UGRnV0RGSXFsdytnbnk5d0dVRmNOTkV5cllZ?= =?utf-8?B?anhyZ2Y2OTh6UTg5Yjh3MUVBMGtXUnIwajdvd0lKUlhTeW94VzRTNzRpU0lL?= =?utf-8?B?dUZCdnloZUpNcFRhQkNJQm9JczhuVWpuOFZuQSszV3dsNURrcTYyYWtWbEtx?= =?utf-8?B?NmJ5dzhGSmRlZ1E2Zk5Dd0dyRzJDbUc2K2lyK0s2NW1lTFNmYWxtdnZTMUcw?= =?utf-8?B?WlZYQ0NuemdUYnlTVUkzRUF5MVNXdUc5WWVnMVBkUGpRc2doVjlIQmxqYVpM?= =?utf-8?B?VnFjV0djL0pOdDVEQ0tZc00vbGNtcVdzNU9jZUtiODd4WWlLSkZSM3JqSDMy?= =?utf-8?B?VVBnWW92MmI3WXlRMlVJVmo2MTVwSE51ZEdwTHMydE9ia1ZuSGtNd1V3QU5M?= =?utf-8?B?Y09wQlZsZ0libmg2Y2JBQk10WnVqbkV5OHVPcHNVdzVZQnp0SnJjTjArcHlt?= =?utf-8?B?VGM2R3kzOHRldnhuNU1hazNnZFFydStGVFJ6WUJQbkhWTGhKQVJpMUcrbVZr?= =?utf-8?B?RXYrSFdzRXM0R2VncHZ2TXhQZzlwS3JiWDRXeXpETWZBMDl5YmsrQWtpb2Fo?= =?utf-8?B?NjkrdGxWcUZIQjhHeTVVQlZPU2IwZHgzUWNUeWdyYkZBUUZTWkhzenY0dUZ3?= =?utf-8?B?UTlxZzJiMVA1K1Frei9wdHZoZjgxeXROSUp3dmNZV2gvelpnbkVHUmo4dzlw?= =?utf-8?B?alU3RDZyaWFHTFNnVzdRdysrUnB6WXB0NEpLMnkzSEoyYVhhTm5FWUEwMi9E?= =?utf-8?Q?9VzrkPBJ9rmAY/OVmjQMrh8Wd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d274425-f87d-4f44-130b-08dc11f39338 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 15:48:22.7117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lZ+U0nlqwA5zlciTPwEJf79RsckV7Ccf/uAs7RH0NMeW68/7g8ySzos0uOSrFbcA X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5039 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/10/2024 2:09 PM, Thomas Monjalon wrote: > 10/01/2024 13:15, Ferruh Yigit: >> On 1/10/2024 1:38 AM, fengchengwen wrote: >>> Hi Ferruh, >>> >>> On 2024/1/10 2:06, Ferruh Yigit wrote: >>>> On 1/9/2024 2:19 AM, Jie Hai wrote: >>>>> On 2023/12/14 20:49, Ferruh Yigit wrote: >>>>>> On 12/14/2023 1:56 AM, Jie Hai wrote: >>>>>>> The ethdev library now registers a telemetry command for >>>>>>> dump regs. >>>>>>> >>>>>>> An example usage is shown below: >>>>>>> --> /ethdev/regs,test >>>>>>> { >>>>>>> "/ethdev/regs": { >>>>>>> "regs_offset": 0, >>>>>>> "regs_length": 3192, >>>>>>> "regs_width": 4, >>>>>>> "device_version": "0x1080f00", >>>>>>> "regs_file": "port_0_regs_test" >>>>>>> } >>>>>>> } >>>>> >>>>>> >>>>>> Above code writes register data to a file. >>>>>> >>>>>> I am not sure about this kind of usage of telemetry command, that it >>>>>> cause data to be written to a file. >>>>>> >>>>>> My understanding is, telemetry usage is based on what telemetry client >>>>>> receives. >>>>>> What do you think just keep the 'reg_info' fields excluding data to the >>>>>> file? >>>>>> >>>>>> .Hi, Ferruh >>>>> >>>>> I tried to write all register information to telemetry data, >>>>> but gave up because some drivers had too many registers (eg.ixgbe) >>>>> to carry. Therefore, the writing data to file approach is selected. >>>>> >>>>> When we query a register, the register content is the key. >>>>> The information such as the width and length is only auxiliary >>>>> information. If the register data cannot be obtained, the auxiliary >>>>> information is optional. So I don't think register data should be removed. >>>>> >>>>> In my opinion, writing a file is a more appropriate way to do it. >>>>> I wonder if there's a better way. >>>>> >>>>> >>>> >>>> Is there a usecase to get register information from telemetry interface? >>> >>> Among the available tools: >>> 1, ethtool/proc-info: should use multi-process mechanism to connect to the main process >>> 2, telemetry: easier, lighter load, and it don't need re-probe the ethdev in the secondary process, >>> and also cost more resource, like hugepage, cores. >>> >>> From our users, they prefer use the second 'telemetry', so I think we should move >>> more status-query-points to telemetry. >>> >>> As for this question, I think it's okay to get register info from telemetry. >>> >>> >>> >>> Another question, we have some internal registers, which: >>> 1. Is not suitable expose by xstats, because they may includes configuration >>> 2. Is not suitable expose by dumps, because this dumps is hard to understand (because it only has value). >>> >>> So we plan to add some telemetry points in the driver itself, so we could display them like xstats: >>> "xxxx" : 0x1234 >>> "yyyy" : 0x100 >>> >>> Will the community accept this kind of telemetry points which limit one driver ? >>> >> >> Hi Chengwen, >> >> I see there is a usecase/requirement. >> >> With this patch, even using file, only register values are dumped and >> isn't it hard to find value of specific register? >> >> ("xxxx" : 0x1234) approach looks better, but instead of making this >> telemetry support for specific driver, what about making it in two steps. >> >> First add new dev_ops, (or update existing one), to get registers with >> "name: value" format, (in a way to allow empty name), or even perhaps >> "name: offset, value" format. > > I'm OK to add an API for dumping registers, and guess what? > We already have it: rte_eth_dev_get_reg_info(). > We may extend it to query a subset of registers. > This patch already using 'rte_eth_dev_get_reg_info()', but issue is how it is used, it gets filename from telemetry and dumps registers to that file. >> And in second stage add telemetry support around it. >> (Name being optional lets us wrap exiting 'get_reg' dev_ops with new one) > > I am against overloading telemetry for debug purpose. > Reading some registers can be debugging or monitoring, I believe it is in the gray area. >> When adding dev_ops, it may get an additional 'filter' parameter, to get >> only subset of regs, like "mac*" to get regs name staring with "mac", >> this may help for the cases there are too many registers you mentioned. >> >> Anyway, we can discuss more about its design, but what do you think >> about first having a dev_ops for this? > > >