Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/16/2018 12:41 PM, Jeff Guo wrote:
> When compiling on FreeBSD, a warning/error is thrown for
> unused parameter. This patch aim to fix the issue by delete
> the useless func definition.

This function is part of the public API, so it should exist for FreeBSD, I think
instead of deleting the function we can add __rte_unused to parameters that are
not used to prevent build error.

> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
>  lib/librte_eal/bsdapp/eal/eal_dev.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/lib/librte_eal/bsdapp/eal/eal_dev.c b/lib/librte_eal/bsdapp/eal/eal_dev.c
> index 3a3a2a5..255d611 100644
> --- a/lib/librte_eal/bsdapp/eal/eal_dev.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_dev.c
> @@ -33,11 +33,3 @@ rte_dev_hotplug_handle_disable(void)
>  	RTE_LOG(ERR, EAL, "Device event is not supported for FreeBSD\n");
>  	return -1;
>  }
> -
> -void  __rte_experimental
> -rte_dev_event_callback_process(const char *device_name,
> -			       enum rte_dev_event_type event)
> -{
> -	RTE_LOG(ERR, EAL,
> -		"Device event callback process is not supported for FreeBSD.\n");
> -}
>