DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Hunt <david.hunt@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Hajkowski <marcinx.hajkowski@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	bruce.richardson@intel.com
Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com,
	andrew.rybchenko@oktetlabs.ru, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification
Date: Wed, 28 Oct 2020 13:53:47 +0000	[thread overview]
Message-ID: <7d202199-5edd-0278-c3f7-3dc34bbeb5e0@intel.com> (raw)
In-Reply-To: <3176678.oQ72JnNS2j@thomas>


On 25/10/2020 6:22 PM, Thomas Monjalon wrote:
> 29/03/2019 16:09, Burakov, Anatoly:
>> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote:
>>> 18/03/2019 12:56, Hajkowski:
>>>> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
>>>> --- a/doc/guides/rel_notes/release_19_05.rst
>>>> +++ b/doc/guides/rel_notes/release_19_05.rst
>>>> @@ -120,6 +120,8 @@ API Changes
>>>> +   * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions
>>>> +     have been modified to be thread safe.
>>> The deprecation notice was recently sent,
>>> so I guess this patch is for DPDK 19.08.
>> Yes, this is changing API so the target was 19.08. However, first patch
>> is a fix and can be applied to 19.05 as well. The API documentation
>> stated that the function was not thread safe, but the code itself was
>> thread safe (it wasn't because it was buggy, but the intention of being
>> thread safe was there), so this could be considered fixing docs to match
>> the intended behavior of the code.
>>
>>> Review from the maintainer (David) may help.
>>> Thanks
> What is the follow-up here?
> We still have an old deprecation notice:
> 	http://git.dpdk.org/dpdk/commit/?id=3477b7a2cc
>
> I wonder how such things can be forgotten.
> I feel some help is needed in prioritization,
> so let's consider this deprecation as the priority #1
> gating any other change in the power library.


Hi Thomas,

#1 is now done, I've pushed a patch removing the deprication notice to 
the mailing list, as the change it describes had previously been applied.
Patch here: http://patches.dpdk.org/patch/82327/


> Priority #2: cleaning up API which are secretly exported
> for example convenience. It is an old design issue never fixed:
> 	http://inbox.dpdk.org/dev/6046120.mQ0ExDuKPD@thomas/


Regarding the virtio channel API, Bruce and I had a look at this, and I 
think I need to do some more research into it. I'd prefer not to make 
that API public, as it was intended to be mainly for the 
vm_power_manager app and the companion guest_cli.

So I'll look into this, and look at the best way to proceed with 
cleaning this up so that these apps can be build using meson/ninja as 
part of DPDK, as well as using 'make' extrernal to DPDK.

I hope to push up an RFC next week so we can get agreement on the best 
path forward on this item.


>
> Priority #3: request feedbacks from other maintainers
> to add a generic API in ethdev to get a hook for power management.
>

Would it be possible to look at #2 and #3 in parallel? I'm not sure I'd 
have #2 done fully in time for this release, and, if not, I will make 
sure it's done for 21.02.


Rgds,
Dave.



  reply	other threads:[~2020-10-28 13:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 11:56 [dpdk-dev] " Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 2/4] power: return error in set env when power env already set Hajkowski
2019-03-18 11:56   ` Hajkowski
2019-03-19 10:57   ` Burakov, Anatoly
2019-03-19 10:57     ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 3/4] power: reset function pointers on unset env Hajkowski
2019-03-18 11:56   ` Hajkowski
2019-03-19 10:58   ` Burakov, Anatoly
2019-03-19 10:58     ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types Hajkowski
2019-03-18 11:56   ` Hajkowski
2019-03-19 11:58   ` Burakov, Anatoly
2019-03-19 11:58     ` Burakov, Anatoly
2019-03-18 15:01 ` [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification Stephen Hemminger
2019-03-18 15:01   ` Stephen Hemminger
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-19 10:57   ` Burakov, Anatoly
2019-03-29 14:14 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-29 14:14   ` Thomas Monjalon
2019-03-29 15:09   ` Burakov, Anatoly
2019-03-29 15:09     ` Burakov, Anatoly
2020-10-25 18:22     ` Thomas Monjalon
2020-10-28 13:53       ` David Hunt [this message]
2020-10-28 14:16         ` Thomas Monjalon
2019-04-05 14:35 ` [dpdk-dev] [PATCH] " Hajkowski
2019-04-05 14:35   ` Hajkowski
2019-04-22 20:22   ` Thomas Monjalon
2019-04-22 20:22     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d202199-5edd-0278-c3f7-3dc34bbeb5e0@intel.com \
    --to=david.hunt@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marcinx.hajkowski@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).