From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D5C6A04DD; Wed, 28 Oct 2020 14:53:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D40F8CACF; Wed, 28 Oct 2020 14:53:55 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3736DCAC8 for ; Wed, 28 Oct 2020 14:53:53 +0100 (CET) IronPort-SDR: LVjkIS35EsfHyFTZGh4mDaLltXQ/Yp59J41z3xPrRjjB0jE6sovotjWeaPKpDe0HpF3BWfGB8L PFpzp1SP+d8w== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="148114831" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="148114831" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 06:53:51 -0700 IronPort-SDR: Y9mhnhJaawGCpXeKSlTDT9RAbYyF19KqH75Pl6Z+MvDruh4sIbc9+SGsH7mQqIv3pcGuNAQC4l NXXhtcqw8OeQ== X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="536237573" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.225.187]) ([10.213.225.187]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 06:53:49 -0700 To: Thomas Monjalon , Hajkowski , "Burakov, Anatoly" , bruce.richardson@intel.com Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, john.mcnamara@intel.com References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <3804007.JU0OzdjkKo@xps> <3176678.oQ72JnNS2j@thomas> From: David Hunt Message-ID: <7d202199-5edd-0278-c3f7-3dc34bbeb5e0@intel.com> Date: Wed, 28 Oct 2020 13:53:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <3176678.oQ72JnNS2j@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25/10/2020 6:22 PM, Thomas Monjalon wrote: > 29/03/2019 16:09, Burakov, Anatoly: >> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: >>> 18/03/2019 12:56, Hajkowski: >>>> From: Marcin Hajkowski >>>> --- a/doc/guides/rel_notes/release_19_05.rst >>>> +++ b/doc/guides/rel_notes/release_19_05.rst >>>> @@ -120,6 +120,8 @@ API Changes >>>> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions >>>> + have been modified to be thread safe. >>> The deprecation notice was recently sent, >>> so I guess this patch is for DPDK 19.08. >> Yes, this is changing API so the target was 19.08. However, first patch >> is a fix and can be applied to 19.05 as well. The API documentation >> stated that the function was not thread safe, but the code itself was >> thread safe (it wasn't because it was buggy, but the intention of being >> thread safe was there), so this could be considered fixing docs to match >> the intended behavior of the code. >> >>> Review from the maintainer (David) may help. >>> Thanks > What is the follow-up here? > We still have an old deprecation notice: > http://git.dpdk.org/dpdk/commit/?id=3477b7a2cc > > I wonder how such things can be forgotten. > I feel some help is needed in prioritization, > so let's consider this deprecation as the priority #1 > gating any other change in the power library. Hi Thomas, #1 is now done, I've pushed a patch removing the deprication notice to the mailing list, as the change it describes had previously been applied. Patch here: http://patches.dpdk.org/patch/82327/ > Priority #2: cleaning up API which are secretly exported > for example convenience. It is an old design issue never fixed: > http://inbox.dpdk.org/dev/6046120.mQ0ExDuKPD@thomas/ Regarding the virtio channel API, Bruce and I had a look at this, and I think I need to do some more research into it. I'd prefer not to make that API public, as it was intended to be mainly for the vm_power_manager app and the companion guest_cli. So I'll look into this, and look at the best way to proceed with cleaning this up so that these apps can be build using meson/ninja as part of DPDK, as well as using 'make' extrernal to DPDK. I hope to push up an RFC next week so we can get agreement on the best path forward on this item. > > Priority #3: request feedbacks from other maintainers > to add a generic API in ethdev to get a hook for power management. > Would it be possible to look at #2 and #3 in parallel? I'm not sure I'd have #2 done fully in time for this release, and, if not, I will make sure it's done for 21.02. Rgds, Dave.