From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0047.outbound.protection.outlook.com [104.47.34.47]) by dpdk.org (Postfix) with ESMTP id E4DD41B19F for ; Tue, 26 Sep 2017 13:15:10 +0200 (CEST) Received: from BN3PR03CA0053.namprd03.prod.outlook.com (2a01:111:e400:7a4d::13) by DM2PR0301MB0734.namprd03.prod.outlook.com (2a01:111:e400:3c0d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 26 Sep 2017 11:15:08 +0000 Received: from BN1AFFO11FD022.protection.gbl (2a01:111:f400:7c10::125) by BN3PR03CA0053.outlook.office365.com (2a01:111:e400:7a4d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Tue, 26 Sep 2017 11:15:08 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD022.mail.protection.outlook.com (10.58.52.82) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Tue, 26 Sep 2017 11:15:07 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8QBF5ne017213; Tue, 26 Sep 2017 04:15:06 -0700 To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-3-shreyansh.jain@nxp.com> <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com> <7cf232e2-000a-85f4-2628-2945e1e7ddb1@nxp.com> From: Shreyansh Jain Message-ID: <7d208a89-62ae-d0de-d5b0-dbaf0b73fdb8@nxp.com> Date: Tue, 26 Sep 2017 16:56:00 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131508981081523560; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(346002)(39860400002)(376002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(377454003)(189002)(24454002)(199003)(305945005)(85426001)(105606002)(81166006)(2870700001)(8676002)(65956001)(8936002)(47776003)(65806001)(31696002)(93886005)(77096006)(31686004)(8656003)(498600001)(86362001)(2906002)(36756003)(104016004)(58126008)(316002)(4326008)(97736004)(50466002)(64126003)(5660300001)(6916009)(81156014)(68736007)(229853002)(2950100002)(65826007)(189998001)(23676002)(54906003)(83506001)(53936002)(6666003)(53546010)(356003)(6246003)(33646002)(76176999)(54356999)(50986999)(106466001)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0301MB0734; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD022; 1:mVXQM7t1cA/oJMtHuo3QamPC7Miu42FV9vvgBBys/VspODjxMC2wGl461Opyeq+3432OLxkRBf4zBm6jthd4DGddj7hcEquwWH7r/uXdqQ3HEB0cUU/E/htVLSaD6LWm X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d2f5263-c33f-462a-e40b-08d504cfd897 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:DM2PR0301MB0734; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0734; 3:kKQC5cMqessmb4nmDvzAWH8+OmjuwSoKolZoYeZ6WWXQmzuBarsZPkKmnD0bU9uLIHaDwGEZ0VnQOobEda5CteOESjymicO1prYWWcx8tN95d9teQaWbt3wNxA7wRDt3pcvm61BZfz1qlkwunwTAy1tmTedwo5sFWm+pDwcvCa5z8ccGBjVny5Ka153eIGhbwzX7eTnU3+G9lptO7u4eWapKmgktq9fpigb4YSHWogK0bIXjRuZtH9J/qP20RWkFwB62huMXDvZTUggaH08lYTBEG/qMdLps/jaltPmyl4cqKme9eCdRVCqzNJYqL2T5L5+3nM0rWsW8yxofoTUJ56IJjeVJO/mpWbF2q+RPeY0=; 25:XSRchl3wQYHgW6A/wrocXszhL9ceQfmW7LX3yxTGl+sjL0PVAND/iXkAU+KysPknc+hEpjXRqdFD54ihiy7k2QltfQcQEtZWMPB6TQGGzL0qBuQeM0XV6zmdfCzGe5hryXrN9+vQZf4j7P0X6HtFXue1k8rCHd5o//iz+N7ZZPvIUBciDfqcMy0N1Vu8VnrU2HaBH8W4SVPGa9GUJKayv8+bjvE9UPehSsYWKr+hf8lDWazsqjfanLNusVm+oyvytWGfl+6ybok+JCN7sMquMlb8yWJTSAW1i0J7Oph5SlYbxnennqYhCSmmv4NiQXmiAKGx+dRuc7chU54gjBl9QM36vl9ZfMlTmz9yASRngMA= X-MS-TrafficTypeDiagnostic: DM2PR0301MB0734: X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0734; 31:He+d0a5XKu45ioWNMDEtEO8hxKWmgaugO9xhCAqvoHZPGBRQvCc98rkzcsT0Qqsl3uz1z8gkvJ+7d44HsDE4ya1kmB5yYiPnbe0oLVS5gVbY+yopQk2aB8pTrT6glB9nYZDgaTvEeXjjBCiukomDyFEuHKNnkXAydDTMdTkZv0Z79vpkeJ9voyi+lFMsux+ozhdBijiwk9rg+KGPuFSIOssUveoY5JStDT0NxA2INeE=; 4:Lo899kU+X9fK+w7g89tC8+47jKTv0EEN/TPa/u54BEJWP58fp9AnxP3e4fZN+XBXhKE3we+A5TiHo9k0BMKS3aBBN+RZX5BPrhQ04mR7vo09IhnApadMixQfIeMTmxe3ZnC6pfJPWeA/SEpU/uVmpGAKn3u2/XAgMtLdajo/NGN+3SsHtIPqu8Vts7uhpQQ+XYM9kHE6VLTaUP5KRAqoYbNiDd5bSGs1pPKHSYZ/+ZyDE3wIv3PMetB4DgkgbUpAFMeTfZsmg2jaPNjY+0EqReZ4k+QLfpEqTVrEpgTeDH4= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6096035)(20161123565025)(20161123563025)(20161123561025)(20161123556025)(20161123559100)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM2PR0301MB0734; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM2PR0301MB0734; X-Forefront-PRVS: 0442E569BC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA3MzQ7MjM6OEdxZ2xTbkV2MTZCQkFJaGlTaVJKVVRY?= =?utf-8?B?RWlXdUdNN3JDckVEbTY2WXN5NnF4Z0kvRDJxVEs2L01ta3FSNmVCSFhvUXQ5?= =?utf-8?B?RGJOT2tvcWxEdVVkNU9MVlhrbFpnU000NHhGNXQrMEdlSXBybUNuRm4vc1FC?= =?utf-8?B?MTN0RGpabHp5anVleWVIbDloWmFKNXZlTmZLSUlDQVUrZ2pBVXNZNnFFSWIw?= =?utf-8?B?ckt1aUVwdUIvK1o3Q3RkZHAvZFNldXVBZ3IvQXVYQUt5UUFrQnAvN2xUT1Vu?= =?utf-8?B?Y293a3VkUmpnVXltNllvMWg3NlAzR0ZBWW5WMUJWZTBVT01uUnNhcFFTYURs?= =?utf-8?B?cVNVOEZNdGwwUGtYaTBIRlVKcW5iVThBc1BzMXNqaytWVlRCenl2MnVqRmhV?= =?utf-8?B?Y3psYUhhMlgyaS82d0hHR04vVXBiSlhQNEVRSEt0UnNPcThYRXBiaHl6cXUz?= =?utf-8?B?R25jN0NLNGhsNUxBdXpGQWNzNU04UkN1Vkc4WkdPeUNhbFh0T3JnUWhFNUFm?= =?utf-8?B?QVQxTXpJZUpBNEh2KzdNSEdqaWlMMDdMREFuREpIMmliM1NWb3oyR3lSQnhT?= =?utf-8?B?YVcvN3IvUkhzOU94ZmcrNzNDWXoycjBZZ1FmZCs2aXNCS0dPWkx0SWx3VlNy?= =?utf-8?B?TEtHS3lMM3lMT2ovTHBPbDRNaHRCSjFjYnZSRFE4K1RxbTd2djBQQ0hVN1p2?= =?utf-8?B?YmhvaEYrWWF3K2M3eUFHSGFUSlpGbkJUdXF5ZXRCb1FPV0ZnUGFWaHRobVRU?= =?utf-8?B?WHUxNlRsNFBSdVpHSVpKN2Fwa3dBQUNPc0tUb0Z2QUd0VXdndVdmZnlLamJC?= =?utf-8?B?ZUU0R1IzY3h0V0hMWGF6OGNtS2JyWDQvL1FJMjBVSnRPYXRtZUxMd09kaDMw?= =?utf-8?B?QlgzZFNnK0IzcEhkQXBFRHVaOGdHOTQ4SDEvenpCSk1MS000RVFSNndxQjNX?= =?utf-8?B?VzVoMHd6WjlQLzQxNFpVQjdFejRFdnFnajJRWnRYSS9KaFVMWldzRFFJSEhT?= =?utf-8?B?eVA1SUI1NUtMNHFpK01FZXFnUW9PREhUNC81RkxvZElUK0tlWDYrZ0F1T3dJ?= =?utf-8?B?ZXdEYXB5NkcybksyU0VGZFJTZks3ZllENHpQZXV5dEZ2cEljRmxWWUhQeGVY?= =?utf-8?B?bUh5b0xRVVhNUVdmTWUxN29aYXZUUlB4U2gvNnQwTk9hMlVNdk1DbHBpbm1M?= =?utf-8?B?MlAzRDRKdGpMYWFpYzBnNnhFdFNNWHh1UlVKTzJ3TUhVcWtZbk5hWC9YZ2dJ?= =?utf-8?B?MlBwd2RzZWFMeUplY0J0NkdNZk1DN0U3anI0a1JkdHZ1MjU4TVVWZ0lJcDNQ?= =?utf-8?B?LzV2OUMvbzc5MEZqTHE5RzBORCs0WlBvbDBxbkRXWDhPYXZ2OHBORVBEalpO?= =?utf-8?B?UTR5WDJBcVEyY1JpMW13TUZiNXBGdk1mWjI5dkVEeXlpN0I1a2dEc3RBNGJp?= =?utf-8?B?L1lvVzRVZUpxNEN6NVVrTk05LzM2dVo4eWs0YWZpRmIrUVlVd2UxWVpMdnZJ?= =?utf-8?B?d3IwZDFsd3pUcnk2WnZvVS9OVms4ZFd0bFU3TXoyUXM3WDZ6R0FvMUYraHNZ?= =?utf-8?B?MzFhamxuMEJET2NybVlOZS9reG9OR3luY1dNemFJYTBnSDFuK1RxS2J3UjFU?= =?utf-8?B?eEQ4UnhrWUY1TlRJN0p4TlBINnBsTU1BcHlOak1lSGR1TytWSUtqQnIzTVpX?= =?utf-8?B?NlBGVEFIbzNWYlprb3ZmdnlGaHI5OWhmNTFkQ2NJMlUycXBJd0k1blBWUDlW?= =?utf-8?B?T1lYM25tU1ZVWWlRbVhXYTl1NGdxOGRSeStIcXRKb1gyNEY1ajdkSHlMci9V?= =?utf-8?B?TzlTRHhiMk5NSFVsSWp6S08rNE1mVVlzUkloNlhJTlhDUEFKdkhXUUtwbEdh?= =?utf-8?B?cnpRYWcvZlo3UDlXczV3ZDZDK3ZrNW8rellyU3JvTzVaMU9sQ1dwS2pRTW1m?= =?utf-8?B?MnVTNnZaSWE3RTNjcVB5NGpjWHJmVkVqT1RWSHkxajdBZWlZNnhkK1ZEMHBt?= =?utf-8?B?UldHNEltanp0b09taUdockJWYXkvdERsa2t0Uit3PT0=?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0734; 6:FD1SBMPdVH780n+Az+CD9T0N3oAN9rAhpbRKsen8Ws22cbMC107dkhoD157HYjzWCc3CO0IBGFlk7gcM0kAbfQd/w40HnuKzT2oV0BolSYnzH5xi/kr1R/NJ86QDXl79cWhCs1cKCPlOigM9A9kg1NoP+2i3SlZgVMvZe6EE8O55iqQ2DvuFxngQdTP/hEQTvHdn9E2RToBuzmnrfAOXP1l/JkrvY/Tsq5BOhDy99mpc4mtKo570bbPUd8Chacjjy8t6I+P8o+Cvn/p3E8zGNMtiOMJdoaKAm/GqxHfa9jAgxeL/T7uBj62idp35lT54a5HzsUMJ+X/VjwM6ovlIaA==; 5:LDW4C/UMSTCYrSc1ctvxvFU+n70ABSSWVpRkS8uUU5VLsis7HeRNL7YzZVNzpKj3AycUETvbNTiasxsinYvN5kM2HgoW8/ZacccZPLGI5snoda216w1BzWoyWX4wqVu5beHEkNFcN0rC3YG4YqhWQw==; 24:9UwnAd9tUfoeI/Z8v4wDrOjL+cBSdJqBhY/imIK2k9ozw8U+6sPrsWkOZbZAYdiCDFJWZfipEcD1A3iyXZSQhxuCA4G8/4IUUoSPUXmIxVg=; 7:7eoh7hOubgk2dyO67OxD3bKXkaFyCbIvQvA1B/AkxoZgaLZyQD/312G/E8rxvtdmuQONUPfEXmxCrKwYsDHHCm1fz1VJLMKWfgbqsuuBCTGtZsseC508Y1bmuZ1+UkQW5PCGsxJRdcJgEWli4V6qOua/hW3/pgoQXY65cvbjuvw1TO5xJfDaGwb28ULsOYSeFmTovzLt9ks+dD4SZYwvhn+lHmu2azvvMpCBMlU7lqQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 11:15:07.9183 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0734 Subject: Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 11:15:11 -0000 On Monday 25 September 2017 08:41 PM, Ferruh Yigit wrote: > On 9/25/2017 3:32 PM, Shreyansh Jain wrote: >> On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote: >>> Hello Ferruh, >>> >>> On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: >>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>>>> Signed-off-by: Shreyansh Jain >>>>> Signed-off-by: Hemant Agrawal >>>> >>>> <...> >>>> >>>>> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>>> b/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>>> new file mode 100644 >>>>> index 0000000..d97a009 >>>>> --- /dev/null >>>>> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map >>>>> @@ -0,0 +1,7 @@ >>>>> +DPDK_17.11 { >>>>> +    global: >>>>> + >>>>> +    rte_dpaa_driver_register; >>>>> +    rte_dpaa_driver_unregister; >>>> >>>> "local *;" ? >>> >>> Agree. I will change this. >>> Currently rte_dpaa_driver_* functions are being used locally within >>> bus/dpaa. >>> >> >> Even though I agree earlier that I will change this (append 'local *:' >> to the file), probably I will have to skip this. >> Further in the patch series, there are some symbols which are added >> which are required by the mempool and net drivers (and crypto, in >> future). Shared compilation fails for them if I add 'local: *;' here. > > It should be OK if this is last item in the first group. > > Technically I believe it will be OK to remove that line, but not quite sure. > > Lets be consistent with exiting usage and keep it, there are many sample > map files. I understand your point. Let me try - it is possible that I am doing something incorrect. Thanks.