From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Cc: christian.ehrhardt@canonical.com, thomas.monjalon@6wind.com
Subject: [dpdk-dev] [PATCH 3/3] mk: fail build on incomplete shared library dependencies
Date: Tue, 21 Jun 2016 11:11:49 +0300 [thread overview]
Message-ID: <7d5dcbf0aeac341ffc922ad972160b5312a30057.1466496709.git.pmatilai@redhat.com> (raw)
In-Reply-To: <cc770c89679f94622e340cb2bbe7b159d8bcf4d2.1466496709.git.pmatilai@redhat.com>
In-Reply-To: <cc770c89679f94622e340cb2bbe7b159d8bcf4d2.1466496709.git.pmatilai@redhat.com>
Require all symbols used by a DSO to be resolvable via LDLIBS at
build-time. Previously it was possible to build a library with
incomplete dependencies which could then fail at run-time.
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
mk/rte.lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index 1ff403f..f75ec10 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -94,7 +94,7 @@ O_TO_A_DO = @set -e; \
echo $(O_TO_A_CMD) > $(call exe2cmd,$(@))
O_TO_S = $(LD) -L$(RTE_OUTPUT)/lib $(_CPU_LDFLAGS) $(EXTRA_LDFLAGS) \
- -shared $(OBJS-y) $(LDLIBS) -Wl,-soname,$(LIB) -o $(LIB)
+ -shared $(OBJS-y) -z defs $(LDLIBS) -Wl,-soname,$(LIB) -o $(LIB)
O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
O_TO_S_DO = @set -e; \
--
2.5.5
next prev parent reply other threads:[~2016-06-21 8:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 8:11 [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation Panu Matilainen
2016-06-21 8:11 ` [dpdk-dev] [PATCH 2/3] pdump: fix missing dependency on libpthread Panu Matilainen
2016-06-21 8:11 ` Panu Matilainen [this message]
2016-06-21 10:01 ` [dpdk-dev] [PATCH 1/3] mk: fix librte_pipeline dependency list truncation Dumitrescu, Cristian
2016-06-21 10:25 ` Panu Matilainen
2016-06-21 10:31 ` Bruce Richardson
2016-06-21 10:44 ` Panu Matilainen
2016-06-21 10:58 ` Dumitrescu, Cristian
2016-06-21 11:53 ` Panu Matilainen
2016-06-26 16:41 ` [dpdk-dev] [PATCH v2 0/7] fix dependencies Thomas Monjalon
2016-06-26 16:41 ` [dpdk-dev] [PATCH v2 1/7] mk: remove traces of combined library Thomas Monjalon
2016-06-26 16:42 ` [dpdk-dev] [PATCH v2 2/7] mk: fix external library link Thomas Monjalon
2016-06-26 16:42 ` [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list Thomas Monjalon
2016-06-27 9:20 ` Dumitrescu, Cristian
2016-06-27 9:27 ` Thomas Monjalon
2016-06-26 16:42 ` [dpdk-dev] [PATCH v2 4/7] mk: fix internal dependencies Thomas Monjalon
2016-06-26 16:42 ` [dpdk-dev] [PATCH v2 5/7] mk: fix external dependencies of crypto drivers Thomas Monjalon
2016-06-27 8:48 ` Panu Matilainen
2016-06-26 16:42 ` [dpdk-dev] [PATCH v2 6/7] pdump: fix missing dependency on libpthread Thomas Monjalon
2016-06-26 16:42 ` [dpdk-dev] [PATCH v2 7/7] mk: check shared library dependencies Thomas Monjalon
2016-06-27 15:15 ` [dpdk-dev] [PATCH v2 0/7] fix dependencies Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d5dcbf0aeac341ffc922ad972160b5312a30057.1466496709.git.pmatilai@redhat.com \
--to=pmatilai@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).