Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows

[fengchengwen <fengchengwen@huawei.com>]

On 2021/10/19 20:28, Bruce Richardson wrote:
> The dmadev library was not added to the list of libraries built on
> Windows, meaning it was skipped in those builds and also that none of
> the drivers were being considered for build. Adding dmadev to the list
> fixes this, and also enables the skeleton dmadev driver to be built -
> all-be-it with a small fix necessary.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> 
> This patch has been compile tested using mingw on Linux. Sending it
> publicly so that I can get CI test reports to check native windows
> builds.
> ---
>  drivers/dma/skeleton/skeleton_dmadev.c | 2 +-
>  lib/meson.build                        | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/skeleton/skeleton_dmadev.c b/drivers/dma/skeleton/skeleton_dmadev.c
> index 2952417126..d9e4f731d7 100644
> --- a/drivers/dma/skeleton/skeleton_dmadev.c
> +++ b/drivers/dma/skeleton/skeleton_dmadev.c
> @@ -153,7 +153,7 @@ skeldma_stop(struct rte_dma_dev *dev)
>  	hw->exit_flag = true;
>  	rte_delay_ms(1);
>  
> -	pthread_cancel(hw->thread);
> +	(void)pthread_cancel(hw->thread);
>  	pthread_join(hw->thread, NULL);
>  
>  	return 0;
> diff --git a/lib/meson.build b/lib/meson.build
> index 3b8b099820..403b1f4aa4 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -75,6 +75,7 @@ if is_windows
>              'net',
>              'meter',
>              'ethdev',
> +            'dmadev',
>              'pci',
>              'cmdline',
>              'metrics',

Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>

>