From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED037A0C45; Wed, 20 Oct 2021 08:39:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75EF740150; Wed, 20 Oct 2021 08:39:55 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id EF12540142 for ; Wed, 20 Oct 2021 08:39:53 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HZ17l10bvzbnHj for ; Wed, 20 Oct 2021 14:35:15 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 14:39:39 +0800 Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Wed, 20 Oct 2021 14:39:39 +0800 To: Bruce Richardson , References: <20211019122800.1537505-1-bruce.richardson@intel.com> From: fengchengwen Message-ID: <7d5e0f47-98dc-d09e-04ec-8040b43065b3@huawei.com> Date: Wed, 20 Oct 2021 14:39:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20211019122800.1537505-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/10/19 20:28, Bruce Richardson wrote: > The dmadev library was not added to the list of libraries built on > Windows, meaning it was skipped in those builds and also that none of > the drivers were being considered for build. Adding dmadev to the list > fixes this, and also enables the skeleton dmadev driver to be built - > all-be-it with a small fix necessary. > > Signed-off-by: Bruce Richardson > --- > > This patch has been compile tested using mingw on Linux. Sending it > publicly so that I can get CI test reports to check native windows > builds. > --- > drivers/dma/skeleton/skeleton_dmadev.c | 2 +- > lib/meson.build | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/skeleton/skeleton_dmadev.c b/drivers/dma/skeleton/skeleton_dmadev.c > index 2952417126..d9e4f731d7 100644 > --- a/drivers/dma/skeleton/skeleton_dmadev.c > +++ b/drivers/dma/skeleton/skeleton_dmadev.c > @@ -153,7 +153,7 @@ skeldma_stop(struct rte_dma_dev *dev) > hw->exit_flag = true; > rte_delay_ms(1); > > - pthread_cancel(hw->thread); > + (void)pthread_cancel(hw->thread); > pthread_join(hw->thread, NULL); > > return 0; > diff --git a/lib/meson.build b/lib/meson.build > index 3b8b099820..403b1f4aa4 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -75,6 +75,7 @@ if is_windows > 'net', > 'meter', > 'ethdev', > + 'dmadev', > 'pci', > 'cmdline', > 'metrics', Reviewed-by: Chengwen Feng >