From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org, g.singh@nxp.com
Cc: stable@dpdk.org
Subject: Re: [PATCH] baseband/la12xx: fix issue with secondary process
Date: Fri, 5 Jul 2024 09:48:54 +0200 [thread overview]
Message-ID: <7d9b4d8b-27f5-4632-8327-f63bf2c3d0e8@redhat.com> (raw)
In-Reply-To: <20240702060921.3660623-1-hemant.agrawal@nxp.com>
On 7/2/24 08:09, Hemant Agrawal wrote:
> The la12xx driver do not have any checks for secondary process
> and it causes the system to try to initialize the driver, causing
> segmentation faults.
> LA12xx driver do not support multi-processing.
> Return when not called from Primary process.
>
> Fixes: f218a1f92017 ("baseband/la12xx: introduce NXP LA12xx driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> drivers/baseband/la12xx/bbdev_la12xx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c
> index bb754a5395..1a56e73abd 100644
> --- a/drivers/baseband/la12xx/bbdev_la12xx.c
> +++ b/drivers/baseband/la12xx/bbdev_la12xx.c
> @@ -1084,6 +1084,9 @@ la12xx_bbdev_remove(struct rte_vdev_device *vdev)
>
> PMD_INIT_FUNC_TRACE();
>
> + if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> + return 0;
> +
> if (vdev == NULL)
> return -EINVAL;
>
Applied to next-baseband/for-main.
Thanks,
Maxime
prev parent reply other threads:[~2024-07-05 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 6:09 Hemant Agrawal
2024-07-02 7:38 ` Maxime Coquelin
2024-07-05 7:48 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d9b4d8b-27f5-4632-8327-f63bf2c3d0e8@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).