From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98358A0503; Fri, 20 May 2022 08:55:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E96140156; Fri, 20 May 2022 08:55:44 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E837E40151 for ; Fri, 20 May 2022 08:55:42 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 498858A; Fri, 20 May 2022 09:55:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 498858A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653029742; bh=adMrYP3lNiiDuaQui8+P/szOZWj+AG5Sxdj+VG3gzD8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iHGKFMOwKu6FvtGFuZ17JNvXRBTYCFPeRPqiJ5AxPQQLgnNkPhCq2xpL3IdP5KXwL XPpri3AIpoaFYn5jH0YLJ0xFQGKE9kpqQ0UWmvExMt9tySkZ6IR+oS2aAJz2fdjfsO rgoZpmU9EZlfIC4xjOB+6uHw7fqVV6MO/zauxovc= Message-ID: <7d9ec16e-3b01-8ad6-16ea-9bca58aab309@oktetlabs.ru> Date: Fri, 20 May 2022 09:55:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH v2 2/5] app/testpmd: register driver specific commands Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, Xiaoyun Li , Aman Singh , Yuying Zhang , Bruce Richardson References: <20220513075718.18674-1-david.marchand@redhat.com> <20220518194649.1868574-1-david.marchand@redhat.com> <20220518194649.1868574-3-david.marchand@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220518194649.1868574-3-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/22 22:46, David Marchand wrote: > Introduce a testpmd API so that drivers can register specific commands. > > A driver can list some files to compile with testpmd, by setting them > in the testpmd_sources (driver local) meson variable. > drivers/meson.build then takes care of appending this to a global meson > variable, and adding the driver to testpmd dependency. > > Note: testpmd.h is fixed to that it is self sufficient when being > included. > > Signed-off-by: David Marchand LGTM, just one nit below. Acked-by: Andrew Rybchenko [snip] > @@ -94,6 +97,7 @@ static void cmd_help_brief_parsed(__rte_unused void *parsed_result, > " help filters : Filters configuration help.\n" > " help traffic_management : Traffic Management commands.\n" > " help devices : Device related cmds.\n" > + " help drivers : Driver specific cmds.\n" I'd not mimic the previous line here and use full "commands" instead as two lines above. > " help all : All of the above sections.\n\n" > ); > [snip]