From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0202A04DD; Wed, 28 Oct 2020 11:37:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82206C9D0; Wed, 28 Oct 2020 11:37:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id A370AC9CC for ; Wed, 28 Oct 2020 11:37:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603881431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PwtWtcoeC2CQmCicaMRhDYiHY8MFDr+FVv3cbSpCF7g=; b=Rjk2jUHVToEkYe6XJfMOVBvN028eAfU4SoPhVeQ/8mDvDi/2tEbxKGVk+Kiu8tg3mutXBv PRXCyrtj4QkDhXFh7OCPMP5uujUP6YBcY3TsBZ3LbrFk7mgNLfTcz73/iuRwohbRUTbWlr Xeb/0BCzVVhbjL6s49r7JiXt4GvYsEg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-EvFKUbthM6a7_8NWzap-lg-1; Wed, 28 Oct 2020 06:37:07 -0400 X-MC-Unique: EvFKUbthM6a7_8NWzap-lg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F0EF1009E27; Wed, 28 Oct 2020 10:37:06 +0000 (UTC) Received: from [10.36.110.54] (unknown [10.36.110.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42DF75D9EF; Wed, 28 Oct 2020 10:37:03 +0000 (UTC) To: Adrian Moreno , dev@dpdk.org Cc: yinan.wang@intel.com, patrick.fu@intel.com, chenbo.xia@intel.com, zhihong.wang@intel.com, stable@dpdk.org References: <20201026163930.94032-1-amorenoz@redhat.com> <20201026163930.94032-6-amorenoz@redhat.com> From: Maxime Coquelin Message-ID: <7da401c6-7532-b1c5-6500-ea2016a0e600@redhat.com> Date: Wed, 28 Oct 2020 11:37:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201026163930.94032-6-amorenoz@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/virtio-user: don't assume vhost status feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/20 5:39 PM, Adrian Moreno wrote: > There are some status reads and updates that need to happen before the > protocol features are negotiated. Therefore, assuming the backend does > support this feature can lead to failures. > > On server mode, do not assume the backend supports > VHOST_USER_PROTOCOL_F_STATUS. Activate it back on reconnection and > cleare it on disconnection. > > Fixes: 57912824615f ("net/virtio-user: support vhost status setting") > Cc: maxime.coquelin@redhat.com > Cc: stable@dpdk.org > > Signed-off-by: Adrian Moreno > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 ++++++ > drivers/net/virtio/virtio_user_ethdev.c | 8 ++++++++ > 2 files changed, 14 insertions(+) > Reviewed-by: Maxime Coquelin Thanks, Maxime