* Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()
2018-04-09 20:18 [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get() Rami Rosen
@ 2018-04-09 13:56 ` Kumar, Ravi1
2018-04-09 14:02 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Kumar, Ravi1 @ 2018-04-09 13:56 UTC (permalink / raw)
To: Rami Rosen, ferruh.yigit; +Cc: dev
>This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.
>
>Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>---
> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>index 07c1337ac..a9a9fb570 100644
>--- a/drivers/net/axgbe/axgbe_ethdev.c
>+++ b/drivers/net/axgbe/axgbe_ethdev.c
>@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
> struct axgbe_port *pdata = dev->data->dev_private;
>
> dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>- dev_info->max_rx_queues = pdata->tx_ring_count;
>- dev_info->max_tx_queues = pdata->rx_ring_count;
>+ dev_info->max_rx_queues = pdata->rx_ring_count;
>+ dev_info->max_tx_queues = pdata->tx_ring_count;
> dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
> dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
> dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>--
>2.14.3
>
Thanks a lot Remi. Wonderful catch.
Regards,
Ravi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()
2018-04-09 13:56 ` Kumar, Ravi1
@ 2018-04-09 14:02 ` Ferruh Yigit
2018-04-12 18:02 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-04-09 14:02 UTC (permalink / raw)
To: Kumar, Ravi1, Rami Rosen; +Cc: dev
On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
>> This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.
>>
>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>> ---
>> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>> index 07c1337ac..a9a9fb570 100644
>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>> @@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
>> struct axgbe_port *pdata = dev->data->dev_private;
>>
>> dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>> - dev_info->max_rx_queues = pdata->tx_ring_count;
>> - dev_info->max_tx_queues = pdata->rx_ring_count;
>> + dev_info->max_rx_queues = pdata->rx_ring_count;
>> + dev_info->max_tx_queues = pdata->tx_ring_count;
>> dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
>> dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
>> dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>> --
>> 2.14.3
>>
>
> Thanks a lot Remi. Wonderful catch.
I am adding your explicit ack for the patch:
Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
>
> Regards,
> Ravi
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()
@ 2018-04-09 20:18 Rami Rosen
2018-04-09 13:56 ` Kumar, Ravi1
0 siblings, 1 reply; 4+ messages in thread
From: Rami Rosen @ 2018-04-09 20:18 UTC (permalink / raw)
To: ferruh.yigit; +Cc: ravi1.kumar, dev, Rami Rosen
This patch fixes a tirvial error in assigning max Rx/Tx
queues in axgbe_dev_info_get() of the axgbe PMD driver.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index 07c1337ac..a9a9fb570 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
struct axgbe_port *pdata = dev->data->dev_private;
dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
- dev_info->max_rx_queues = pdata->tx_ring_count;
- dev_info->max_tx_queues = pdata->rx_ring_count;
+ dev_info->max_rx_queues = pdata->rx_ring_count;
+ dev_info->max_tx_queues = pdata->tx_ring_count;
dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
--
2.14.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()
2018-04-09 14:02 ` Ferruh Yigit
@ 2018-04-12 18:02 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-04-12 18:02 UTC (permalink / raw)
To: Kumar, Ravi1, Rami Rosen; +Cc: dev
On 4/9/2018 3:02 PM, Ferruh Yigit wrote:
> On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
>>> This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver.
>>>
>>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>>> ---
>>> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>>> index 07c1337ac..a9a9fb570 100644
>>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>>> @@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
>>> struct axgbe_port *pdata = dev->data->dev_private;
>>>
>>> dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>>> - dev_info->max_rx_queues = pdata->tx_ring_count;
>>> - dev_info->max_tx_queues = pdata->rx_ring_count;
>>> + dev_info->max_rx_queues = pdata->rx_ring_count;
>>> + dev_info->max_tx_queues = pdata->tx_ring_count;
>>> dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
>>> dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
>>> dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>>> --
>>> 2.14.3
>>>
>>
>> Thanks a lot Remi. Wonderful catch.
>
> I am adding your explicit ack for the patch:
> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-12 18:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 20:18 [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get() Rami Rosen
2018-04-09 13:56 ` Kumar, Ravi1
2018-04-09 14:02 ` Ferruh Yigit
2018-04-12 18:02 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).